This is an automated email from the ASF dual-hosted git repository. nixon pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/branch-2.0 by this push: new 55cb081 Revert "ATLAS-4058: UI: Fix Entity detail page Hive Column Position with 0 is set to NA." 55cb081 is described below commit 55cb08102214c8095fb0241d19ee792b035a58c2 Author: nixonrodrigues <ni...@apache.org> AuthorDate: Thu Jun 10 19:34:50 2021 +0530 Revert "ATLAS-4058: UI: Fix Entity detail page Hive Column Position with 0 is set to NA." This reverts commit de87800c19ea06f53904a2948fcde29a57d2f051. (cherry picked from commit 1078f25e90134be4a7e9f35f9774c113909aba97) --- .../public/js/views/audit/CreateAuditTableLayoutView.js | 3 --- .../public/js/views/entity/EntityDetailTableLayoutView.js | 10 +--------- .../public/js/views/audit/CreateAuditTableLayoutView.js | 3 --- .../public/js/views/entity/EntityDetailTableLayoutView.js | 10 +--------- 4 files changed, 2 insertions(+), 24 deletions(-) diff --git a/dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js b/dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js index e107a2d..20eac06 100644 --- a/dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js +++ b/dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js @@ -95,9 +95,6 @@ define(['require', getValue: function(val, key) { if (key && key.toLowerCase().indexOf("time") > 0) { return Utils.formatDate({ date: val }); - } else if (key && key.toLowerCase().indexOf("position") === 0 && val === 0) { - //if position value is 0 we are showing N/A - return "N/A"; } else { return val; } diff --git a/dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js b/dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js index a47e075..a5b5262 100644 --- a/dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js +++ b/dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js @@ -81,15 +81,7 @@ define(['require', scope: this, valueObject: _.extend({ "isIncomplete": this.entity.isIncomplete }, this.entity.attributes), attributeDefs: this.attributeDefs, - highlightString: highlightString, - getValue: function(val, key) { - if (key && key.toLowerCase().indexOf("position") === 0 && val === 0) { - //if position value is 0 we are showing N/A - return "N/A"; - } else { - return val; - } - } + highlightString: highlightString }); this.ui.detailValue.append(table); Utils.togglePropertyRelationshipTableEmptyValues({ diff --git a/dashboardv3/public/js/views/audit/CreateAuditTableLayoutView.js b/dashboardv3/public/js/views/audit/CreateAuditTableLayoutView.js index 7758821..0e2ade3 100644 --- a/dashboardv3/public/js/views/audit/CreateAuditTableLayoutView.js +++ b/dashboardv3/public/js/views/audit/CreateAuditTableLayoutView.js @@ -96,9 +96,6 @@ define(['require', getValue: function(val, key) { if (key && key.toLowerCase().indexOf("time") > 0) { return Utils.formatDate({ date: val }); - } else if (key && key.toLowerCase().indexOf("position") === 0 && val === 0) { - //if position value is 0 we are showing N/A - return "N/A"; } else { return val; } diff --git a/dashboardv3/public/js/views/entity/EntityDetailTableLayoutView.js b/dashboardv3/public/js/views/entity/EntityDetailTableLayoutView.js index a47e075..a5b5262 100644 --- a/dashboardv3/public/js/views/entity/EntityDetailTableLayoutView.js +++ b/dashboardv3/public/js/views/entity/EntityDetailTableLayoutView.js @@ -81,15 +81,7 @@ define(['require', scope: this, valueObject: _.extend({ "isIncomplete": this.entity.isIncomplete }, this.entity.attributes), attributeDefs: this.attributeDefs, - highlightString: highlightString, - getValue: function(val, key) { - if (key && key.toLowerCase().indexOf("position") === 0 && val === 0) { - //if position value is 0 we are showing N/A - return "N/A"; - } else { - return val; - } - } + highlightString: highlightString }); this.ui.detailValue.append(table); Utils.togglePropertyRelationshipTableEmptyValues({