[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393970454 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py #

[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393969469 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py #

[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393974676 ## File path: sdks/python/apache_beam/transforms/deduplicate.py ## @@ -0,0 +1,10

[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393976398 ## File path: sdks/python/apache_beam/transforms/deduplicate.py ## @@ -0,0 +1,10

[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393972784 ## File path: sdks/python/apache_beam/transforms/deduplicate.py ## @@ -0,0 +1,10

[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393978328 ## File path: sdks/python/apache_beam/transforms/deduplicate.py ## @@ -0,0 +1,10

[GitHub] [beam] robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-17 Thread GitBox
robertwb commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r393968339 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py #

[GitHub] [beam] rohdesamuel opened a new pull request #11148: First test, still broken. Is it reading from cache?

2020-03-17 Thread GitBox
rohdesamuel opened a new pull request #11148: First test, still broken. Is it reading from cache? URL: https://github.com/apache/beam/pull/11148 Change-Id: I9fe25f2875eaa32e0cc19e9b4862b86477f7b8e7 **Please** add a meaningful description for your change here --

[GitHub] [beam] pabloem commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
pabloem commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147#issuecomment-600293642 Run Portable_Python PreCommit This is an automated message fr

[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-17 Thread GitBox
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#issuecomment-600287442 Run Java PreCommit This is an

[GitHub] [beam] pabloem commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
pabloem commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147#issuecomment-600286040 retest this please This is an automated message from the Apac

[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-17 Thread GitBox
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#issuecomment-600284951 CC: @boyuanzz This is an aut

[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-17 Thread GitBox
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#issuecomment-600284307 R: @mxm @iemejia This is an

[GitHub] [beam] KevinGG commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
KevinGG commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147#issuecomment-600283827 Changed to raise ValueError when input is invalid for `show`, also rebased to current HEAD to pick up most recent changes. --

[GitHub] [beam] davidyan74 commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-17 Thread GitBox
davidyan74 commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-600268879 Fiiled BEAM-9530. This is an automated me

[GitHub] [beam] davidyan74 commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-17 Thread GitBox
davidyan74 commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-600268032 Thanks @tvalentyn. We might want to add `pip check` after pip install in our tests to make sure there is n

[GitHub] [beam] aaltay commented on issue #11141: [BEAM-7923] Include side effects in p.run

2020-03-17 Thread GitBox
aaltay commented on issue #11141: [BEAM-7923] Include side effects in p.run URL: https://github.com/apache/beam/pull/11141#issuecomment-600261516 Merged this, without noticing that test did not run. Fooled by githubs "all green check signs". Please watch the tests, especially the cron ones

[GitHub] [beam] aaltay merged pull request #11141: [BEAM-7923] Include side effects in p.run

2020-03-17 Thread GitBox
aaltay merged pull request #11141: [BEAM-7923] Include side effects in p.run URL: https://github.com/apache/beam/pull/11141 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] KevinGG commented on issue #11141: [BEAM-7923] Include side effects in p.run

2020-03-17 Thread GitBox
KevinGG commented on issue #11141: [BEAM-7923] Include side effects in p.run URL: https://github.com/apache/beam/pull/11141#issuecomment-600260121 Rebased to resolve merge conflicts and force pushed! This is an automated messa

[GitHub] [beam] KevinGG commented on a change in pull request #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
KevinGG commented on a change in pull request #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147#discussion_r393922585 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@ -276,6

[GitHub] [beam] pabloem commented on a change in pull request #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
pabloem commented on a change in pull request #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147#discussion_r393920308 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@ -276,6

[GitHub] [beam] KevinGG commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
KevinGG commented on issue #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147#issuecomment-600253084 Formatted with yapf. Lint passed locally. R: @pabloem R: @rohdesamuel R: @davidyan74 PTAL, thx!

[GitHub] [beam] KevinGG opened a new pull request #11147: [BEAM-7923] Support dict and iterable PCollections in show

2020-03-17 Thread GitBox
KevinGG opened a new pull request #11147: [BEAM-7923] Support dict and iterable PCollections in show URL: https://github.com/apache/beam/pull/11147 1. Added support of dict and iterable of PCollections as *args in the show API. 2. Added typehints for show. 3. Added tests for the ne

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-03-17 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r393912657 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1078 @@ records.apply("WriteToText", See t

[GitHub] [beam] Akshay-Iyangar commented on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic

2020-03-17 Thread GitBox
Akshay-Iyangar commented on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic URL: https://github.com/apache/beam/pull/10078#issuecomment-600249483 @aromanenko-dev - No issues, we can keep both the sync and the async for time-being. Are you ok with me just

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-03-17 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r393907154 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1076 @@ records.apply("WriteToText", See t

[GitHub] [beam] TheNeuralBit commented on issue #10767: Document Beam Schemas

2020-03-17 Thread GitBox
TheNeuralBit commented on issue #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#issuecomment-600245688 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git Service. To r

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-17 Thread GitBox
ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#discussion_r393879915 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -563,19 +562,3

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-17 Thread GitBox
ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#discussion_r393879970 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -563,19 +562,3

[GitHub] [beam] ibzib merged pull request #11123: [BEAM-9503] Insert missing comma in process worker script.

2020-03-17 Thread GitBox
ibzib merged pull request #11123: [BEAM-9503] Insert missing comma in process worker script. URL: https://github.com/apache/beam/pull/11123 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aromanenko-dev edited a comment on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic

2020-03-17 Thread GitBox
aromanenko-dev edited a comment on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic URL: https://github.com/apache/beam/pull/10078#issuecomment-600204986 I did another review round and see that we still have user API breaking changes there. I'm wonderi

[GitHub] [beam] aromanenko-dev commented on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic

2020-03-17 Thread GitBox
aromanenko-dev commented on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic URL: https://github.com/apache/beam/pull/10078#issuecomment-600204986 I did another review round and see that we still have user API breaking changes there. I'm wondering if w

[GitHub] [beam] amaliujia commented on issue #11115: [cherry-pick][release-2.20.0][BEAM-9494] Reifying outputs from BQ file writing

2020-03-17 Thread GitBox
amaliujia commented on issue #5: [cherry-pick][release-2.20.0][BEAM-9494] Reifying outputs from BQ file writing URL: https://github.com/apache/beam/pull/5#issuecomment-600202987 no problem! This is an automated messag

[GitHub] [beam] Ardagan commented on a change in pull request #11076: Run precommit portability on java 11

2020-03-17 Thread GitBox
Ardagan commented on a change in pull request #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#discussion_r393832528 ## File path: sdks/java/testing/test-utils/build.gradle ## @@ -39,3 +39,14 @@ dependencies { testCompile libra

[GitHub] [beam] Ardagan commented on a change in pull request #11076: Run precommit portability on java 11

2020-03-17 Thread GitBox
Ardagan commented on a change in pull request #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#discussion_r393831160 ## File path: sdks/java/testing/test-utils/build.gradle ## @@ -39,3 +39,14 @@ dependencies { testCompile libra

[GitHub] [beam] aromanenko-dev commented on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic

2020-03-17 Thread GitBox
aromanenko-dev commented on issue #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic URL: https://github.com/apache/beam/pull/10078#issuecomment-600184525 retest this please This is an automated mess

[GitHub] [beam] tvalentyn merged pull request #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-17 Thread GitBox
tvalentyn merged pull request #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142 This is an automated message from the Apache Git Service. To re

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-17 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-600167192 Test logs LGTM: https://builds.apache.org/job/beam_PostCommit_Py_ValCont_PR/123/timestamps/?time=HH:mm:ss&t

[GitHub] [beam] kamilwu commented on issue #11146: Flink 1.10 yarn deployment fix

2020-03-17 Thread GitBox
kamilwu commented on issue #11146: Flink 1.10 yarn deployment fix URL: https://github.com/apache/beam/pull/11146#issuecomment-600159265 Run Load Tests Python Combine Flink Batch This is an automated message from the Apache Git

[GitHub] [beam] aromanenko-dev commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-17 Thread GitBox
aromanenko-dev commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-600158638 I think it's almost LGTM, just requires some Javadoc updates on using rate limiter in multiple threads.

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-17 Thread GitBox
aromanenko-dev commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#discussion_r393796823 ## File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java #

[GitHub] [beam] kamilwu commented on issue #11146: Flink 1.10 yarn deployment fix

2020-03-17 Thread GitBox
kamilwu commented on issue #11146: Flink 1.10 yarn deployment fix URL: https://github.com/apache/beam/pull/11146#issuecomment-600154666 R: @mwalenia This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] kamilwu commented on issue #11146: Flink 1.10 yarn deployment fix

2020-03-17 Thread GitBox
kamilwu commented on issue #11146: Flink 1.10 yarn deployment fix URL: https://github.com/apache/beam/pull/11146#issuecomment-600154570 Run Seed Job This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [beam] kamilwu opened a new pull request #11146: Flink 1.10 yarn deployment fix

2020-03-17 Thread GitBox
kamilwu opened a new pull request #11146: Flink 1.10 yarn deployment fix URL: https://github.com/apache/beam/pull/11146 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] Hannah-Jiang commented on issue #11145: Update dataflow py container ver

2020-03-17 Thread GitBox
Hannah-Jiang commented on issue #11145: Update dataflow py container ver URL: https://github.com/apache/beam/pull/11145#issuecomment-600150352 @tvalentyn , thank you! This is an automated message from the Apache Git Service. T

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393773039 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393777307 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393783135 ## File path: website/src/documentation/patterns/overview.md ##

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393774898 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393775656 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393770423 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393778967 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393774212 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393778127 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] lukecwik merged pull request #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write

2020-03-17 Thread GitBox
lukecwik merged pull request #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write URL: https://github.com/apache/beam/pull/9758 This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600135623 Run Load Tests Java Combine Portable Flink Batch This i

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-17 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393764367 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600133615 run seed job This is an automated message from the Apac

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600131618 run seed job This is an automated message from the Apac

[GitHub] [beam] JozoVilcek commented on issue #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s)

2020-03-17 Thread GitBox
JozoVilcek commented on issue #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s) URL: https://github.com/apache/beam/pull/11099#issuecomment-600113601 @kennknowles is there anything else you would like to improve in this PR?

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600109497 Run Load Tests Java Combine Portable Flink Batch This i

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600106774 run seed job This is an automated message from the Apac

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-17 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-600096815 run java precommit This is an automated message

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600081286 Run Load Tests Java Combine Portable Flink Batch This i

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600076078 run seed job This is an automated message from the Apac

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600070865 Run Load Tests Java Combine Portable Flink Streaming Th

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600052646 Run Load Tests Java Combine Portable Flink Batch This i

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600037517 run seed job This is an automated message from the Apac

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600031195 Run Load Tests Java Combine Portable Flink Batch This i

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-600029608 run seed job This is an automated message from the Apac

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-17 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-600011416 Run Java PreCommit This is an automated message

[GitHub] [beam] mxm merged pull request #11134: Skip removal of manifest when no artifacts were staged.

2020-03-17 Thread GitBox
mxm merged pull request #11134: Skip removal of manifest when no artifacts were staged. URL: https://github.com/apache/beam/pull/11134 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-599965509 run seed job This is an automated message from the Apac

[GitHub] [beam] echauchot commented on issue #11055: [BEAM-9436] improve GBK in spark structured streaming runner

2020-03-17 Thread GitBox
echauchot commented on issue #11055: [BEAM-9436] improve GBK in spark structured streaming runner URL: https://github.com/apache/beam/pull/11055#issuecomment-599954467 Run Spark StructuredStreaming ValidatesRunner This is an

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-599928528 Run Load Tests Java Combine Portable Flink Batch This i

[GitHub] [beam] tvalentyn commented on issue #11145: Update dataflow py container ver

2020-03-17 Thread GitBox
tvalentyn commented on issue #11145: Update dataflow py container ver URL: https://github.com/apache/beam/pull/11145#issuecomment-599926012 Dataflow precommit ITs passed; test failure is not related, opened https://issues.apache.org/jira/browse/BEAM-9527. --

[GitHub] [beam] tvalentyn merged pull request #11145: Update dataflow py container ver

2020-03-17 Thread GitBox
tvalentyn merged pull request #11145: Update dataflow py container ver URL: https://github.com/apache/beam/pull/11145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-17 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-599922203 Run Python Dataflow ValidatesContainer Thi

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-17 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-599915764 run seed job This is an automated message from the Apac

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-17 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599912960 Run Java PreCommit This is an automated message

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-16 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-599906766 While Jenkins does not show test result on the PR, the tests are actually running: https://builds.apache.or

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-16 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-599900258 LGTM A few things out of scope of this PR: 1) This PR fixes the incompatibility in dependencies, but t

[GitHub] [beam] tvalentyn commented on issue #11145: Update dataflow py container ver

2020-03-16 Thread GitBox
tvalentyn commented on issue #11145: Update dataflow py container ver URL: https://github.com/apache/beam/pull/11145#issuecomment-599899591 Run Python PreCommit This is an automated message from the Apache Git Service. To resp

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-16 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-599896422 Run Python Dataflow ValidatesContainer Thi

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-16 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-599896374 Thanks, @davidyan74! Added a small change to reflect that `typing` should only be installed on Python 2 (th

[GitHub] [beam] stale[bot] commented on issue #10038: Simplify Python test process

2020-03-16 Thread GitBox
stale[bot] commented on issue #10038: Simplify Python test process URL: https://github.com/apache/beam/pull/10038#issuecomment-599890655 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s i

[GitHub] [beam] Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies

2020-03-16 Thread GitBox
Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#issuecomment-599871035 > In general, it's preferable to avoid checking in script-created files, preferring instead to create them on demand at build time. (There a

[GitHub] [beam] Hannah-Jiang opened a new pull request #11145: Update dataflow py container ver

2020-03-16 Thread GitBox
Hannah-Jiang opened a new pull request #11145: Update dataflow py container ver URL: https://github.com/apache/beam/pull/11145 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] pabloem commented on issue #11115: [cherry-pick][release-2.20.0][BEAM-9494] Reifying outputs from BQ file writing

2020-03-16 Thread GitBox
pabloem commented on issue #5: [cherry-pick][release-2.20.0][BEAM-9494] Reifying outputs from BQ file writing URL: https://github.com/apache/beam/pull/5#issuecomment-599846684 This is no longer needed. Sorry and thanks @amaliujia

[GitHub] [beam] pabloem closed pull request #11115: [cherry-pick][release-2.20.0][BEAM-9494] Reifying outputs from BQ file writing

2020-03-16 Thread GitBox
pabloem closed pull request #5: [cherry-pick][release-2.20.0][BEAM-9494] Reifying outputs from BQ file writing URL: https://github.com/apache/beam/pull/5 This is an automated message from the Apache Git Service. To r

[GitHub] [beam] suztomo closed pull request #11125: [BEAM-9444] (Old) Use Google Cloud Libraries BOM to set GCP library dependencies

2020-03-16 Thread GitBox
suztomo closed pull request #11125: [BEAM-9444] (Old) Use Google Cloud Libraries BOM to set GCP library dependencies URL: https://github.com/apache/beam/pull/11125 This is an automated message from the Apache Git Service. To

[GitHub] [beam] aaltay commented on issue #11141: [BEAM-7923] Include side effects in p.run

2020-03-16 Thread GitBox
aaltay commented on issue #11141: [BEAM-7923] Include side effects in p.run URL: https://github.com/apache/beam/pull/11141#issuecomment-599839271 Could you resolve the conflict? This is an automated message from the Apache Git

[GitHub] [beam] youngoli commented on issue #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-16 Thread GitBox
youngoli commented on issue #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#issuecomment-599832332 Btw, only major thing I was unsure of. Should I be hiding this functionality behind an experiment flag of some kind? T

[GitHub] [beam] youngoli commented on issue #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-16 Thread GitBox
youngoli commented on issue #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#issuecomment-599831761 R: @lostluck This is an automated message from the A

[GitHub] [beam] youngoli opened a new pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-16 Thread GitBox
youngoli opened a new pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144 Added SDF detection and method validation when creating DoFns. This adds all the validation except for anything to do with restricti

[GitHub] [beam] youngoli merged pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs.

2020-03-16 Thread GitBox
youngoli merged pull request #10991: [BEAM-3301] Refactor DoFn validation & allow specifying main inputs. URL: https://github.com/apache/beam/pull/10991 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt

2020-03-16 Thread GitBox
tvalentyn commented on issue #11142: [BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt URL: https://github.com/apache/beam/pull/11142#issuecomment-599826365 Run Python Dataflow ValidatesContainer Thi

[GitHub] [beam] apilloud commented on a change in pull request #11119: [BEAM-9498] Include descriptor and type of unsupported fields in RowJson exception

2020-03-16 Thread GitBox
apilloud commented on a change in pull request #9: [BEAM-9498] Include descriptor and type of unsupported fields in RowJson exception URL: https://github.com/apache/beam/pull/9#discussion_r393390344 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowJson.

[GitHub] [beam] apilloud commented on a change in pull request #11119: [BEAM-9498] Include descriptor and type of unsupported fields in RowJson exception

2020-03-16 Thread GitBox
apilloud commented on a change in pull request #9: [BEAM-9498] Include descriptor and type of unsupported fields in RowJson exception URL: https://github.com/apache/beam/pull/9#discussion_r393391148 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowJson.

[GitHub] [beam] youngoli commented on issue #11143: [BEAM-9526] Add missing unmarshalling in top.LargestPerKey.

2020-03-16 Thread GitBox
youngoli commented on issue #11143: [BEAM-9526] Add missing unmarshalling in top.LargestPerKey. URL: https://github.com/apache/beam/pull/11143#issuecomment-599826047 R: @lostluck This is an automated message from the Apache

<    6   7   8   9   10   11   12   13   14   15   >