[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395380173 ## File path: sdks/python/apache_beam/dataframe/transforms_test.py ## @@ -0,0 +1,87 @@ +# +# Licensed to the Apa

[GitHub] [beam] KevinGG commented on issue #11174: [BEAM-7923] Pop failed transform in CombineGlobally

2020-03-19 Thread GitBox
KevinGG commented on issue #11174: [BEAM-7923] Pop failed transform in CombineGlobally URL: https://github.com/apache/beam/pull/11174#issuecomment-601467279 yapf formatted. Lint passed locally. R: @aaltay R: @davidyan74 R: @rohdesamuel PTAL, thx! -

[GitHub] [beam] TheNeuralBit merged pull request #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit merged pull request #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169 This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601464402 PreCommit failures seem to be unrelated flakes, going ahead with merge. --

[GitHub] [beam] KevinGG opened a new pull request #11174: [BEAM-7923] Pop failed transform in CombineGlobally

2020-03-19 Thread GitBox
KevinGG opened a new pull request #11174: [BEAM-7923] Pop failed transform in CombineGlobally URL: https://github.com/apache/beam/pull/11174 1. The problem: when the CombineGlobally raises the ValueError, it breaks out the process of transform `apply` where the current transform has b

[GitHub] [beam] aaltay commented on issue #10958: [BEAM] Submitting final communication strategy

2020-03-19 Thread GitBox
aaltay commented on issue #10958: [BEAM] Submitting final communication strategy URL: https://github.com/apache/beam/pull/10958#issuecomment-601456252 What should be the next action for this PR? Should we close it, if it is going to the wiki? ---

[GitHub] [beam] aaltay commented on issue #11008: Update comment to tell user this is not secure

2020-03-19 Thread GitBox
aaltay commented on issue #11008: Update comment to tell user this is not secure URL: https://github.com/apache/beam/pull/11008#issuecomment-601455946 What should be the next action here? Should we remove it? Or add this comment?

[GitHub] [beam] aaltay merged pull request #11098: fix typo at Python Package name

2020-03-19 Thread GitBox
aaltay merged pull request #11098: fix typo at Python Package name URL: https://github.com/apache/beam/pull/11098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [beam] reuvenlax commented on issue #11074: Store logical type values in Row instead of base values

2020-03-19 Thread GitBox
reuvenlax commented on issue #11074: Store logical type values in Row instead of base values URL: https://github.com/apache/beam/pull/11074#issuecomment-601452425 @alexvanboxel I've rebased on top of your PR now. the only conflicts were in Row.java, which I've now handled. ---

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601442957 retest this please This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601441491 retest this please This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601441547 retest this please This is an automated message from the Apache Git

[GitHub] [beam] boyuanzz commented on issue #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

2020-03-19 Thread GitBox
boyuanzz commented on issue #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#issuecomment-601435026 @robertwb Please take another look. Thanks for your help : ) --

[GitHub] [beam] lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers).

2020-03-19 Thread GitBox
lostluck commented on a change in pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r395339195 ## File path: sdks/go/pkg/beam/core/graph/fn_test.go ## @@ -470,6 +542,169 @@ func

[GitHub] [beam] scwhittle commented on a change in pull request #11096: [BEAM-9399] Change the redirection of System.err to be a custom PrintStream

2020-03-19 Thread GitBox
scwhittle commented on a change in pull request #11096: [BEAM-9399] Change the redirection of System.err to be a custom PrintStream URL: https://github.com/apache/beam/pull/11096#discussion_r395335810 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601430246 Run Java PreCommit This is an automated messa

[GitHub] [beam] pabloem merged pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem merged pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395253978 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache Soft

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395254391 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache Soft

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395226313 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache Soft

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395255358 ## File path: sdks/python/apache_beam/dataframe/transforms_test.py ## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r395225830 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,244 @@ +# +# Licensed to the Apache Soft

[GitHub] [beam] rohdesamuel commented on issue #11163: [BEAM-9548] Add better error handling to the TestStreamServiceController

2020-03-19 Thread GitBox
rohdesamuel commented on issue #11163: [BEAM-9548] Add better error handling to the TestStreamServiceController URL: https://github.com/apache/beam/pull/11163#issuecomment-601417922 R: @pabloem This is an automated message f

[GitHub] [beam] amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-03-19 Thread GitBox
amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch URL: https://github.com/apache/beam/pull/11081#issuecomment-601415976 Run Release Gradle Build This is an autom

[GitHub] [beam] davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r395318403 ## File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py ## @@ -63,6 +

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395310152 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395310246 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395308799 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/EnvironmentsT

[GitHub] [beam] lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#discussion_r395306659 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTra

[GitHub] [beam] pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-601407691 retest this please This is an automated messa

[GitHub] [beam] pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-601407551 retest this please This is an automated message from

[GitHub] [beam] lukecwik closed pull request #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper

2020-03-19 Thread GitBox
lukecwik closed pull request #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/11069 This is an automated message from the Apache Git Service. To respon

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601404458 retest this please This is an automated message from the Ap

[GitHub] [beam] lukecwik commented on issue #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper

2020-03-19 Thread GitBox
lukecwik commented on issue #11069: [DO NOT SUBMIT] Test UW + Dataflow + Kafka + UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/11069#issuecomment-601404598 Kafka IO tests are failing for unrelated reasons. -

[GitHub] [beam] lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r395302802 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy #

[GitHub] [beam] lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11168: [BEAM-9542] Limit and clarify the effect of "force" in Java build URL: https://github.com/apache/beam/pull/11168#discussion_r395302058 ## File path: sdks/java/io/google-cloud-platform/build.gradle ## @@ -75,6 +75,7 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#discussion_r395299472 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -277,6 +

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601398075 Run Java PreCommit This is an automated messa

[GitHub] [beam] TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s

2020-03-19 Thread GitBox
TheNeuralBit commented on issue #11169: [BEAM-9552] Bump TestPubsub subscription creation ACK deadline to 60s URL: https://github.com/apache/beam/pull/11169#issuecomment-601398189 Run SQL PostCommit This is an automated messa

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-601394987 Run Java PreCommit --

[GitHub] [beam] lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#issuecomment-601393438 Great to hear that @echauchot ! And even greater that you contribute to that framework too. Should you have any questions, do not

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r395290928 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r395290438 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-19 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r395290076 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy ## @@ -79,7 +79,23 @@ de

[GitHub] [beam] robertwb commented on issue #11173: [BEAM-9558] Add explicit end bit for data channel.

2020-03-19 Thread GitBox
robertwb commented on issue #11173: [BEAM-9558] Add explicit end bit for data channel. URL: https://github.com/apache/beam/pull/11173#issuecomment-601382441 R: @lukecwik This doesn't actually end up cleaning up the code much, and I suspect many end chunks will be empty in practice

[GitHub] [beam] robertwb opened a new pull request #11173: [BEAM-9558] Add explicit end bit for data channel.

2020-03-19 Thread GitBox
robertwb opened a new pull request #11173: [BEAM-9558] Add explicit end bit for data channel. URL: https://github.com/apache/beam/pull/11173 Until Dataflow is updated, we respect and only mark empty chunks. Thank you for your contribution! Follow this

[GitHub] [beam] robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395269373 ## File path: model/pipeline/src/main/proto/bea

[GitHub] [beam] robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395269363 ## File path: model/pipeline/src/main/proto/bea

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-19 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r395269212 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0 +1,6

[GitHub] [beam] aaltay commented on issue #11172: Add dependency comment in streaming cache

2020-03-19 Thread GitBox
aaltay commented on issue #11172: Add dependency comment in streaming cache URL: https://github.com/apache/beam/pull/11172#issuecomment-601357840 retest this please This is an automated message from the Apache Git Service. To

[GitHub] [beam] rohdesamuel commented on issue #11172: Add dependency comment in streaming cache

2020-03-19 Thread GitBox
rohdesamuel commented on issue #11172: Add dependency comment in streaming cache URL: https://github.com/apache/beam/pull/11172#issuecomment-601355885 R: @pabloem R: @aaltay This is an automated message from the Apache Git Se

[GitHub] [beam] rohdesamuel opened a new pull request #11172: Add dependency comment in streaming cache

2020-03-19 Thread GitBox
rohdesamuel opened a new pull request #11172: Add dependency comment in streaming cache URL: https://github.com/apache/beam/pull/11172 Change-Id: I203c237147dee2948004b5711c55367aa16aa8f0 Clarifies where the pathlib dependency comes from. Thank

[GitHub] [beam] robertwb merged pull request #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.

2020-03-19 Thread GitBox
robertwb merged pull request #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests. URL: https://github.com/apache/beam/pull/10988 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] aaltay commented on issue #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager

2020-03-19 Thread GitBox
aaltay commented on issue #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager URL: https://github.com/apache/beam/pull/11005#issuecomment-601352587 > I believe you need to add pathlib / pathlib2 to the setup.py. At least for py2. For python3 it might be part of the

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601349836 retest this please This is an automated message from the Apache Git

[GitHub] [beam] davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
davidyan74 commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r395122970 ## File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py ## @@ -63,6 +

[GitHub] [beam] ibzib commented on a change in pull request #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-19 Thread GitBox
ibzib commented on a change in pull request #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#discussion_r395225636 ## File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py ## @@ -47,65 +49,154 @@

[GitHub] [beam] ibzib commented on a change in pull request #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-19 Thread GitBox
ibzib commented on a change in pull request #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#discussion_r395229525 ## File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py ## @@ -47,65 +49,154 @@

[GitHub] [beam] ibzib commented on a change in pull request #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-19 Thread GitBox
ibzib commented on a change in pull request #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#discussion_r395220005 ## File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py ## @@ -47,65 +49,154 @@

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601342162 retest this please This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#discussion_r395232854 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#discussion_r395230548 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#discussion_r395230805 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#discussion_r395232405 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#discussion_r395231200 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@

[GitHub] [beam] pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on a change in pull request #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#discussion_r395233280 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@

[GitHub] [beam] soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-19 Thread GitBox
soyrice commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r395228316 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
pabloem commented on issue #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#issuecomment-601334497 retest this please This is an automated message from the Apache Git

[GitHub] [beam] aromanenko-dev merged pull request #11171: Move CHANGES template related items into template section

2020-03-19 Thread GitBox
aromanenko-dev merged pull request #11171: Move CHANGES template related items into template section URL: https://github.com/apache/beam/pull/11171 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on a change in pull request #11052: [BEAM-9446] Add missing parallelism and execution mode args.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11052: [BEAM-9446] Add missing parallelism and execution mode args. URL: https://github.com/apache/beam/pull/11052#discussion_r395220392 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -1075,6 +1075,22

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-601331123 Run Java PreCommit --

[GitHub] [beam] lukecwik commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395220391 ## File path: model/pipeline/src/main/proto/bea

[GitHub] [beam] robertwb commented on a change in pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#discussion_r395215550 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -277,6 +

[GitHub] [beam] rohdesamuel commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely

2020-03-19 Thread GitBox
rohdesamuel commented on a change in pull request #11128: [BEAM-9524] Fix for ib.show() executing indefinitely URL: https://github.com/apache/beam/pull/11128#discussion_r395218249 ## File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py ## @@ -

[GitHub] [beam] lukecwik commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395216164 ## File path: model/pipeline/src/main/proto/bea

[GitHub] [beam] robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395213529 ## File path: model/pipeline/src/main/proto/bea

[GitHub] [beam] robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
robertwb commented on a change in pull request #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#discussion_r395212786 ## File path: model/pipeline/src/main/proto/bea

[GitHub] [beam] aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread GitBox
aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-601321761 retest this please This is an automated message from the A

[GitHub] [beam] aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread GitBox
aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-601319217 retest this please This is an automated message from the A

[GitHub] [beam] iemejia opened a new pull request #11171: Move CHANGES template related items into template section

2020-03-19 Thread GitBox
iemejia opened a new pull request #11171: Move CHANGES template related items into template section URL: https://github.com/apache/beam/pull/11171 R: @aromanenko-dev This is an automated message from the Apache Git Service.

[GitHub] [beam] aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread GitBox
aaltay commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-601314853 retest this please This is an automated message from the A

[GitHub] [beam] pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured.

2020-03-19 Thread GitBox
pabloem commented on issue #11166: [BEAM-7923] Emit info when capture control options are configured. URL: https://github.com/apache/beam/pull/11166#issuecomment-601307856 retest this please This is an automated message from

[GitHub] [beam] lukecwik commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-19 Thread GitBox
lukecwik commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#discussion_r395178340 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/trans

[GitHub] [beam] lukecwik merged pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-19 Thread GitBox
lukecwik merged pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126 This is an automated message from the Apache Git S

[GitHub] [beam] lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK.

2020-03-19 Thread GitBox
lukecwik commented on issue #11162: [BEAM-9339, BEAM-2939] Drop splittable field from ParDoPayload, add splittable dofn requirement to Python SDK. URL: https://github.com/apache/beam/pull/11162#issuecomment-601292658 Run Java PreCommit --

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-601291830 Run Java PreCommit This is an automated message fr

[GitHub] [beam] reuvenlax commented on issue #11041: Use beam join api in sql

2020-03-19 Thread GitBox
reuvenlax commented on issue #11041: Use beam join api in sql URL: https://github.com/apache/beam/pull/11041#issuecomment-601289835 @kennknowles @apilloud A quick summary: This switches SQL to use the schema Join API. This should be more efficient in some cases, but more importan

[GitHub] [beam] aaltay commented on issue #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager

2020-03-19 Thread GitBox
aaltay commented on issue #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager URL: https://github.com/apache/beam/pull/11005#issuecomment-601288550 I believe you need to add pathlib / pathlib2 to the setup.py. At least for py2. For python3 it might be part of the st

[GitHub] [beam] kamilwu commented on issue #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-19 Thread GitBox
kamilwu commented on issue #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#issuecomment-601285520 Thanks @soyrice for your in-depth review! ---

[GitHub] [beam] steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-03-19 Thread GitBox
steveniemitz commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-601280654 so I think this was enough to get it working in dataflow: ``` diff --git a/runners/google-cloud-dataflow-java/worker/s

[GitHub] [beam] lukecwik merged pull request #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1

2020-03-19 Thread GitBox
lukecwik merged pull request #11157: [BEAM-9540] Rename beam:source:runner:0.1/beam:sink:runner:0.1 to beam:runner:source:v1/beam:runner:sink:v1 URL: https://github.com/apache/beam/pull/11157 This is an automated message fr

[GitHub] [beam] lukecwik merged pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK.

2020-03-19 Thread GitBox
lukecwik merged pull request #11160: [BEAM-9339] Declare capabilities in the Java SDK. URL: https://github.com/apache/beam/pull/11160 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] lukecwik merged pull request #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters.

2020-03-19 Thread GitBox
lukecwik merged pull request #11150: [BEAM-9535] Remove unused ParDoPayload.Parameters. URL: https://github.com/apache/beam/pull/11150 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] mxm commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-19 Thread GitBox
mxm commented on a change in pull request #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#discussion_r395145834 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-19 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r395146160 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] lostluck merged pull request #11164: [BEAM-9551] Environment PB Pointer cleanup

2020-03-19 Thread GitBox
lostluck merged pull request #11164: [BEAM-9551] Environment PB Pointer cleanup URL: https://github.com/apache/beam/pull/11164 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] lukecwik removed a comment on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-19 Thread GitBox
lukecwik removed a comment on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#issuecomment-600715890 R: @ihji CC: @chamikaramj ---

[GitHub] [beam] lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators

2020-03-19 Thread GitBox
lukecwik commented on issue #11126: [BEAM-9430, BEAM-2939] Migrate from ProcessContext#updateWatermark to WatermarkEstimators URL: https://github.com/apache/beam/pull/11126#issuecomment-601256891 R: @ibzib This is an automat

[GitHub] [beam] soyrice commented on issue #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-19 Thread GitBox
soyrice commented on issue #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#issuecomment-601256589 LGTM This is an automated me

[GitHub] [beam] lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics

2020-03-19 Thread GitBox
lukecwik commented on issue #11167: [BEAM-4374] Define the protos for a "short" id mechanism for metrics URL: https://github.com/apache/beam/pull/11167#issuecomment-601256422 Run Portable_Python PreCommit This is an automated

<    1   2   3   4   5   6   7   8   9   10   >