This is an automated email from the ASF dual-hosted git repository.
robertwb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 69793f6 Avoid taking abs(MIN_INT) which is undefined.
new 3918b5f Merge pull request #7688 from robertwb/timestamp-div-fixes
69793f6 is described below
commit 69793f6a2202ea4051661c9b746cba9bc65cf8f7
Author: Robert Bradshaw <rober...@google.com>
AuthorDate: Thu Jan 31 13:37:40 2019 +0100
Avoid taking abs(MIN_INT) which is undefined.
---
sdks/python/apache_beam/coders/coder_impl.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sdks/python/apache_beam/coders/coder_impl.py
b/sdks/python/apache_beam/coders/coder_impl.py
index d419038..a811e3a 100644
--- a/sdks/python/apache_beam/coders/coder_impl.py
+++ b/sdks/python/apache_beam/coders/coder_impl.py
@@ -940,7 +940,12 @@ class WindowedValueCoderImpl(StreamCoderImpl):
# TODO(BEAM-1524): Clean this up once we have a BEAM wide consensus on
# precision of timestamps.
self._from_normal_time(
- restore_sign * (abs(wv.timestamp_micros) // 1000)))
+ restore_sign * (
+ abs(
+ MIN_TIMESTAMP_micros
+ if wv.timestamp_micros < MIN_TIMESTAMP_micros
+ else wv.timestamp_micros
+ ) // 1000)))
self._windows_coder.encode_to_stream(wv.windows, out, True)
# Default PaneInfo encoded byte representing NO_FIRING.
self._pane_info_coder.encode_to_stream(wv.pane_info, out, True)
