This is an automated email from the ASF dual-hosted git repository.
robertwb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new aa9809f Unskip fixed flaky tests
new 2990a50 Merge pull request #7879 [BEAM-5692] Unskip fixed flaky tests
aa9809f is described below
commit aa9809f5156163d88fe1abe7e3651d45621f058b
Author: robbe <robbe.sneyd...@ml6.eu>
AuthorDate: Tue Feb 19 14:28:57 2019 +0100
Unskip fixed flaky tests
---
.../runners/portability/fn_api_runner_test.py | 29 ----------------------
1 file changed, 29 deletions(-)
diff --git a/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
b/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
index aadf4a8..0c5e962 100644
--- a/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
+++ b/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
@@ -21,7 +21,6 @@ import collections
import logging
import os
import random
-import sys
import tempfile
import threading
import time
@@ -121,10 +120,6 @@ class FnApiRunnerTest(unittest.TestCase):
MetricKey('myotherdofn',
MetricName('ns2', 'elementsplusone'))])
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_pardo_side_outputs(self):
def tee(elem, *tags):
for tag in tags:
@@ -253,10 +248,6 @@ class FnApiRunnerTest(unittest.TestCase):
pcoll | beam.FlatMap(cross_product, beam.pvalue.AsList(derived)),
equal_to([('a', 'a'), ('a', 'b'), ('b', 'a'), ('b', 'b')]))
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_pardo_state_only(self):
index_state_spec = userstate.CombiningValueStateSpec(
'index', beam.coders.IterableCoder(beam.coders.VarIntCoder()), sum)
@@ -279,10 +270,6 @@ class FnApiRunnerTest(unittest.TestCase):
assert_that(p | beam.Create(inputs) | beam.ParDo(AddIndex()),
equal_to(expected))
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_pardo_timers(self):
timer_spec = userstate.TimerSpec('timer', userstate.TimeDomain.WATERMARK)
@@ -306,10 +293,6 @@ class FnApiRunnerTest(unittest.TestCase):
expected = [('fired', ts) for ts in (20, 200)]
assert_that(actual, equal_to(expected))
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_pardo_state_timers(self):
state_spec = userstate.BagStateSpec('state', beam.coders.StrUtf8Coder())
timer_spec = userstate.TimerSpec('timer', userstate.TimeDomain.WATERMARK)
@@ -426,10 +409,6 @@ class FnApiRunnerTest(unittest.TestCase):
| beam.CombinePerKey(beam.combiners.MeanCombineFn()))
assert_that(res, equal_to([('a', 1.5), ('b', 3.0)]))
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_read(self):
# Can't use NamedTemporaryFile as a context
# due to https://bugs.python.org/issue14243
@@ -443,10 +422,6 @@ class FnApiRunnerTest(unittest.TestCase):
finally:
os.unlink(temp_file.name)
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_windowing(self):
with self.create_pipeline() as p:
res = (p
@@ -476,10 +451,6 @@ class FnApiRunnerTest(unittest.TestCase):
| beam.Map(lambda x: x[0]))
assert_that(gbk_res, equal_to(['a', 'b']), label='gbk')
- @unittest.skipIf(sys.version_info[0] == 3 and
- os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
- 'This test is flaky on on Python 3. '
- 'TODO: BEAM-5692')
def test_error_message_includes_stage(self):
with self.assertRaises(BaseException) as e_cm:
with self.create_pipeline() as p:
