[ 
https://issues.apache.org/jira/browse/BEAM-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373010#comment-16373010
 ] 

Łukasz Gajowy edited comment on BEAM-3440 at 2/22/18 4:19 PM:
--------------------------------------------------------------

[~kenn]

I agree about the fact that it may be hard to live with such inheritance. But 
in my opinion, living with lots of profiles whit the same purpose can be a 
burden too (duplication). Please see BEAM-3732 - I noticed that it's super easy 
to break them now. 

I didn't take a look at Gradle configuration yet. Will this be fine if I 
propose a PR for maven only and then take a look at Gradle?


was (Author: łukaszg):
I agree about the fact that it may be hard to live with such inheritance. But 
in my opinion, living with lots of profiles whit the same purpose can be a 
burden too (duplication). Please see BEAM-3732 - I noticed that it's super easy 
to break them now. 

I didn't take a look at Gradle configuration yet. Will this be fine if I 
propose a PR for maven only and then take a look at Gradle?

> Generic IOIT profiles configuration in io's parent pom.xml
> ----------------------------------------------------------
>
>                 Key: BEAM-3440
>                 URL: https://issues.apache.org/jira/browse/BEAM-3440
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Łukasz Gajowy
>            Assignee: Łukasz Gajowy
>            Priority: Major
>
> Currently developing IOITs requires copying maven profile configuration to 
> every's IO pom for profiles like: io-it-suite, runner profiles etc. This can 
> be avoided by moving all the common profiles to sdks/java/io/pom.xml parent 
> pom and leave only some test specific argument settings in concrete child 
> modules. This can be done using maven properties (<properties> section in 
> appropriate child pom's profile section). This would reduce lots of xml code 
> duplication.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to