[
https://issues.apache.org/jira/browse/BEAM-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879178#comment-15879178
]
ASF GitHub Bot commented on BEAM-1465:
--------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2067
> No natural place to flush resources in FileBasedWriter
> ------------------------------------------------------
>
> Key: BEAM-1465
> URL: https://issues.apache.org/jira/browse/BEAM-1465
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Aviem Zur
> Assignee: Aviem Zur
>
> {{FileBasedWriter}} API does not have a natural place to flush resources
> opened by the writer.
> For example, if you create an {{OutputStream}} in your {{Writer}} using the
> {{FileBasedSink}}'s channel and this {{OutputStream}} buffers outputs, there
> is no natural place to call its {{flush()}} method.
> Maybe something like {{finishWrite()}} to match the existing
> {{prepareWrite(WritableByteChannel channel)}} can work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
