[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890550#comment-15890550
]
ASF GitHub Bot commented on BEAM-1517:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888732#comment-15888732
]
Kenneth Knowles commented on BEAM-1517:
---
Event time timers never need to be dropped, since they hold
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887857#comment-15887857
]
ASF GitHub Bot commented on BEAM-1517:
--
GitHub user JingsongLi opened a pull request:
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887550#comment-15887550
]
Jingsong Lee commented on BEAM-1517:
[~kenn] Is it like {{LateDataDroppingDoFnRunner}} droping late
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879359#comment-15879359
]
Kenneth Knowles commented on BEAM-1517:
---
[~aljoscha] that makes sense to me. In both the direct
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877903#comment-15877903
]
Aljoscha Krettek commented on BEAM-1517:
[~lzljs3620320] We cannot depend on users always cleaning
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876490#comment-15876490
]
Kenneth Knowles commented on BEAM-1517:
---
In the runners I've added this GC to (direct and Dataflow) I
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876005#comment-15876005
]
Jingsong Lee commented on BEAM-1517:
Is it appropriate for the user to do the work of GC?
Just like
[
https://issues.apache.org/jira/browse/BEAM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875634#comment-15875634
]
Aljoscha Krettek commented on BEAM-1517:
[~tgroh] or [~kenn], do you have any ideas about this?