[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-07 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390399#comment-16390399 ] Kenneth Knowles commented on BEAM-3749: --- I added the test here: https://github.com/ap

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-07 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390324#comment-16390324 ] Xu Mingmin commented on BEAM-3749: -- Do you run a test to verify that? > support customize

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-07 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390311#comment-16390311 ] Kenneth Knowles commented on BEAM-3749: --- I think this link will clarify: https://git

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-07 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390271#comment-16390271 ] Xu Mingmin commented on BEAM-3749: -- I get your point, below code doesn't use the trigger s

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-07 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390129#comment-16390129 ] Kenneth Knowles commented on BEAM-3749: --- What I mean is that the windowing itself is

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-07 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390124#comment-16390124 ] Xu Mingmin commented on BEAM-3749: -- It doesn't, with {{Window.configure()}} the code is {c

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-05 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387279#comment-16387279 ] Kenneth Knowles commented on BEAM-3749: --- It turns out that the needed feature exists

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-03-01 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381653#comment-16381653 ] Xu Mingmin commented on BEAM-3749: -- Sink-based trigger has a limitation that it cannot han

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-02-28 Thread Robert Bradshaw (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381530#comment-16381530 ] Robert Bradshaw commented on BEAM-3749: --- I wonder if sink-based triggers would be a b

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-02-28 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380953#comment-16380953 ] Xu Mingmin commented on BEAM-3749: -- {{Window.triggering(trigger).discardingFiredPanes().wi

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-02-28 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380811#comment-16380811 ] Kenneth Knowles commented on BEAM-3749: --- I realize a problem though - you do need to

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-02-28 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380809#comment-16380809 ] Kenneth Knowles commented on BEAM-3749: --- Hmm, the first bit seems like a bug. You sho

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-02-26 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377862#comment-16377862 ] Xu Mingmin commented on BEAM-3749: -- {{Window.triggering(trigger).discardingFiredPanes()}}

[jira] [Commented] (BEAM-3749) support customized trigger/accumulationMode in BeamSql

2018-02-26 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377844#comment-16377844 ] Kenneth Knowles commented on BEAM-3749: --- What about this? {code} PCollectionTuple in