[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994041#comment-15994041 ] Daniel Halperin commented on BEAM-775: -- Remaining work: * Rebuild DataflowWorker to stop using the

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994020#comment-15994020 ] ASF GitHub Bot commented on BEAM-775: - Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992454#comment-15992454 ] ASF GitHub Bot commented on BEAM-775: - Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992361#comment-15992361 ] ASF GitHub Bot commented on BEAM-775: - Github user dhalperi closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992357#comment-15992357 ] ASF GitHub Bot commented on BEAM-775: - Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992113#comment-15992113 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem reopened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992112#comment-15992112 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992024#comment-15992024 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem reopened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992023#comment-15992023 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988164#comment-15988164 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem reopened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988163#comment-15988163 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987005#comment-15987005 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem opened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985697#comment-15985697 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem opened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983627#comment-15983627 ] ASF GitHub Bot commented on BEAM-775: - Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975419#comment-15975419 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937681#comment-15937681 ] Aviem Zur commented on BEAM-775: I think we should consider instead to move on

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937244#comment-15937244 ] Pablo Estrada commented on BEAM-775: I have a PR (https://github.com/apache/beam/pull/2291) that changes

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936885#comment-15936885 ] Kenneth Knowles commented on BEAM-775: -- To my understanding, aggregators and logical metrics are

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936292#comment-15936292 ] Ismaël Mejía commented on BEAM-775: --- [~pabloem] Apex runner does not seem to support Aggregators either,

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935735#comment-15935735 ] Ben Chambers commented on BEAM-775: --- (Note BEAM-1148 originally tracked porting PAssert off of

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935726#comment-15935726 ] Aviem Zur commented on BEAM-775: As [~aljoscha] mentioned we are adding this assertion to Flink runner as

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935609#comment-15935609 ] Pablo Estrada commented on BEAM-775: `TestSparkRunner` does check the values of the success/failure

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935141#comment-15935141 ] Kenneth Knowles commented on BEAM-775: -- I think it used to be that aggregators checked that the test

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935104#comment-15935104 ] Aviem Zur commented on BEAM-775: Apex runner does not support metrics either. > Remove Aggregators from the

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935079#comment-15935079 ] Pablo Estrada commented on BEAM-775: Is Flink the only runner missing Metric support? How about the Apex

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934692#comment-15934692 ] Ismaël Mejía commented on BEAM-775: --- Excellent point [~aviemzur]. Big +1. I agree that removing

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934698#comment-15934698 ] Aljoscha Krettek commented on BEAM-775: --- Specifically, [~aviemzur] is talking about

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934697#comment-15934697 ] Jean-Baptiste Onofré commented on BEAM-775: --- Good point indeed. We have to move forward on metric

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934683#comment-15934683 ] Aviem Zur commented on BEAM-775: Awesome to see we are moving forward with the removal of aggregators.

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933841#comment-15933841 ] ASF GitHub Bot commented on BEAM-775: - Github user asfgit closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933743#comment-15933743 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem opened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924750#comment-15924750 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902288#comment-15902288 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902289#comment-15902289 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem reopened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902234#comment-15902234 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem opened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900503#comment-15900503 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem reopened a pull request:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900502#comment-15900502 ] ASF GitHub Bot commented on BEAM-775: - Github user pabloem closed the pull request at:

[jira] [Commented] (BEAM-775) Remove Aggregators from the Java SDK

[ https://issues.apache.org/jira/browse/BEAM-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900187#comment-15900187 ] ASF GitHub Bot commented on BEAM-775: - GitHub user pabloem opened a pull request: