[
https://issues.apache.org/jira/browse/BEAM-4773?focusedWorklogId=122534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-122534
]
ASF GitHub Bot logged work on BEAM-4773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/18 23:02
Start Date: 12/Jul/18 23:02
Worklog Time Spent: 10m
Work Description: tweise closed pull request #5933: [BEAM-4773] Warn on
docker image pull fail
URL: https://github.com/apache/beam/pull/5933
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerCommand.java
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerCommand.java
index f9e8ea50d12..e869aa3c840 100644
---
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerCommand.java
+++
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerCommand.java
@@ -33,9 +33,12 @@
import java.util.concurrent.TimeoutException;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/** A docker command wrapper. Simplifies communications with the Docker
daemon. */
class DockerCommand {
+ private static final Logger LOG =
LoggerFactory.getLogger(DockerCommand.class);
private static final String DEFAULT_DOCKER_COMMAND = "docker";
// TODO: Should we require 64-character container ids? Docker technically
allows abbreviated ids,
@@ -70,8 +73,12 @@ public String runImage(String imageTag, List<String>
dockerOpts, List<String> ar
throws IOException, TimeoutException, InterruptedException {
checkArgument(!imageTag.isEmpty(), "Docker image tag required");
// Pull the image from docker repo. This will be no-op if the image
already exists.
- runShortCommand(
-
ImmutableList.<String>builder().add(dockerExecutable).add("pull").add(imageTag).build());
+ try {
+ runShortCommand(
+
ImmutableList.<String>builder().add(dockerExecutable).add("pull").add(imageTag).build());
+ } catch (IOException | TimeoutException | InterruptedException e) {
+ LOG.warn(String.format("Unable to pull docker image %s", imageTag), e);
+ }
// TODO: Validate args?
return runShortCommand(
ImmutableList.<String>builder()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 122534)
Time Spent: 10m
Remaining Estimate: 0h
> Flink job fails if image pull fails.
> ------------------------------------
>
> Key: BEAM-4773
> URL: https://issues.apache.org/jira/browse/BEAM-4773
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If docker pull request fails then flink job fails.
> https://github.com/apache/beam/commit/316a9962eecfc55cf5537ee547a16c2bc75ee333
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
