[GitHub] incubator-beam pull request #1651: Forward port DataflowJavaSDK/pull/512

2016-12-16 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1651 Forward port DataflowJavaSDK/pull/512 R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam sgmc

[GitHub] incubator-beam pull request #1590: [BEAM-1071] Allow for streaming tables wi...

2016-12-12 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1590 [BEAM-1071] Allow for streaming tables with CREATE_NEVER disposition You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety

[GitHub] incubator-beam pull request #1348: Update subnetwork documentation

2016-12-12 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1576: [BEAM-551] Fix toString for FileBasedSour...

2016-12-10 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1576 [BEAM-551] Fix toString for FileBasedSource You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam sgmc

[GitHub] incubator-beam pull request #1575: [BEAM-551] Fix handling of default values...

2016-12-10 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1575 [BEAM-551] Fix handling of default values for RVPs Found a bug here, fixed an added a regression test. R: @dhalperi You can merge this pull request into a Git repository by

[GitHub] incubator-beam pull request #1513: [BEAM-551] Add support for BigQueryIO.Wri...

2016-12-09 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/1513 [BEAM-551] Add support for BigQueryIO.Write R: @davorbonaci Based on https://github.com/apache/incubator-beam/pull/1238 You can merge this pull request into a Git repository

[GitHub] incubator-beam pull request #1513: [BEAM-551] Add support for BigQueryIO.Wri...

2016-12-09 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1513: [BEAM-551] Add support for BigQueryIO.Wri...

2016-12-09 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1513: [BEAM-551] Add support for BigQueryIO.Wri...

2016-12-09 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/1513 [BEAM-551] Add support for BigQueryIO.Write R: @davorbonaci Based on https://github.com/apache/incubator-beam/pull/1238 You can merge this pull request into a Git repository

[GitHub] incubator-beam pull request #1238: [BEAM-551] BigqueryIO.Read support for Va...

2016-12-09 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1549: Fix handling of null ValueProviders in Di...

2016-12-07 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1549 Fix handling of null ValueProviders in DisplayData R: @swegner You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator

[GitHub] incubator-beam pull request #1545: [BEAM-551] Fix handling of TextIO.Sink

2016-12-07 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1545 [BEAM-551] Fix handling of TextIO.Sink R: @dhalperi Directory needs to be parameterized. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-beam pull request #1506: Improve BigQuery load error message

2016-12-07 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1238: [BEAM-551] BigqueryIO.Read support for Va...

2016-12-06 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/1238 [BEAM-551] BigqueryIO.Read support for ValueProvider R: @dhalperi This is the serialization issue I was referencing, where I think the issue is that there is a deferred

[GitHub] incubator-beam pull request #1238: [BEAM-551] BigqueryIO.Read support for Va...

2016-12-06 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1513: [BEAM-551] Add support for BigQueryIO.Wri...

2016-12-05 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1513 [BEAM-551] Add support for BigQueryIO.Write R: @davorbonaci Based on https://github.com/apache/incubator-beam/pull/1238 You can merge this pull request into a Git repository

[GitHub] incubator-beam pull request #1459: [BEAM-551] Changes to BigQuery validation...

2016-12-05 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1506: Improve BigQuery load error message

2016-12-04 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1506 Improve BigQuery load error message R: @davorbonaci You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam sgmc

[GitHub] incubator-beam pull request #1504: [BEAM-551] Add support for native PubSubI...

2016-12-03 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1504 [BEAM-551] Add support for native PubSubIO R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam

[GitHub] incubator-beam pull request #1503: [BEAM-551] Add DisplayData handling of Va...

2016-12-03 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1503 [BEAM-551] Add DisplayData handling of ValueProvider R: @dhalperi Notes: - An alternative would be to accept ValueProvider and call T.toString() if isAccessible - The

[GitHub] incubator-beam pull request #1229: [Ignore] Add a template for PubSub -> Big...

2016-12-02 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1475: [BEAM-551] Add TextIO.Write support for V...

2016-11-30 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1475 [BEAM-551] Add TextIO.Write support for ValueProvider R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety

[GitHub] incubator-beam pull request #1459: [BEAM-551] Changes to BigQuery validation...

2016-11-29 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1459 [BEAM-551] Changes to BigQuery validation to support dynamic values R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-beam pull request #1452: [BEAM-551] Add a test to demonstrate NVP ...

2016-11-29 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1452 [BEAM-551] Add a test to demonstrate NVP serialization R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety

[GitHub] incubator-beam pull request #1441: Fix double-close bug

2016-11-28 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1441 Fix double-close bug The WritableByteChannel returned for GCS locations has a bug where calling close twice throws an Exception, so we cannot safely use AutoCloseable here. R

[GitHub] incubator-beam pull request #1230: [BEAM-551] PubsubIO with ValueProvider

2016-11-19 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1230: [BEAM-551] PubsubIO with ValueProvider

2016-11-19 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/1230 [BEAM-551] PubsubIO with ValueProvider R: @davorbonaci You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety

[GitHub] incubator-beam pull request #1354: Add IP configuration to Python SDK

2016-11-18 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1354: Add IP configuration to Python SDK

2016-11-11 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1354 Add IP configuration to Python SDK R: @chamikaramj You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam sgmc

[GitHub] incubator-beam pull request #1348: Update subnetwork documentation

2016-11-11 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1348 Update subnetwork documentation R: @davorbonaci You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam patch-1

[GitHub] incubator-beam pull request #1266: [BEAM-551] Add better toString methods fo...

2016-11-02 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1266 [BEAM-551] Add better toString methods for VPs R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator

[GitHub] incubator-beam pull request #1249: [BEAM-551] Add --templateRunner option to...

2016-11-01 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1249 [BEAM-551] Add --templateRunner option to Dataflow This provides the DataflowRunner with a means of creating templates for use with ValueProvider. R: @dhalperi You can merge

[GitHub] incubator-beam pull request #1238: (Do not submit) Initial BigqueryIO work f...

2016-10-31 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1238 (Do not submit) Initial BigqueryIO work for ValueProvider R: @dhalperi This is the serialization issue I was referencing, where I think the issue is that there is a deferred

[GitHub] incubator-beam pull request #1230: POC for using NestedValueProvider with Pu...

2016-10-30 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1230 POC for using NestedValueProvider with PubsubIO Based on https://github.com/apache/incubator-beam/pull/1146. Demonstrating the utility of NVP in the context of PubsubIO. If this looks

[GitHub] incubator-beam pull request #1229: Add a template for PubSub -> BigQuery

2016-10-29 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1229 Add a template for PubSub -> BigQuery Create a simple proof-of-concept template for BigQuery streaming. Once PubsubIO uses ValueProvider, this should be a one-line change to fu

[GitHub] incubator-beam pull request #1134: [BEAM-551] Allow TextIO to accept ValuePr...

2016-10-27 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/1134 [BEAM-551] Allow TextIO to accept ValueProvider Thinking about testing, is it worth having something sub-integration-test level? We'd likely want to add some convenience metho

[GitHub] incubator-beam pull request #1134: [BEAM-551] Allow TextIO to accept ValuePr...

2016-10-27 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/1134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1163: Add experimental ServiceAccount option to...

2016-10-22 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1163 Add experimental ServiceAccount option to Dataflow runner R: @davorbonaci You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-beam pull request #1156: [BEAM-551] Add method to output runtime o...

2016-10-21 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1156 [BEAM-551] Add method to output runtime options Add a method that outputs the dynamic options from PipelineOptions, so an interested consumer could write these to a metadata storage

[GitHub] incubator-beam pull request #1146: [BEAM-551] Add NestedValueProvider

2016-10-20 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1146 [BEAM-551] Add NestedValueProvider Wrote this up based on some nascent thoughts, and looking ahead to PubsubIO, which uses a bunch of wrapper classes instead of String. This allows us

[GitHub] incubator-beam pull request #1134: [BEAM-551] Allow TextIO to accept ValuePr...

2016-10-19 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1134 [BEAM-551] Allow TextIO to accept ValueProvider Thinking about testing, is it worth having something sub-integration-test level? We'd likely want to add some convenience methods t

[GitHub] incubator-beam pull request #1107: [BEAM-551] Add property name to RuntimeVa...

2016-10-14 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1107 [BEAM-551] Add property name to RuntimeValueProvider The intention here is to allow Native IO to perform the same substitution that would otherwise take place at job execution time

[GitHub] incubator-beam pull request #1105: [BEAM-551] Add utility to handle JSON opt...

2016-10-14 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1105 [BEAM-551] Add utility to handle JSON option manipulation Provide a utility to be used with RuntimeValueProviders that allows runners to manipulate PipelineOptions by interleaving

[GitHub] incubator-beam pull request #1041: Add a default bucket to Dataflow runner

2016-10-04 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1041 Add a default bucket to Dataflow runner There is a dependency failure that I'm not sure how to debug; all other tests pass. @tgroh could you please take a

[GitHub] incubator-beam pull request #1014: Add initial scaffolding for default bucke...

2016-09-26 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1014 Add initial scaffolding for default bucket (take 2) @tgroh, could you please take a look? - Provide a hook for determining the project number associated with a bucket

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

2016-09-26 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/988 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #1009: [BEAM-551] Add ValueProvider class (Take ...

2016-09-26 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1009 [BEAM-551] Add ValueProvider class (Take 2) My branch had become a dumpster fire, so I'm opening a fresh PR (history is here: https://github.com/apache/incubator-beam/pul

[GitHub] incubator-beam pull request #827: [BEAM-551] Add ValueProvider class

2016-09-26 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

2016-09-24 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/988 Add initial scaffolding for default bucket @tgroh, could you please take a look? Before reviewing further, I was hoping to get clarity on whether the travis failures I&#

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

2016-09-24 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/988 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #852: Correctly type collections in PipelineOpti...

2016-09-23 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/852 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request #852: Correctly type collections in PipelineOpti...

2016-09-23 Thread sammcveety
GitHub user sammcveety reopened a pull request: https://github.com/apache/incubator-beam/pull/852 Correctly type collections in PipelineOptions. @bjchambers @lukecwik I would expect this to work, but the cast to ParameterizedType fails. Luke, were you suggesting something else

[GitHub] incubator-beam pull request #988: Add initial scaffolding for default bucket

2016-09-22 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/988 Add initial scaffolding for default bucket @tgroh, could you please take a look? Before reviewing further, I was hoping to get clarity on whether the travis failures I'm s

[GitHub] incubator-beam pull request #852: Correctly type collections in PipelineOpti...

2016-08-18 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/852 Correctly type collections in PipelineOptions. @bjchambers @lukecwik I would expect this to work, but the cast to ParameterizedType fails. Luke, were you suggesting something else? You

[GitHub] incubator-beam pull request #850: Incorporate Private IP change to Beam

2016-08-18 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/850 Incorporate Private IP change to Beam @dhalperi , please take a look --- You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-beam pull request #827: [BEAM-551] Add ValueProvider class

2016-08-15 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/827 [BEAM-551] Add ValueProvider class Hi @lukecwik , can you please take a look? Currently implemented for ValueProvider only. Tests demonstrate intended functionality, once the

[GitHub] incubator-beam pull request #824: Sgmc/valueprovider

2016-08-13 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/824 Sgmc/valueprovider Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like

[GitHub] incubator-beam pull request #824: Sgmc/valueprovider

2016-08-13 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/824 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request: Add wildcard to checkstyle ordering

2016-05-05 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/292 Add wildcard to checkstyle ordering Add wildcard to checkstyle, to handle unexpected package prefixes. These should still be ordered before the sun and java packages. You can merge

[GitHub] incubator-beam pull request: Update subnetwork comment to specify ...

2016-04-06 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/137 Update subnetwork comment to specify region instead of zone R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety

[GitHub] incubator-beam pull request: Update AutoComplete.java

2016-03-22 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/67 Update AutoComplete.java Allow for the Datastore dependency of this test to be in a different project than the main project for the job. R: @dhalperi You can merge this pull

[GitHub] incubator-beam pull request: Update my branch

2016-03-22 Thread sammcveety
Github user sammcveety closed the pull request at: https://github.com/apache/incubator-beam/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-beam pull request: Update my branch

2016-03-22 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/66 Update my branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam master Alternatively you can review and

[GitHub] incubator-beam pull request: [BEAM-93] Add subnetwork support and ...

2016-03-03 Thread sammcveety
GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/16 [BEAM-93] Add subnetwork support and increment Dataflow API dependency Add subnetwork to the Dataflow runner through a new option. This support was added in the newest API release, so