Re: [Apache Bloodhound] #522: Implement Bloodhound Relation widget on the ticket page
#522: Implement Bloodhound Relation widget on the ticket page --+--- Reporter: andrej | Owner: matevzb Type: enhancement | Status: closed Priority: major| Milestone: Release 6 Component: relations|Version: Resolution: fixed| Keywords: --+--- Comment (by rjollos): Should the relations widget template (`widget_relations.html`) reside in `bloodhound_dashboard/bhdashboard/widgets/templates`? I would have guessed the location for it to be `bloodhound_relations/bhrelations/widgets/templates` or `bloodhound_relations/bhrelations/templates` since the corresponding Python source code is in `bloodhound_relations/bhrelations/widgets/relations.py`. It seems odd to have the template and Python source in different packages. I seem to remember this being discussed on the mailing list, but I can't find any related discussion. Not a big deal, just happened to notice this while working on #582, so I thought I'd ask. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/522#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #519: trac-admin deploy command fails
#519: trac-admin deploy command fails
+---
Reporter: gjm| Owner: gjm
Type: defect | Status: closed
Priority: blocker| Milestone: Release 6
Component: relations |Version:
Resolution: fixed | Keywords:
+---
Comment (by rjollos):
Since the //bloodhound_relations// plugin doesn't have an `htdocs`
directory, I think it would be more correct to just return an empty list:
{{{#!python
def get_htdocs_dirs(self):
return []
}}}
This is fairly common for plugins that provide templates but not static
resources (for example, [http://trac-
hacks.org/browser/finegrainedpageauthzeditorplugin/0.11/page_authz_policy_editor/pape_admin.py?version=7144marks=44-45#L40
FineGrainedPageAuthzEditorPlugin]).
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/519#comment:3
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #523: Implement Bloodhound Relation management page
#523: Implement Bloodhound Relation management page --+--- Reporter: andrej | Owner: matevzb Type: enhancement | Status: closed Priority: major| Milestone: Release 6 Component: relations|Version: Resolution: fixed| Keywords: --+--- Comment (by rjollos): Trac requires that each template have a unique name, so I would suggest the following change in order to make Bloodhound less likely to collide with another plugin: `manage.html` - `manage_ticket_relations.html`. I'll go ahead and make this change if there are no objections. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/523#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
svn commit: r1502757 - /bloodhound/trunk/bloodhound_relations/setup.py
Author: rjollos
Date: Sat Jul 13 07:06:34 2013
New Revision: 1502757
URL: http://svn.apache.org/r1502757
Log:
Package `bhrelations.widgets` was not specified in `setup.py`. Fixes #582.
The `TicketRelationsWidget` component was being displayed separate from the
`BloodhoundRelationsPlugin` package because it was not being included in the
egg and was being discovered as a single file plugin by
`trac.loader.get_plugin_info`.
Modified:
bloodhound/trunk/bloodhound_relations/setup.py
Modified: bloodhound/trunk/bloodhound_relations/setup.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/setup.py?rev=1502757r1=1502756r2=1502757view=diff
==
--- bloodhound/trunk/bloodhound_relations/setup.py (original)
+++ bloodhound/trunk/bloodhound_relations/setup.py Sat Jul 13 07:06:34 2013
@@ -98,6 +98,8 @@ PKG_INFO = {'bhrelations': ('bhrelations
'htdocs/img/*.*', 'htdocs/js/*.js',
'templates/*', 'default-pages/*'],
),
+'bhrelations.widgets': (
+'bhrelations/widgets', ['templates/*.html']),
'bhrelations.tests': (
'bhrelations/tests', ['data/*.*']),
}
Re: [Apache Bloodhound] #588: Integrate duplicate relations to ticket workflow
#588: Integrate duplicate relations to ticket workflow --+--- Reporter: astaric | Owner: astaric Type: enhancement | Status: accepted Priority: major| Milestone: Release 7 Component: relations|Version: Resolution: | Keywords: --+--- Comment (by rjollos): Replying to [comment:5 astaric]: If you think that checking the path_info is a better idea than checking for presence of keys in data dict, commit your change as well. I don't have a solid argument for making the change at the moment, so I'll leave it as is. I just mentioned, because checking the `path_info` looks more familiar to me from all of the plugins I've worked with. One possible advantage is that you'll send less time in `post_process_request` when loading the `/newticket` page, but I can't say that is significant. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/588#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] BloodhoundReleaseNotes modified
Page BloodhoundReleaseNotes was changed by rjollos Diff URL: https://issues.apache.org/bloodhound/wiki/BloodhoundReleaseNotes?action=diffversion=2 Revision 2 Comment: Improved formatting of links. Changes: ---8--8--8--8--8--8--8--8 Index: BloodhoundReleaseNotes = --- BloodhoundReleaseNotes (version: 1) +++ BloodhoundReleaseNotes (version: 2) @@ -6,7 +6,7 @@ * Added support for ticket relations. * Numerous improvements to the BloodhoundSearch module. * Redesigned the Ticket page. - * Implemented Bootstrap templates for Timeline and AccountManagerPlugin. + * Implemented Bootstrap templates for Timeline and [th:AccountManagerPlugin]. * Not fixed for this release: * No major outstanding issues @@ -37,7 +37,7 @@ == 0.5 - * Added beta version of bhsearch plugin. Find more information on https://issues.apache.org/bloodhound/wiki/BloodhoundSearch + * Added beta version of bhsearch plugin. Find more information on BloodhoundSearch. * Implemented Bootstrap templates for the repository browser, log viewer and attachment pages. * Added responsive layout support for better experience on tablets and phones * Upgraded Bootstrap to version 2.3.1. ---8--8--8--8--8--8--8--8 -- Page URL: https://issues.apache.org/bloodhound/wiki/BloodhoundReleaseNotes Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker This is an automated message. Someone added your email address to be notified of changes on 'BloodhoundReleaseNotes' page. If it was not you, please report to .
Re: [Apache Bloodhound] #561: Display more user-friendly error page when navigating to a non-existing product
#561: Display more user-friendly error page when navigating to a non-existing product ---+--- Reporter: rjollos | Owner: rjollos Type: enhancement | Status: closed Priority: major | Milestone: Release 6 Component: multiproduct |Version: Resolution: fixed | Keywords: hooks ---+--- Comment (by rjollos): Please review, as I'm not overly confident with the changes. More changes are needed to resolve the //RequestDone// error. (In [1502769]) Modify test case now that //Product List// page is displayed when navigating to a non-existing product after [1495037]. Refs #561. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/561#comment:19 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
svn commit: r1502769 - /bloodhound/trunk/bloodhound_multiproduct/tests/web_ui.py
Author: rjollos
Date: Sat Jul 13 10:23:16 2013
New Revision: 1502769
URL: http://svn.apache.org/r1502769
Log:
Modify test case now that //Product List// page is displayed when navigating to
a non-existing product after [1495037]. Refs #561.
Modified:
bloodhound/trunk/bloodhound_multiproduct/tests/web_ui.py
Modified: bloodhound/trunk/bloodhound_multiproduct/tests/web_ui.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/tests/web_ui.py?rev=1502769r1=1502768r2=1502769view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/tests/web_ui.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/tests/web_ui.py Sat Jul 13
10:23:16 2013
@@ -216,13 +216,6 @@ class ProductModuleTestCase(RequestHandl
spy = self.global_env[TestRequestSpy]
self.assertIsNot(None, spy)
-# Missing product
-req = self._get_request_obj(self.global_env)
-req.authname = 'testuser'
-req.environ['PATH_INFO'] = '/products/missing'
-
-real_prefix = None
-
def assert_product_view(req, template, data, content_type):
self.assertEquals('product_view.html', template)
self.assertIs(None, content_type)
@@ -238,11 +231,6 @@ class ProductModuleTestCase(RequestHandl
spy.testProcessing = assert_product_view
-self.expectedPrefix = 'missing'
-self.expectedPathInfo = ''
-with self.assertRaises(RequestDone):
-self._dispatch(req, self.global_env)
-
# Existing product
req = self._get_request_obj(self.global_env)
req.authname = 'testuser'
@@ -254,6 +242,33 @@ class ProductModuleTestCase(RequestHandl
with self.assertRaises(RequestDone):
self._dispatch(req, self.global_env)
+def test_missing_product(self):
+spy = self.global_env[TestRequestSpy]
+self.assertIsNot(None, spy)
+
+mps = MultiProductSystem(self.global_env)
+def assert_product_list(req, template, data, content_type):
+self.assertEquals('product_list.html', template)
+self.assertIs(None, content_type)
+self.assertEquals([mps.default_product_prefix,
+ self.default_product],
+ [p.prefix for p in data.get('products')])
+self.assertTrue('context' in data)
+ctx = data['context']
+self.assertEquals('product', ctx.resource.realm)
+self.assertEquals(None, ctx.resource.id)
+
+spy.testProcessing = assert_product_list
+
+# Missing product
+req = self._get_request_obj(self.global_env)
+req.authname = 'testuser'
+req.environ['PATH_INFO'] = '/products/missing'
+
+self.expectedPrefix = 'missing'
+self.expectedPathInfo = ''
+with self.assertRaises(RequestDone):
+self._dispatch(req, self.global_env)
def test_product_edit(self):
spy = self.global_env[TestRequestSpy]
Re: [Apache Bloodhound] #552: Inaccurate URLs in global dashboard
#552: Inaccurate URLs in global dashboard -+- Reporter: olemis | Owner: rjollos Type: defect | Status: review Priority: major | Milestone: Release 7 Component: dashboard |Version: Resolution: | Keywords: custom bootstrap handlers, product | widget -+- Changes (by rjollos): * owner: olemis = rjollos * status: accepted = review -- Ticket URL: https://issues.apache.org/bloodhound/ticket/552#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #566: Product widgets in global dashboard: odd alignment
#566: Product widgets in global dashboard: odd alignment +--- Reporter: olemis | Owner: rjollos Type: defect | Status: closed Priority: major | Milestone: Release 7 Component: dashboard |Version: Resolution: fixed | Keywords: global dashboard, product widgets +--- Comment (by rjollos): Replying to [comment:5 rjollos]: I've been able to reproduce the following issue: when an odd number of products exists, the last product in the list can be shifted into the right column when it should be in the left column. The patch you provided resolves the issue for this case. I see now from http://blood-hound.net/dashboard, that the issue isn't restricted to the last product widget in the list: Here is a screen capture with a small zoom value: [[Image(BloodhoundDotNetDashBoard.png)]] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/566#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] New user registration: Green_Hell
New user registration for user Green_Hell -- Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
