[Apache Bloodhound] #693: Main nav item not highlighted
#693: Main nav item not highlighted -+--- Reporter: olemis |Owner: Type: defect | Status: new Priority: major | Version: Resolution: | -+--- The code in trunk fails in highlighting active main nav item . I've tracked this down to r1522789 (= that's an initial estimation, might not be accurate). PS: I detected this by running the [ticket:387 functional test suite] . It happens that there is more code implementing behaviors depending upon the availability and status of main nav items. In particular ''Reports'' links in dashboard disappears thus leading to failures in the functional test suite. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/693 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #693: Main nav item not highlighted
#693: Main nav item not highlighted +--- Reporter: olemis | Owner: nobody Type: defect | Status: new Priority: blocker| Milestone: Release 8 Component: ui design |Version: Resolution: | Keywords: mainnav +--- Changes (by olemis): * component: = ui design * priority: major = blocker * owner: = nobody * milestone: = Release 8 * keywords: = mainnav Old description: The code in trunk fails in highlighting active main nav item . I've tracked this down to r1522789 (= that's an initial estimation, might not be accurate). PS: I detected this by running the [ticket:387 functional test suite] . It happens that there is more code implementing behaviors depending upon the availability and status of main nav items. In particular ''Reports'' links in dashboard disappears thus leading to failures in the functional test suite. New description: The code in trunk (0.8-dev) fails in highlighting active main nav item . I've tracked this down to r1522789 (= that's an initial estimation, might not be accurate). PS: I detected this by running the [ticket:387 functional test suite] . It happens that there is more code implementing behaviors depending upon the availability and status of main nav items. In particular ''Reports'' links in dashboard disappears thus leading to failures in the functional test suite. -- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/693#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #693: Main nav item not highlighted
#693: Main nav item not highlighted +--- Reporter: olemis | Owner: olemis Type: defect | Status: accepted Priority: blocker| Milestone: Release 8 Component: ui design |Version: Resolution: | Keywords: mainnav +--- Changes (by olemis): * owner: nobody = olemis * status: new = accepted -- Ticket URL: https://issues.apache.org/bloodhound/ticket/693#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] #694: Translations scaffolding
#694: Translations scaffolding -+- Reporter: olemis |Owner: Type: task| Status: new Priority: major | Version: 0.7.0 Resolution: | -+- Prepare Bloodhound source code for translations . See - [https://www.transifex.com/projects/p/bloodhound/ Transifex project] - E-mail message with guidelines ^citation needed^ (= no link in archive ?) -- Ticket URL: https://issues.apache.org/bloodhound/ticket/694 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #694: Translations scaffolding
#694: Translations scaffolding + Reporter: olemis | Owner: nobody Type: task | Status: new Priority: minor | Milestone: Component: trac core |Version: 0.7.0 Resolution: | Keywords: i18n + Changes (by olemis): * owner: = nobody * keywords: = i18n * component: = trac core * priority: major = minor Old description: Prepare Bloodhound source code for translations . See - [https://www.transifex.com/projects/p/bloodhound/ Transifex project] - E-mail message with guidelines ^citation needed^ (= no link in archive ?) New description: Prepare Bloodhound source code for translations . See - [https://www.transifex.com/projects/p/bloodhound/ Transifex project] - E-mail message with guidelines ^citation needed^ (= no link in archive ... yet ?) -- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/694#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #694: Translations scaffolding
#694: Translations scaffolding + Reporter: olemis | Owner: nobody Type: task | Status: new Priority: minor | Milestone: Component: trac core |Version: 0.7.0 Resolution: | Keywords: i18n + Description changed by olemis: Old description: Prepare Bloodhound source code for translations . See - [https://www.transifex.com/projects/p/bloodhound/ Transifex project] - E-mail message with guidelines ^citation needed^ (= no link in archive ... yet ?) New description: Prepare Bloodhound source code for translations . See - [https://www.transifex.com/projects/p/bloodhound/ Transifex project] - [http://goo.gl/gj3qB7 E-mail message] with guidelines -- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/694#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #693: Main nav item not highlighted
#693: Main nav item not highlighted +--- Reporter: olemis | Owner: Type: defect | Status: review Priority: blocker| Milestone: Release 8 Component: ui design |Version: Resolution: | Keywords: mainnav +--- Changes (by olemis): * owner: olemis = * status: accepted = review Comment: Attached patch will fix this issue . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/693#comment:3 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] New user registration: bsmithers
New user registration for user bsmithers -- Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] #695: Add support for the CommitTicketUpdater component
#695: Add support for the CommitTicketUpdater component --+ Reporter: bsmithers | Owner: nobody Type: enhancement | Status: new Priority: major | Milestone: Component: multiproduct |Version: Keywords:| --+ The [http://trac.edgewall.org/wiki/CommitTicketUpdater Commit Ticket Updater] is an optional component that allows commit messages to reference tickets, adding comments to them and (potentially) changing their state. This isn't 'product aware', so currently does not work with Bloodhound (tested with version 0.7). Tickets are referred to by number (e.g. see/closes/fixes !#123); some thought will be needed if ticket numbers will be re-used across different products in the future. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/695 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component
#695: Add support for the CommitTicketUpdater component --+--- Reporter: bsmithers| Owner: olemis Type: enhancement | Status: accepted Priority: major| Milestone: Component: trac core|Version: 0.7.0 Resolution: | Keywords: vcs hooks --+--- Changes (by olemis): * owner: nobody = olemis * keywords: vcs = vcs hooks * status: new = accepted -- Ticket URL: https://issues.apache.org/bloodhound/ticket/695#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component
#695: Add support for the CommitTicketUpdater component --+ Reporter: bsmithers| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Component: trac core|Version: 0.7.0 Resolution: | Keywords: vcs --+ Changes (by olemis): * keywords: = vcs * version: = 0.7.0 * component: multiproduct = trac core Comment: I've updated ticket component because technically this class belongs in our patched copy of Trac -- Ticket URL: https://issues.apache.org/bloodhound/ticket/695#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
svn commit: r1532641 - /bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Author: rjollos
Date: Wed Oct 16 05:17:11 2013
New Revision: 1532641
URL: http://svn.apache.org/r1532641
Log:
0.8dev: Fixed regression in r1522789 which resulted in active mainnav item not
being highlighted. Refs #693.
`req.chrome` should be manipulated in `post_process_request` rather than
`pre_process_request` since it is assigned a dictionary in
`trac.web.chrome:Chrome.prepare_request`.
Patch by Olemis Lang.
Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
Modified: bloodhound/trunk/bloodhound_theme/bhtheme/theme.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/theme.py?rev=1532641r1=1532640r2=1532641view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/theme.py (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/theme.py Wed Oct 16 05:17:11 2013
@@ -252,12 +252,6 @@ class BloodhoundTheme(ThemeBase):
req.href.wiki = hwiki
-# Move 'admin' entry from mainnav to metanav
-for i, entry in enumerate(req.chrome['nav'].get('mainnav', [])):
-if entry['name'] == 'admin':
-req.chrome['nav'].setdefault('metanav', []) \
-.append(req.chrome['nav']['mainnav'].pop(i))
-
return handler
def post_process_request(self, req, template, data, content_type):
@@ -295,6 +289,12 @@ class BloodhoundTheme(ThemeBase):
is_active_theme = is_active_theme()
if self.disable_all_trac_css and is_active_theme:
+# Move 'admin' entry from mainnav to metanav
+for i, entry in enumerate(req.chrome['nav'].get('mainnav', [])):
+if entry['name'] == 'admin':
+req.chrome['nav'].setdefault('metanav', []) \
+ .append(req.chrome['nav']['mainnav'].pop(i))
+
if self.disable_all_trac_css:
stylesheets = links.get('stylesheet', [])
if stylesheets:
Re: [Apache Bloodhound] #693: Main nav item not highlighted
#693: Main nav item not highlighted +--- Reporter: olemis | Owner: rjollos Type: defect | Status: closed Priority: blocker| Milestone: Release 8 Component: ui design |Version: Resolution: fixed | Keywords: mainnav +--- Changes (by rjollos): * status: review = closed * resolution: = fixed -- Ticket URL: https://issues.apache.org/bloodhound/ticket/693#comment:5 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #387: Rewrite Trac functional test cases against product environments - after #355
#387: Rewrite Trac functional test cases against product environments - after #355 -+- Reporter: olemis | Owner: rjollos Type: task| Status: review Priority: major | Milestone: Release 8 Component: |Version: multiproduct | Keywords: product environment functional Resolution: | testing QA -+- Comment (by olemis): The most recent patch will fix failures caused by phasing out default product redirections . [comment:29 Patch order] updated accordingly . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/387#comment:30 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #387: Rewrite Trac functional test cases against product environments - after #355
#387: Rewrite Trac functional test cases against product environments - after #355 -+- Reporter: olemis | Owner: rjollos Type: task| Status: review Priority: major | Milestone: Release 8 Component: |Version: multiproduct | Keywords: product environment functional Resolution: | testing QA -+- Comment (by olemis): [http://goo.gl/Hgochu Test results] are back to normal after this -- Ticket URL: https://issues.apache.org/bloodhound/ticket/387#comment:31 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
