[GitHub] [calcite] zabetak commented on issue #1083: [CALCITE-2889] IndexOutOfBoundsException thrown if targetTypes[] contains varargs

zabetak commented on issue #1083: [CALCITE-2889] IndexOutOfBoundsException thrown if targetTypes[] contains varargs URL: https://github.com/apache/calcite/pull/1083#issuecomment-470004925 Thanks for the explanation @amaliujia, now I see better! I suppose you can add an addtional test

[GitHub] [calcite] chunweilei edited a comment on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule

chunweilei edited a comment on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-469986630 @risdenk Actually all commits are targeted to calcite-2729 which is opened after calcite-2658. You may find the answer

[GitHub] [calcite] chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-469990006 @risdenk Done. Thank you for reviewing it.

[GitHub] [calcite] chunweilei edited a comment on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule

chunweilei edited a comment on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-469986630 @risdenk Actually all commits are targeted to calcite-2729 which is opened after calcite-2658. You may find the answer

[GitHub] [calcite] chunweilei commented on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule

chunweilei commented on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-469986630 @risdenk Actually all commits are targeted to calcite-2729 which is opened after calcite-2658.

[GitHub] [calcite] zhztheplayer closed pull request #1085: [CALCITE-2891] Alias suggester failed to suggest name based on original name incrementally

zhztheplayer closed pull request #1085: [CALCITE-2891] Alias suggester failed to suggest name based on original name incrementally URL: https://github.com/apache/calcite/pull/1085 This is an automated message from the

[calcite] branch master updated: [CALCITE-2891] Alias suggester failed to suggest name based on original name incrementally (Haisheng Yuan)

This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 92562a0 [CALCITE-2891] Alias suggester failed

[GitHub] [calcite] hsyuan opened a new pull request #1087: [CALCITE-1172] Add rule to flatten two Aggregate operators into one

hsyuan opened a new pull request #1087: [CALCITE-1172] Add rule to flatten two Aggregate operators into one URL: https://github.com/apache/calcite/pull/1087 JIRA: https://issues.apache.org/jira/browse/CALCITE-1172 This is an

[GitHub] [calcite] zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#discussion_r262737905 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#discussion_r262733436 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#discussion_r262734682 ## File path:

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

siddharthteotia commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#discussion_r262732805 ## File path:

[GitHub] [calcite] laurentgo closed pull request #710: [CALCITE-2340] Fix AvgVarianceConvertlet

laurentgo closed pull request #710: [CALCITE-2340] Fix AvgVarianceConvertlet URL: https://github.com/apache/calcite/pull/710 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] laurentgo commented on issue #710: [CALCITE-2340] Fix AvgVarianceConvertlet

laurentgo commented on issue #710: [CALCITE-2340] Fix AvgVarianceConvertlet URL: https://github.com/apache/calcite/pull/710#issuecomment-469899246 Already fixed as part of apache/calcite#779 This is an automated message from

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#issuecomment-469899116 @risdenk , @julianhyde , I have addressed the review comments. Please review the

[calcite] branch master updated: [CALCITE-2887] Improve performance of RexLiteral#toJavaString

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 6687023 [CALCITE-2887] Improve performance

[GitHub] [calcite] zabetak merged pull request #1080: [CALCITE-2887] Improve performance of RexLiteral#toJavaString

zabetak merged pull request #1080: [CALCITE-2887] Improve performance of RexLiteral#toJavaString URL: https://github.com/apache/calcite/pull/1080 This is an automated message from the Apache Git Service. To respond to the

[calcite] branch master updated: [CALCITE-2886] Simplification of AND expressions should push negations earlier

This is an automated email from the ASF dual-hosted git repository. kgyrtkirk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 36d373f [CALCITE-2886] Simplification of

[calcite] branch master updated: [CALCITE-2890] Elasticsearch adapter. any_value with other aggregation functions returns incorrect result (Siyuan Liu)

This is an automated email from the ASF dual-hosted git repository. sereda pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0876740 [CALCITE-2890] Elasticsearch adapter.

[GitHub] [calcite] asereda-gs commented on issue #1082: [CALCITE-2890] Elasticsearch adapter. combine "any_value" with other aggs failed

asereda-gs commented on issue #1082: [CALCITE-2890] Elasticsearch adapter. combine "any_value" with other aggs failed URL: https://github.com/apache/calcite/pull/1082#issuecomment-469833694 Thank you! This is an automated

[GitHub] [calcite] asereda-gs merged pull request #1082: [CALCITE-2890] Elasticsearch adapter. combine "any_value" with other aggs failed

asereda-gs merged pull request #1082: [CALCITE-2890] Elasticsearch adapter. combine "any_value" with other aggs failed URL: https://github.com/apache/calcite/pull/1082 This is an automated message from the Apache Git

[GitHub] [calcite] laurentgo commented on issue #1016: [CALCITE-2803] ProjectTransposeJoinRule messes INDF expressions

laurentgo commented on issue #1016: [CALCITE-2803] ProjectTransposeJoinRule messes INDF expressions URL: https://github.com/apache/calcite/pull/1016#issuecomment-469817477 Will do. The newer checkstyle version is more restrictive, and my IDE (Eclipse) cannot automatically format the

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

siddharthteotia commented on a change in pull request #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#discussion_r262644999 ## File path:

[GitHub] [calcite] zabetak merged pull request #884: [CALCITE-2621] Add rule to execute semi joins with correlation (Ruben Quesada Lopez)

zabetak merged pull request #884: [CALCITE-2621] Add rule to execute semi joins with correlation (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/884 This is an automated message from the Apache Git

[calcite] branch master updated: [CALCITE-2621] Add rule to execute semi joins with correlation (Ruben Quesada Lopez)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 62d933c [CALCITE-2621] Add rule to execute

[GitHub] [calcite] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-469693790 hi @michaelmior I see it.I'm working on it This is an automated

[GitHub] [calcite] michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-469681167 @XuQianJin-Stars Thanks! Could you look at the parser errors on the Travis CI tests?

[GitHub] [calcite] godfreyhe commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public

godfreyhe commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1055#issuecomment-469661075 Hi @julianhyde, do you have any suggestion about the topic in: https://issues.apache.org/jira/browse/CALCITE-2855. Looking

[GitHub] [calcite] julianhyde commented on a change in pull request #1080: [CALCITE-2887] Improve performance of RexLiteral#toJavaString

julianhyde commented on a change in pull request #1080: [CALCITE-2887] Improve performance of RexLiteral#toJavaString URL: https://github.com/apache/calcite/pull/1080#discussion_r262445493 ## File path: core/src/main/java/org/apache/calcite/rex/RexLiteral.java ## @@

[GitHub] [calcite] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-469633716 hi @zhztheplayer @michaelmior I have addressed all comments. best qianjin

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1086: [CALCITE-2892]Add the JSON_KEYS function

XuQianJin-Stars opened a new pull request #1086: [CALCITE-2892]Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086 [JSON_KEYS({{json_doc[, _{{path}}_])}}|https://dev.mysql.com/doc/refman/5.7/en/json-search-functions.html#function_json-keys] Returns the keys

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262384794 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -137,9 +134,6 @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262381412 ## File path: site/_docs/reference.md ## @@ -2005,6 +2006,7 @@ Note: | JSON_TYPE(value)

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r262382023 ## File path: core/src/test/java/org/apache/calcite/test/SqlJsonFunctionsTest.java ## @@ -55,6