[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270276154 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270267783 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270267275 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270267219 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270263293 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-28 Thread GitBox
zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-477842029 And I would like to know your thoughts on separating the changes to two commits. Something like: - Commit 1 Sit

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270263293 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270263078 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270262760 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270262645 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] XuQianJin-Stars commented on issue #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-03-28 Thread GitBox
XuQianJin-Stars commented on issue #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#issuecomment-477826322 hi @michaelmior @zhztheplayer I have updated this PR. Can you continue to review this PR? best qianjin

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

2019-03-28 Thread GitBox
siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-477824627 @zabetak , @asereda-gs , can this be merged?

[GitHub] [calcite] zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-28 Thread GitBox
zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-477816295 @julianhyde - rebased onto master. This is an automa

[GitHub] [calcite] laurentgo commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-28 Thread GitBox
laurentgo commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270226064 ## File path: core/src/main/java/org/apache/calci

[GitHub] [calcite] hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-03-28 Thread GitBox
hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096#issuecomment-45244 @julianhyde Rebased on master and tests passed.

[GitHub] [calcite] hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-03-28 Thread GitBox
hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096#issuecomment-477752514 OK, will do This is an automated message fr

[GitHub] [calcite] julianhyde commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-03-28 Thread GitBox
julianhyde commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096#issuecomment-477752255 @hsyuan 2903 is fixed now. Can you rebase, if necessary? I'll review when the tests pass. -

[GitHub] [calcite] hsyuan merged pull request #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

2019-03-28 Thread GitBox
hsyuan merged pull request #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921 This is an automated message from the Apache Git Service. To respond to

[calcite] branch master updated: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes constant keys from Exchange or SortExchange (Chunwei Lei)

2019-03-28 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0537f27 [CALCITE-2658] Add ExchangeRemoveConsta

[GitHub] [calcite] julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-28 Thread GitBox
julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-477714731 Can you please rebase this? Then I will review. This i

[calcite] branch master updated: Oops!

2019-03-28 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new a619cae Oops! a619cae is described below commi

[GitHub] [calcite] rubenada commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-28 Thread GitBox
rubenada commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270086239 ## File path: core/src/main/java/org/apache/calci

[GitHub] [calcite] pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] pengzhiwei2018 closed pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 closed pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] hsyuan commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-28 Thread GitBox
hsyuan commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270069500 ## File path: core/src/main/java/org/apache/calcite/rel/r

[GitHub] [calcite-avatica] risdenk merged pull request #40: [CALCITE-2269] Enable errorprone checking

2019-03-28 Thread GitBox
risdenk merged pull request #40: [CALCITE-2269] Enable errorprone checking URL: https://github.com/apache/calcite-avatica/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log

[calcite-avatica] branch master updated: [CALCITE-2269] Enable Error Prone checking

2019-03-28 Thread krisden
This is an automated email from the ASF dual-hosted git repository. krisden pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new 1b68d1f [CALCITE-2269] Enable Error P