[GitHub] [calcite] chunweilei opened a new pull request #1162: [CALCITE-2343] PushProjector with OVER expression causes infinite loop (Chunwei Lei)

2019-04-13 Thread GitBox
chunweilei opened a new pull request #1162: [CALCITE-2343] PushProjector with OVER expression causes infinite loop (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1162 JIRA: https://issues.apache.org/jira/browse/CALCITE-2343.

[GitHub] [calcite] zabetak commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n…

2019-04-13 Thread GitBox
zabetak commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n… URL: https://github.com/apache/calcite/pull/1152#discussion_r275135844 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #713: [CALCITE-2343] Fix infinite loop caused by PushProjector

2019-04-13 Thread GitBox
chunweilei commented on a change in pull request #713: [CALCITE-2343] Fix infinite loop caused by PushProjector URL: https://github.com/apache/calcite/pull/713#discussion_r275123537 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@

[GitHub] [calcite] chunweilei commented on a change in pull request #713: [CALCITE-2343] Fix infinite loop caused by PushProjector

2019-04-13 Thread GitBox
chunweilei commented on a change in pull request #713: [CALCITE-2343] Fix infinite loop caused by PushProjector URL: https://github.com/apache/calcite/pull/713#discussion_r275123537 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@

[GitHub] [calcite] zhztheplayer commented on issue #1014: [CALCITE-2804] Druid adapter: Cast does not work when casting to timestamp

2019-04-13 Thread GitBox
zhztheplayer commented on issue #1014: [CALCITE-2804] Druid adapter: Cast does not work when casting to timestamp URL: https://github.com/apache/calcite/pull/1014#issuecomment-482814744 And I see the Calcite connection property `nullEqualToEmpty` is no longer in use in the PR. The

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1014: [CALCITE-2804] Druid adapter: Cast does not work when casting to timestamp

2019-04-13 Thread GitBox
zhztheplayer commented on a change in pull request #1014: [CALCITE-2804] Druid adapter: Cast does not work when casting to timestamp URL: https://github.com/apache/calcite/pull/1014#discussion_r275119933 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1149: [CALCITE-2982] SqlItemOperator should throw understandable exception …

2019-04-13 Thread GitBox
chunweilei commented on a change in pull request #1149: [CALCITE-2982] SqlItemOperator should throw understandable exception … URL: https://github.com/apache/calcite/pull/1149#discussion_r275119391 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1149: [CALCITE-2982] SqlItemOperator should throw understandable exception …

2019-04-13 Thread GitBox
chunweilei commented on a change in pull request #1149: [CALCITE-2982] SqlItemOperator should throw understandable exception … URL: https://github.com/apache/calcite/pull/1149#discussion_r275119143 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior

2019-04-13 Thread GitBox
zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior URL: https://github.com/apache/calcite/pull/1107#discussion_r275116466 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ##

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior

2019-04-13 Thread GitBox
zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior URL: https://github.com/apache/calcite/pull/1107#discussion_r275116466 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ##

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior

2019-04-13 Thread GitBox
zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior URL: https://github.com/apache/calcite/pull/1107#discussion_r275116466 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ##