[GitHub] [calcite] danny0405 commented on a change in pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::'

danny0405 commented on a change in pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::' URL: https://github.com/apache/calcite/pull/1066#discussion_r291792271 ## File path: babel/src/main/codegen/config.fmpp ## @@ -857,6 +858,16

[GitHub] [calcite] danny0405 commented on a change in pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::'

danny0405 commented on a change in pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::' URL: https://github.com/apache/calcite/pull/1066#discussion_r291792175 ## File path:

[GitHub] [calcite] MGelbana commented on issue #1242: [CALCITE-3063] Parse and process PostgreSQL posix regular expressions

MGelbana commented on issue #1242: [CALCITE-3063] Parse and process PostgreSQL posix regular expressions URL: https://github.com/apache/calcite/pull/1242#issuecomment-500068769 Thank you for your time. Done. This is an

[calcite] branch master updated: Following [CALCITE-2822] simplify test and related classes/rules

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 941cd4e Following [CALCITE-2822] simplify

[GitHub] [calcite] asfgit closed pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

asfgit closed pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030 This is an automated message from the Apache Git Service. To respond to the

[calcite] branch master updated: [CALCITE-2822] Allow MultiJoin rules with any project/filter (Siddharth Teotia)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0cb51c6 [CALCITE-2822] Allow MultiJoin rules

[GitHub] [calcite] zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

zabetak commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-500043286 I will have a look right now, thanks for the reminder!

[GitHub] [calcite] hsyuan commented on issue #1258: [CALCITE-3088] Multi-groupsets query failed due to data type preservation check

hsyuan commented on issue #1258: [CALCITE-3088] Multi-groupsets query failed due to data type preservation check URL: https://github.com/apache/calcite/pull/1258#issuecomment-500043052 I will find time to take a look. This

[GitHub] [calcite] hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering URL: https://github.com/apache/calcite/pull/1252#discussion_r291757336 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering URL: https://github.com/apache/calcite/pull/1252#discussion_r291756428 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering URL: https://github.com/apache/calcite/pull/1252#discussion_r291756546 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

hsyuan commented on a change in pull request #1252: [CALCITE-3087] AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering URL: https://github.com/apache/calcite/pull/1252#discussion_r291756796 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

rubenada commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r291690818 ## File path:

[GitHub] [calcite] walterddr commented on issue #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

walterddr commented on issue #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011#issuecomment-499966495 @zhztheplayer I already have an experiment on CALCITE-2906 and seems like the concern is less obvious after I rebased with

[GitHub] [calcite] laurentgo commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

laurentgo commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-499961254 @zabetak I think your comments have been addressed. FYI I plan to merge @siddharthteotia change today.

[GitHub] [calcite] laurentgo commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

laurentgo commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r291675197 ## File path:

[GitHub] [calcite] julianhyde commented on issue #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

julianhyde commented on issue #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#issuecomment-499957887 These commits don't clearly state the problem that is being fixed.

[GitHub] [calcite] rubenada opened a new pull request #1261: [CALCITE-3119] Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

rubenada opened a new pull request #1261: [CALCITE-3119] Deprecate Linq4j CorrelateJoinType (in favor of JoinType) URL: https://github.com/apache/calcite/pull/1261 Jira ticket: [CALCITE-3119](https://issues.apache.org/jira/browse/CALCITE-3119)

[GitHub] [calcite] julianhyde commented on issue #1246: [CALCITE-2968] New AntiJoin relational expression

julianhyde commented on issue #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#issuecomment-499952504 +1 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] rubenada commented on issue #1246: [CALCITE-2968] New AntiJoin relational expression

rubenada commented on issue #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#issuecomment-499923772 Thanks for handling this @michaelmior ! @zabetak @danny0405 @julianhyde Regarding the open discussion about deprecating Linq4j

[GitHub] [calcite] michaelmior commented on issue #1242: [CALCITE-3063] Parse and process PostgreSQL posix regular expressions

michaelmior commented on issue #1242: [CALCITE-3063] Parse and process PostgreSQL posix regular expressions URL: https://github.com/apache/calcite/pull/1242#issuecomment-499920449 There's a typo in `includePosixOpertaors` that should be corrected.

[GitHub] [calcite] michaelmior closed pull request #1246: [CALCITE-2968] New AntiJoin relational expression

michaelmior closed pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] michaelmior closed pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION

michaelmior closed pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION URL: https://github.com/apache/calcite/pull/1011 This is an automated message from the Apache Git Service. To respond to the

[calcite] branch master updated: [CALCITE-2721] Support parsing record-type [DOT] member-functions

This is an automated email from the ASF dual-hosted git repository. mmior pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 4513a72 [CALCITE-2721] Support parsing

[GitHub] [calcite] hbtoo commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

hbtoo commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#discussion_r291593237 ## File path: core/src/test/java/org/apache/calcite/plan/volcano/VolcanoPlannerTest.java

[GitHub] [calcite] hbtoo commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check

hbtoo commented on a change in pull request #1260: [CALCITE-3118] fix VolcanoRuleCall match parent child ordinal check URL: https://github.com/apache/calcite/pull/1260#discussion_r291593237 ## File path: core/src/test/java/org/apache/calcite/plan/volcano/VolcanoPlannerTest.java

[GitHub] [calcite] rubenada commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

rubenada commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r291479019 ## File path:

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r291477478 ## File path: core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java