[GitHub] [calcite] jinxing64 opened a new pull request #1394: [CALCITE-3274] Add FilterOnProjectToFilterUnifyRule for materialization matching

jinxing64 opened a new pull request #1394: [CALCITE-3274] Add FilterOnProjectToFilterUnifyRule for materialization matching URL: https://github.com/apache/calcite/pull/1394 With current implementation of MV matching, below case fails ``` @Test public void testFilterOnProject() {

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r315989244 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6 +4197,113

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r315988753 ## File path: core/src/main/java/org/apache/calcite/sql/type/CompositeOperandTypeChecker.java ## @@ -311,6

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r315987964 ## File path: core/src/main/java/org/apache/calcite/jdbc/CalciteConnectionImpl.java ## @@ -471,9 +471,9 @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r315985210 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -888,6 +888,18 @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r315984639 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6

[GitHub] [calcite] weidong3630 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null

weidong3630 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null URL: https://github.com/apache/calcite/pull/1338#discussion_r315983111 ## File path:

[GitHub] [calcite] weidong3630 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null

weidong3630 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null URL: https://github.com/apache/calcite/pull/1338#discussion_r315983038 ## File path:

[GitHub] [calcite] weidong3630 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null

weidong3630 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null URL: https://github.com/apache/calcite/pull/1338#discussion_r315983038 ## File path:

[GitHub] [calcite] LiShuMing commented on a change in pull request #1390: [CALCITE-3263] Add MD5/SHA1 SQL functions

LiShuMing commented on a change in pull request #1390: [CALCITE-3263] Add MD5/SHA1 SQL functions URL: https://github.com/apache/calcite/pull/1390#discussion_r315978913 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -172,6 +173,34 @@

[GitHub] [calcite] DonnyZone commented on issue #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

DonnyZone commented on issue #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#issuecomment-523269844 Thanks @zabetak! I will make every effort to cooperate with reviewers. Since I'm free in recent weekends, I'd like to

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r315973103 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6 +4197,113

[GitHub] [calcite] jinxing64 commented on issue #1388: [CALCITE-3262] Refine doc of SubstitutionVisitor.java

jinxing64 commented on issue #1388: [CALCITE-3262] Refine doc of SubstitutionVisitor.java URL: https://github.com/apache/calcite/pull/1388#issuecomment-523264813 @hsyuan Thanks a lot for approve ! This is an automated

[GitHub] [calcite] yanlin-Lynn commented on issue #1386: [CALCITE-3259] Align 'Property' in the serialized xml string of RelXmlWriter.

yanlin-Lynn commented on issue #1386: [CALCITE-3259] Align 'Property' in the serialized xml string of RelXmlWriter. URL: https://github.com/apache/calcite/pull/1386#issuecomment-523264074 Thanks for reviewing. @hsyuan This

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1393: [CALCITE-3265] Remove the unused variables

xy2953396112 commented on a change in pull request #1393: [CALCITE-3265] Remove the unused variables URL: https://github.com/apache/calcite/pull/1393#discussion_r315971585 ## File path: core/src/main/java/org/apache/calcite/runtime/Matcher.java ## @@ -63,7 +58,6 @@

[calcite] branch master updated: [CALCITE-3251] BinaryExpression evaluate method support full numeric types in Primitive (xy2953396112)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 5a42812 [CALCITE-3251] BinaryExpression

[GitHub] [calcite] danny0405 closed pull request #1379: [CALCITE-3251] BinaryExpression evaluate method support full numeric types in Primitive

danny0405 closed pull request #1379: [CALCITE-3251] BinaryExpression evaluate method support full numeric types in Primitive URL: https://github.com/apache/calcite/pull/1379 This is an automated message from the Apache Git

[GitHub] [calcite] xy2953396112 commented on issue #1389: [CALCITE-3265] remove useless code

xy2953396112 commented on issue #1389: [CALCITE-3265] remove useless code URL: https://github.com/apache/calcite/pull/1389#issuecomment-523247230 @danny0405 How do you think merge them? This is an automated message from the

[GitHub] [calcite] xy2953396112 commented on issue #1389: [CALCITE-3265] remove useless code

xy2953396112 commented on issue #1389: [CALCITE-3265] remove useless code URL: https://github.com/apache/calcite/pull/1389#issuecomment-523245806 > Thanks @xy2953396112, but this change is too small to form a PR, maybe we can merge this change into another bigger one ~ How do you

[GitHub] [calcite] xy2953396112 closed pull request #1389: [CALCITE-3265] remove useless code

xy2953396112 closed pull request #1389: [CALCITE-3265] remove useless code URL: https://github.com/apache/calcite/pull/1389 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] hsyuan merged pull request #1386: [CALCITE-3259] Align 'Property' in the serialized xml string of RelXmlWriter.

hsyuan merged pull request #1386: [CALCITE-3259] Align 'Property' in the serialized xml string of RelXmlWriter. URL: https://github.com/apache/calcite/pull/1386 This is an automated message from the Apache Git Service. To

[calcite] branch master updated (11116f6 -> beeb012)

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 6f6 [CALCITE-3111] Add RelBuilder.correlate method, and allow custom implementations of Correlate in

[GitHub] [calcite] hsyuan commented on a change in pull request #1390: [CALCITE-3263] Add MD5/SHA1 SQL functions

hsyuan commented on a change in pull request #1390: [CALCITE-3263] Add MD5/SHA1 SQL functions URL: https://github.com/apache/calcite/pull/1390#discussion_r315949211 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -172,6 +173,34 @@

[GitHub] [calcite] hsyuan commented on issue #1389: [CALCITE-3265] remove useless code

hsyuan commented on issue #1389: [CALCITE-3265] remove useless code URL: https://github.com/apache/calcite/pull/1389#issuecomment-523234350 Yes, better to merge them. This is an automated message from the Apache Git Service.

[calcite] branch master updated (6b600e4 -> 11116f6)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 6b600e4 [CALCITE-3267] Remove method SqlDataTypeSpec#deriveType(RelDataTypefactory) new 79b97b6

[calcite] 04/06: [CALCITE-3252] Add CONVERT_TIMEZONE, TO_DATE and TO_TIMESTAMP non-standard functions (Lindsey Meyer)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit e8b08c490ab4270945c35f31846cd36b5788cc23 Author: Lindsey Meyer AuthorDate: Wed Aug 14 11:34:15 2019 -0700

[GitHub] [calcite] asfgit closed pull request #1247: [CALCITE-3089] Deprecate EquiJoin

asfgit closed pull request #1247: [CALCITE-3089] Deprecate EquiJoin URL: https://github.com/apache/calcite/pull/1247 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite] 05/06: [CALCITE-3258] Upgrade jackson-databind from 2.9.9 to 2.9.9.3, and kafka-clients from 2.0.0 to 2.1.1

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit a71def51dbf3dc18af2e73418ed30e0f2e6addde Author: Julian Hyde AuthorDate: Fri Aug 16 14:12:03 2019 -0700

[calcite] 03/06: [CALCITE-3167] Make equals and hashCode methods final in AbstractRelNode, and remove overriding methods in EnumerableTableScan (Jin Xing)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 3f550c3f28d75d0f75b5815a22395dbecf992f03 Author: jinxing AuthorDate: Fri Jul 5 10:55:03 2019 +0800 [CALCITE-3167]

[GitHub] [calcite] asfgit closed pull request #1294: [CALCITE-3167] Remove redundant overriding methods of equals in EnumerableTableScan and make equals/hashCode methods final in AbstractRelN

asfgit closed pull request #1294: [CALCITE-3167] Remove redundant overriding methods of equals in EnumerableTableScan and make equals/hashCode methods final in AbstractRelNode URL: https://github.com/apache/calcite/pull/1294

[calcite] 02/06: [CALCITE-3089] Deprecate EquiJoin

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 36e3109fb524c13ca0a08e3ad585785aa5abc18b Author: Haisheng Yuan AuthorDate: Thu May 30 23:53:37 2019 -0500

[GitHub] [calcite] KhawlaMhb commented on issue #1369: [CALCITE-2979] Add a block-based nested loop join algorithm (Khawla Mouhoubi)

KhawlaMhb commented on issue #1369: [CALCITE-2979] Add a block-based nested loop join algorithm (Khawla Mouhoubi) URL: https://github.com/apache/calcite/pull/1369#issuecomment-522993601 @julianhyde Thank you for the comments. I have applied point 1 & 3 to the javadoc. Regarding point

[GitHub] [calcite] Fokko commented on issue #1389: [CALCITE-3265] remove useless code

Fokko commented on issue #1389: [CALCITE-3265] remove useless code URL: https://github.com/apache/calcite/pull/1389#issuecomment-522990971 @danny0405 Maybe we can merge this with https://github.com/apache/calcite/pull/1393

[GitHub] [calcite] Fokko commented on issue #1389: [CALCITE-3265] remove useless code

Fokko commented on issue #1389: [CALCITE-3265] remove useless code URL: https://github.com/apache/calcite/pull/1389#issuecomment-522991077 Personally, I don't think a PR can't be too small :-) This is an automated message

[GitHub] [calcite] danny0405 commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields

danny0405 commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields URL: https://github.com/apache/calcite/pull/1374#discussion_r315646237 ## File path:

[GitHub] [calcite-avatica-go] trusch opened a new pull request #47: Add more nil checks in error handling.

trusch opened a new pull request #47: Add more nil checks in error handling. URL: https://github.com/apache/calcite-avatica-go/pull/47 This adds the same nil checks while parsing errors as in connection.go I added a few days ago. I'm greping around to find more missing nil checks, but

[GitHub] [calcite] danny0405 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null

danny0405 commented on a change in pull request #1338: [CALCITE-3210] Fix the bug that RelToSqlConverter converts "cast(null as $type)" just as null URL: https://github.com/apache/calcite/pull/1338#discussion_r315636184 ## File path:

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields

ihuzenko commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields URL: https://github.com/apache/calcite/pull/1374#discussion_r315628432 ## File path:

[GitHub] [calcite] danny0405 merged pull request #1392: [CALCITE-3267] Remove method SqlDataTypeSpec#deriveType(RelDataTypefa…

danny0405 merged pull request #1392: [CALCITE-3267] Remove method SqlDataTypeSpec#deriveType(RelDataTypefa… URL: https://github.com/apache/calcite/pull/1392 This is an automated message from the Apache Git Service. To

[calcite] branch master updated (6400a50 -> 6b600e4)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 6400a50 [CALCITE-3214] Add UnionToUnionRule for materialization matching (refine rule name) (Jin Xing)

svn commit: r35311 - /release/calcite/KEYS

Author: zabetak Date: Tue Aug 20 07:49:46 2019 New Revision: 35311 Log: Add Stamatis Zampetakis (zabetak) to KEYS Modified: release/calcite/KEYS Modified: release/calcite/KEYS == --- release/calcite/KEYS (original)

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields

ihuzenko commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields URL: https://github.com/apache/calcite/pull/1374#discussion_r315531729 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields

danny0405 commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields URL: https://github.com/apache/calcite/pull/1374#discussion_r315523140 ## File path:

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields

ihuzenko commented on a change in pull request #1374: [CALCITE-3138] RelStructuredTypeFlattener doesn't restructure ROW type fields URL: https://github.com/apache/calcite/pull/1374#discussion_r315517950 ## File path: