[GitHub] [calcite] yanlin-Lynn commented on issue #1426: [CALCITE-3313] Describe the end-user functionality of REGEXP_REPLACE

yanlin-Lynn commented on issue #1426: [CALCITE-3313] Describe the end-user functionality of REGEXP_REPLACE URL: https://github.com/apache/calcite/pull/1426#issuecomment-526805759 > LGTM~ But I cannot see If `regexp_replace` supports `Char` type in `Mysql`? In the document on [calcite

[GitHub] [calcite] yanlin-Lynn commented on issue #1426: [CALCITE-3313] Describe the end-user functionality of REGEXP_REPLACE

yanlin-Lynn commented on issue #1426: [CALCITE-3313] Describe the end-user functionality of REGEXP_REPLACE URL: https://github.com/apache/calcite/pull/1426#issuecomment-526805475 > Can you change the title to describe the end-user functionality? I change the title of the PR and the c

[GitHub] [calcite] danny0405 merged pull request #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri…

danny0405 merged pull request #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423 This is an automated message from the Apache Git Ser

[calcite] branch master updated (b8d24a6 -> 81c768e)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from b8d24a6 [CALCITE-3292] SqlToRelConverter#substituteSubQuery fails with NullPointerException when converting Sql

[GitHub] [calcite] danny0405 commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri…

danny0405 commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423#issuecomment-526797414 Thanks for the reminder @hsyuan ! --

[GitHub] [calcite] hsyuan commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri…

hsyuan commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423#issuecomment-526797193 Please change the commit title by adding JIRA issue. --

[GitHub] [calcite] hsyuan commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri…

hsyuan commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423#issuecomment-526797096 Sorry, just noticed the test case. :) -

[GitHub] [calcite] hsyuan commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri…

hsyuan commented on issue #1423: [CALCITE-3310] Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423#issuecomment-526797080 Can you add the test case in the issue? ---

[calcite] branch master updated (72680df -> b8d24a6)

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 72680df [CALCITE-3311] Add doc to site for implicit type coercion add b8d24a6 [CALCITE-3292] SqlToRelConverter

[GitHub] [calcite] hsyuan merged pull request #1413: [CALCITE-3292] SqlToRelConverter#substituteSubQuery fails with NullPo…

hsyuan merged pull request #1413: [CALCITE-3292] SqlToRelConverter#substituteSubQuery fails with NullPo… URL: https://github.com/apache/calcite/pull/1413 This is an automated message from the Apache Git Service. To respond t

[GitHub] [calcite] hsyuan commented on issue #1418: [CALCITE-3298] Add getSelectivity for TableScan in RelMdSelectivity

hsyuan commented on issue #1418: [CALCITE-3298] Add getSelectivity for TableScan in RelMdSelectivity URL: https://github.com/apache/calcite/pull/1418#issuecomment-526796742 Can you rebase on latest master? This is an automate

[GitHub] [calcite] LiShuMing opened a new pull request #1431: [MINOR] Improve document in adapter.md

LiShuMing opened a new pull request #1431: [MINOR] Improve document in adapter.md URL: https://github.com/apache/calcite/pull/1431 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [calcite] LiShuMing opened a new pull request #1430: [MINOR] Fix broken link in SqlParserTest

LiShuMing opened a new pull request #1430: [MINOR] Fix broken link in SqlParserTest URL: https://github.com/apache/calcite/pull/1430 Original url https://developer.mimer.com/wp-content/uploads/2018/05/Standard-SQL-Reserved-Words-Summary.pdf is broken.

[GitHub] [calcite] danny0405 opened a new pull request #1429: [CALCITE-3315] Multiple failures in Druid IT tests due to implicit casts

danny0405 opened a new pull request #1429: [CALCITE-3315] Multiple failures in Druid IT tests due to implicit casts URL: https://github.com/apache/calcite/pull/1429 This is an automated message from the Apache Git Service. T

[GitHub] [calcite] julianhyde commented on issue #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

julianhyde commented on issue #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426#issuecomment-526794615 Can you change the title to describe the end-user functionality?

[GitHub] [calcite] LiShuMing commented on issue #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

LiShuMing commented on issue #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426#issuecomment-526793900 LGTM~ But I cannot see If `regexp_replace` supports `Char` type in `Mysql`? --

[GitHub] [calcite] danny0405 closed pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

danny0405 closed pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426 This is an automated message from the Apache Git Servi

[GitHub] [calcite] yanlin-Lynn opened a new pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

yanlin-Lynn opened a new pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426 The `getAllowedSignatures` of class `SqlRegexpReplaceFunction` is not overrided, and `operandTypeChecker ` is nu

[GitHub] [calcite] rubenada opened a new pull request #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a sing

rubenada opened a new pull request #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location URL: https://github.com/apache/calcite/pull/1424 Jira ticket: [CALCITE-3309](https://issues.ap

[GitHub] [calcite] danny0405 closed pull request #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single lo

danny0405 closed pull request #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location URL: https://github.com/apache/calcite/pull/1424 --

[calcite] branch master updated: [CALCITE-3311] Add doc to site for implicit type coercion

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 72680df [CALCITE-3311] Add doc to site for

[GitHub] [calcite] danny0405 merged pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion

danny0405 merged pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion URL: https://github.com/apache/calcite/pull/1428 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [calcite] danny0405 opened a new pull request #1423: Approximate and exact aggregate calls are recognized as the same duri…

danny0405 opened a new pull request #1423: Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423 …ng sql-to-rel conversion This is an automated message from th

[GitHub] [calcite] danny0405 closed pull request #1423: Approximate and exact aggregate calls are recognized as the same duri…

danny0405 closed pull request #1423: Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423 This is an automated message from the Apache Git Service. To respon

[GitHub] [calcite] danny0405 closed pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion

danny0405 closed pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion URL: https://github.com/apache/calcite/pull/1428 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [calcite] danny0405 opened a new pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion

danny0405 opened a new pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion URL: https://github.com/apache/calcite/pull/1428 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [calcite] rubenada commented on issue #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single loca

rubenada commented on issue #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location URL: https://github.com/apache/calcite/pull/1424#issuecomment-526642398 @zabetak Any chance you can tak

[GitHub] [calcite] risdenk commented on a change in pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark

risdenk commented on a change in pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark URL: https://github.com/apache/calcite/pull/1427#discussion_r319545817 ## File path: pig/pom.xml ## @@ -159,6 +159,15 @@ lim

[GitHub] [calcite] risdenk commented on a change in pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark

risdenk commented on a change in pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark URL: https://github.com/apache/calcite/pull/1427#discussion_r319545576 ## File path: pig/pom.xml ## @@ -159,6 +159,15 @@ lim

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

yanlin-Lynn commented on a change in pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426#discussion_r319536517 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlRegexpR

[calcite] branch master updated (6cec811 -> e2300d2)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 6cec811 [CALCITE-2973],[CALCITE-3284] Allow joins(hash,semi,anti) that have equi conditions to be executed using

[GitHub] [calcite] zabetak merged pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

zabetak merged pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425 This is an automated message from the Apache Git Service. To res

[GitHub] [calcite] danny0405 commented on a change in pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

danny0405 commented on a change in pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426#discussion_r319496048 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlRegexpRep

[GitHub] [calcite] rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319482789 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelOpTest.java

[GitHub] [calcite] rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319482597 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelTestBase.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

zabetak commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319479499 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelOpTest.java #

[GitHub] [calcite] zabetak commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

zabetak commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319479973 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelTestBase.java ###

[GitHub] [calcite] danny0405 opened a new pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion

danny0405 opened a new pull request #1428: [CALCITE-3311] Add doc to site for implicit type coercion URL: https://github.com/apache/calcite/pull/1428 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [calcite] danny0405 commented on issue #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

danny0405 commented on issue #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#issuecomment-526561769 Thanks for fixing this @rubenada ! This i

[GitHub] [calcite] rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319455648 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelExTest.java

[GitHub] [calcite] zabetak opened a new pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark

zabetak opened a new pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark URL: https://github.com/apache/calcite/pull/1427 Disable OWASP dependency-check for pig, piglet, and spark modules. -

[GitHub] [calcite] yanlin-Lynn commented on issue #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

yanlin-Lynn commented on issue #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426#issuecomment-526544655 cc @LiShuMing This is an autom

[GitHub] [calcite] yanlin-Lynn opened a new pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction.

yanlin-Lynn opened a new pull request #1426: [CALCITE-3313] Override getAllowedSignatures function for SqlRegexpReplaceFunction. URL: https://github.com/apache/calcite/pull/1426 The `getAllowedSignatures` of class `SqlRegexpReplaceFunction` is not overrided, and `operandTypeChecker ` is nu

[GitHub] [calcite] rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

rubenada commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319445590 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelExTest.java

[GitHub] [calcite] zabetak commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

zabetak commented on a change in pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425#discussion_r319438150 ## File path: piglet/src/test/java/org/apache/calcite/test/PigRelExTest.java #

[GitHub] [calcite] rubenada opened a new pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows

rubenada opened a new pull request #1425: [CALCITE-3307] PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows URL: https://github.com/apache/calcite/pull/1425 Jira: [CALCITE-3307](https://issues.apache.org/jira/browse/CALCITE-3307) -

[GitHub] [calcite] rubenada opened a new pull request #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a sing

rubenada opened a new pull request #1424: [CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location URL: https://github.com/apache/calcite/pull/1424 Jira ticket: [CALCITE-3309](https://issues.ap

[GitHub] [calcite] danny0405 opened a new pull request #1423: Approximate and exact aggregate calls are recognized as the same duri…

danny0405 opened a new pull request #1423: Approximate and exact aggregate calls are recognized as the same duri… URL: https://github.com/apache/calcite/pull/1423 …ng sql-to-rel conversion This is an automated message from th