[GitHub] [calcite] ffmax closed pull request #1402: [CALCITE-3282] Make every SqlDialect unparse their own data type

2019-09-02 Thread GitBox
ffmax closed pull request #1402: [CALCITE-3282] Make every SqlDialect unparse their own data type URL: https://github.com/apache/calcite/pull/1402 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] jinxing64 edited a comment on issue #1434: [CALCITE-2970] Performance issue when enabling merge join.

2019-09-02 Thread GitBox
jinxing64 edited a comment on issue #1434: [CALCITE-2970] Performance issue when enabling merge join. URL: https://github.com/apache/calcite/pull/1434#issuecomment-527137377 @hsyuan @vlsi How do you think about this one? Would you please take a look when you have time? Thanks a

[GitHub] [calcite] xy2953396112 closed pull request #1411: [CALCITE-3290] Implement evaluate method of AbstractNode

2019-09-02 Thread GitBox
xy2953396112 closed pull request #1411: [CALCITE-3290] Implement evaluate method of AbstractNode URL: https://github.com/apache/calcite/pull/1411 This is an automated message from the Apache Git Service. To respond to the

svn commit: r35502 - in /dev/calcite/apache-calcite-1.21.0-rc0: ./ apache-calcite-1.21.0-src.tar.gz apache-calcite-1.21.0-src.tar.gz.asc apache-calcite-1.21.0-src.tar.gz.sha256

2019-09-02 Thread zabetak
Author: zabetak Date: Mon Sep 2 14:19:01 2019 New Revision: 35502 Log: Add apache-calcite-1.21.0-rc0 Added: dev/calcite/apache-calcite-1.21.0-rc0/ dev/calcite/apache-calcite-1.21.0-rc0/apache-calcite-1.21.0-src.tar.gz (with props)

[GitHub] [calcite] wenhuitang commented on a change in pull request #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
wenhuitang commented on a change in pull request #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435#discussion_r319963700 ## File path:

[GitHub] [calcite] zabetak commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
zabetak commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435#issuecomment-527151224 Thanks for noticing. The 1.21.0 release is on its way so we will handle it

[GitHub] [calcite] danny0405 commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
danny0405 commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435#issuecomment-527149232 Well, i got your idea, thanks.

[calcite] branch branch-1.21 updated: [maven-release-plugin] prepare for next development iteration

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch branch-1.21 in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/branch-1.21 by this push: new 3583601 [maven-release-plugin]

[calcite] annotated tag calcite-1.21.0 created (now 87292ba)

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to annotated tag calcite-1.21.0 in repository https://gitbox.apache.org/repos/asf/calcite.git. at 87292ba (tag) tagging 4420139600bb68f8568c4b1c960ad4dbcb1a43f1 (commit) replaces calcite-1.20.0

[calcite] branch branch-1.21 updated: [maven-release-plugin] prepare release calcite-1.21.0

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch branch-1.21 in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/branch-1.21 by this push: new 4420139 [maven-release-plugin]

[GitHub] [calcite] wenhuitang commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
wenhuitang commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435#issuecomment-527145287 > The `out` convention is added in the `ConverterRule` class. Yes, So

[calcite] branch branch-1.21 created (now f2f47fa)

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch branch-1.21 in repository https://gitbox.apache.org/repos/asf/calcite.git. at f2f47fa [CALCITE-3303] Release Calcite 1.21.0 This branch includes the following new commits: new

[calcite] 01/01: [CALCITE-3303] Release Calcite 1.21.0

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch branch-1.21 in repository https://gitbox.apache.org/repos/asf/calcite.git commit f2f47fa03db3cacb25aee792aca470aa0f0dde60 Author: Stamatis Zampetakis AuthorDate: Wed Aug 28 12:07:49 2019 +0200

[GitHub] [calcite] jinxing64 commented on issue #1434: [CALCITE-2970] Performance issue when enabling merge join.

2019-09-02 Thread GitBox
jinxing64 commented on issue #1434: [CALCITE-2970] Performance issue when enabling merge join. URL: https://github.com/apache/calcite/pull/1434#issuecomment-527137377 @hsyuan Would you please take a look at this one ?

[GitHub] [calcite] danny0405 commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
danny0405 commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435#issuecomment-527135232 The `out` convention is added in the `ConverterRule` class.

[GitHub] [calcite] wenhuitang commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
wenhuitang commented on issue #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435#issuecomment-527132614 @zabetak hello, it seems CALCITE-3115 should change

[GitHub] [calcite] wenhuitang opened a new pull request #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule.

2019-09-02 Thread GitBox
wenhuitang opened a new pull request #1435: [hotfix]Remove the useless JdbcConvention out in descriptionPrefix for JdbcToEnumerableConverterRule. URL: https://github.com/apache/calcite/pull/1435 CALCITE-3115 has merged into master, But it not modify the descriptionPrefix of

[GitHub] [calcite] zabetak closed pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

2019-09-02 Thread GitBox
zabetak closed pull request #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397 This is an automated message from

[calcite] branch master updated (c9520c3 -> 955d4ea)

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from c9520c3 [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark add

[GitHub] [calcite] zabetak commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

2019-09-02 Thread GitBox
zabetak commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#issuecomment-527122562 I'm going to merge this PR the way it is right now. Le'ts treat the remaining

[GitHub] [calcite] wenhuitang commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

2019-09-02 Thread GitBox
wenhuitang commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#issuecomment-527114223 Sorry for replying too late., I have been busy with other things in the

[GitHub] [calcite] vvysotskyi commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

2019-09-02 Thread GitBox
vvysotskyi commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#issuecomment-527069650 Hi @zabetak, I understand your concerns connected with this change, but I

[GitHub] [calcite] jinxing64 edited a comment on issue #1434: [CALCITE-2970] Performance issue when enabling merge join.

2019-09-02 Thread GitBox
jinxing64 edited a comment on issue #1434: [CALCITE-2970] Performance issue when enabling merge join. URL: https://github.com/apache/calcite/pull/1434#issuecomment-527059182 Weird, it's complaining ``` [ERROR] testMergeJoin(org.apache.calcite.plan.volcano.VolcanoPlannerTest) Time

[GitHub] [calcite] jinxing64 commented on issue #1434: [CALCITE-2970] Performance issue when enabling merge join.

2019-09-02 Thread GitBox
jinxing64 commented on issue #1434: [CALCITE-2970] Performance issue when enabling merge join. URL: https://github.com/apache/calcite/pull/1434#issuecomment-527059182 Weird, it's complaining ``` [ERROR] testMergeJoin(org.apache.calcite.plan.volcano.VolcanoPlannerTest) Time

[GitHub] [calcite] zabetak merged pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark

2019-09-02 Thread GitBox
zabetak merged pull request #1427: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark URL: https://github.com/apache/calcite/pull/1427 This is an automated message from the

[calcite] branch master updated: [CALCITE-3314] CVSS dependency-check-maven fails for calcite-pig, calcite-piglet, calcite-spark

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new c9520c3 [CALCITE-3314] CVSS

[calcite] branch master updated (55cc3ab -> 48086a7)

2019-09-02 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 55cc3ab [CALCITE-3309] Refactor generatePredicate method from

[GitHub] [calcite] zabetak merged pull request #1432: [CALCITE-3315] Multiple failures in Druid IT tests due to implicit casts

2019-09-02 Thread GitBox
zabetak merged pull request #1432: [CALCITE-3315] Multiple failures in Druid IT tests due to implicit casts URL: https://github.com/apache/calcite/pull/1432 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] danny0405 commented on issue #1289: [CALCITE-3126] Remove deprecated SemiJoin usage completely

2019-09-02 Thread GitBox
danny0405 commented on issue #1289: [CALCITE-3126] Remove deprecated SemiJoin usage completely URL: https://github.com/apache/calcite/pull/1289#issuecomment-527040458 @zabetak Maybe we should put the change and equivalent plan to the 1.21 release nodes or breaking changes, this would help

[GitHub] [calcite] jinxing64 opened a new pull request #1434: [CALCITE-2970] Performance issue when enabling merge join.

2019-09-02 Thread GitBox
jinxing64 opened a new pull request #1434: [CALCITE-2970] Performance issue when enabling merge join. URL: https://github.com/apache/calcite/pull/1434 Currently `AbstractConvert` is disabled for EnumerableConvention(and other conventions). Thus no chance to apply a sort-merge-join (SMJ)

[GitHub] [calcite] eolivelli commented on issue #1289: [CALCITE-3126] Remove deprecated SemiJoin usage completely

2019-09-02 Thread GitBox
eolivelli commented on issue #1289: [CALCITE-3126] Remove deprecated SemiJoin usage completely URL: https://github.com/apache/calcite/pull/1289#issuecomment-527030956 @amitvc Please take a look, this change will help you in the upgrade to 1.21

[GitHub] [calcite] rubenada commented on issue #1289: [CALCITE-3126] Remove deprecated SemiJoin usage completely

2019-09-02 Thread GitBox
rubenada commented on issue #1289: [CALCITE-3126] Remove deprecated SemiJoin usage completely URL: https://github.com/apache/calcite/pull/1289#issuecomment-527030248 As @danny0405 said, EnumerableNestedLoopJoin can support SemiJoin with any type of join condition. In case of SemiJoin