[GitHub] [calcite] DonnyZone opened a new pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-09 Thread GitBox
DonnyZone opened a new pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448 Calcite runtime can process null semantic. However, the null literal is not properly handled when

[GitHub] [calcite] DonnyZone commented on issue #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2019-09-09 Thread GitBox
DonnyZone commented on issue #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#issuecomment-529740758 @zabetak Sure, thanks! I will rebase it in the next few days.

[GitHub] [calcite] xndai commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost…

2019-09-09 Thread GitBox
xndai commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost… URL: https://github.com/apache/calcite/pull/552#issuecomment-529713847 @zabetak @vvysotskyi I look closer and find two tests cases in JdbcTest where I see rel nodes have different

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322481311 ## File path:

[GitHub] [calcite] asereda-gs commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#issuecomment-529690332 Pls squash commits into one and add your name to commit message as `(FirstName LastName)`

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322479819 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322478764 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322434323 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322329449 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322329449 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322324063 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322324063 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322322367 ## File path:

[GitHub] [calcite] shikhasomani opened a new pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-09 Thread GitBox
shikhasomani opened a new pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447 … i.e. to allow connecting on HTTPS This is an automated

[GitHub] [calcite] zabetak commented on issue #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2019-09-09 Thread GitBox
zabetak commented on issue #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#issuecomment-529472371 Hey @DonnyZone , apologies for my late reply but I've been rather busy lately. Whenever you get the chance please

[GitHub] [calcite] soma-mondal commented on a change in pull request #1437: [CALCITE-3318] Preserving CAST of STRING operands in comparison operator

2019-09-09 Thread GitBox
soma-mondal commented on a change in pull request #1437: [CALCITE-3318] Preserving CAST of STRING operands in comparison operator URL: https://github.com/apache/calcite/pull/1437#discussion_r322236640 ## File path:

[GitHub] [calcite-avatica] gabrielreid opened a new pull request #110: [CALCITE-3333] Add pluggable frame size limits

2019-09-09 Thread GitBox
gabrielreid opened a new pull request #110: [CALCITE-] Add pluggable frame size limits URL: https://github.com/apache/calcite-avatica/pull/110 Add an ability to plug in custom limiting of ResultSet frame sizes by overriding a method of JdbcMeta. The intention is to allow

[GitHub] [calcite] Technay opened a new pull request #1446: Rav 995

2019-09-09 Thread GitBox
Technay opened a new pull request #1446: Rav 995 URL: https://github.com/apache/calcite/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] danny0405 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-09 Thread GitBox
danny0405 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#discussion_r322202200 ## File path:

[GitHub] [calcite] wenhuitang edited a comment on issue #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect.

2019-09-09 Thread GitBox
wenhuitang edited a comment on issue #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect. URL: https://github.com/apache/calcite/pull/1285#issuecomment-529350172 Hello, @julianhyde @michaelmior @hsyuan ,Do you have

[GitHub] [calcite] ffmax commented on issue #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-09 Thread GitBox
ffmax commented on issue #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#issuecomment-529420967 @danny0405 Yeah, Hive 2.x already supports Integer, but using the common type between

[GitHub] [calcite] ffmax commented on issue #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-09 Thread GitBox
ffmax commented on issue #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#issuecomment-529420360 I find It might be necessary to add INT enum in SqlTypeName, if we want to refactor

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322169357 ## File path:

[GitHub] [calcite] zabetak commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost…

2019-09-09 Thread GitBox
zabetak commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost… URL: https://github.com/apache/calcite/pull/552#issuecomment-529391719 Hi @xndai if you have two clusters in the same `RelNode` tree then it sounds like a bug. There are various checks

[GitHub] [calcite] DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322146740 ## File path:

[GitHub] [calcite] DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322142066 ## File path:

[GitHub] [calcite] wenhuitang commented on a change in pull request #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect.

2019-09-09 Thread GitBox
wenhuitang commented on a change in pull request #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect. URL: https://github.com/apache/calcite/pull/1285#discussion_r322111485 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322106087 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322103801 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322106835 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-09-09 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r322103801 ## File path:

[GitHub] [calcite] xndai commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost…

2019-09-09 Thread GitBox
xndai commented on issue #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost… URL: https://github.com/apache/calcite/pull/552#issuecomment-529320548 Also I notice under debugger that RelNode tree can have more than one RelOptCluster. I haven't dig into that. But if

[GitHub] [calcite] xndai commented on a change in pull request #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost…

2019-09-09 Thread GitBox
xndai commented on a change in pull request #552: [CALCITE-2018] Queries failed with AssertionError: rel has lower cost… URL: https://github.com/apache/calcite/pull/552#discussion_r322081042 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##