danny0405 commented on a change in pull request #1455: [CALCITE-3349] Add
create and drop function into SqlKind ddl enumerations
URL: https://github.com/apache/calcite/pull/1455#discussion_r327939178
##
File path: server/src/test/java/org/apache/calcite/test/ServerTest.java
HuangZhenQiu commented on a change in pull request #1455: [CALCITE-3349] Add
create and drop function into SqlKind ddl enumerations
URL: https://github.com/apache/calcite/pull/1455#discussion_r327935061
##
File path: server/src/test/java/org/apache/calcite/test/ServerTest.java
wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327929648
##
File path:
wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327929648
##
File path:
wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327929648
##
File path:
danny0405 commented on a change in pull request #1474: [CALCITE-3370] Add NULL
direction emulation for MSSQL
URL: https://github.com/apache/calcite/pull/1474#discussion_r327903280
##
File path:
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java
##
@@
danny0405 commented on a change in pull request #1474: [CALCITE-3370] Add NULL
direction emulation for MSSQL
URL: https://github.com/apache/calcite/pull/1474#discussion_r327902674
##
File path:
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java
##
@@
danny0405 commented on a change in pull request #1474: [CALCITE-3370] Add NULL
direction emulation for MSSQL
URL: https://github.com/apache/calcite/pull/1474#discussion_r327902744
##
File path:
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java
##
@@
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 0c8cbacd0f30b5df15b7cb93c0ab2be5d0324372
Author: Justin Swett
AuthorDate: Tue Sep 24 15:40:53 2019 -0700
asfgit closed pull request #1474: [CALCITE-3370] Add NULL direction emulation
for MSSQL
URL: https://github.com/apache/calcite/pull/1474
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit bb3889e860cc7472e31ba39ac6d3d5a0e3c59463
Author: Julian Hyde
AuthorDate: Tue Sep 24 14:03:32 2019 -0700
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit ed692fd4f2f00261348ecac779cb1a6d544d052e
Author: Ryan Fu
AuthorDate: Mon Sep 23 16:30:15 2019 -0700
[CALCITE-3323]
asfgit closed pull request #1471: Added tests and methods to handle arbitrary
functions
URL: https://github.com/apache/calcite/pull/1471
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from 47a626d Improve READMEs and release howto instructions
new bb3889e [CALCITE-3369] In LatticeSuggester,
hsyuan commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534835360
> Also, because it projects fewer columns, it may match materialized views
that an equivalent ordinary join would
julianhyde commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534833835
Semi-join may have a lower cost implementation than a regular Join. It’s
worth knowing that you have one.
hsyuan commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534824750
> Ideally it would also match Join(Scan(emp), Scan(dept)) (i.e. without the
Aggregate) provided that there was a
hsyuan edited a comment on issue #1469: [CALCITE-3367] Add AntiJoinRule to
convert project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534824750
> Ideally it would also match Join(Scan(emp), Scan(dept)) (i.e. without the
Aggregate) provided that there
julianhyde commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534823684
I am talking about the current rule, which transforms `Join(Scan(emp),
Aggregate(Scan(dept)))` into
hsyuan edited a comment on issue #1469: [CALCITE-3367] Add AntiJoinRule to
convert project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534820968
Julian, the rule you are talking about is a rule that transforms a SEMI/ANTI
join into a join on top of
hsyuan commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534820968
Julian, the rule you are talking about is a rule that transforms a SEMI/ANTI
join into an inner join on top of
hsyuan commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534819486
I agree that people may still write queries with direct SEMI/ANIT join, but
what the `SemiJoinRule` does is
julianhyde commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534818701
We should definitely keep `SemiJoinRule` around. People may still write
queries that do semi-joins without
danny0405 commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327904933
##
File path:
julianhyde commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327903357
##
File path:
danny0405 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327902044
##
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##
@@ -6349,6 +6349,47
danny0405 commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534814752
> I don't like the idea of `SemiJoinRule`, which is counter intuitive. A
boolean context IN or existential
jswett77 opened a new pull request #1474: Adding null direction emulation for
MSSQL: Calcite-3370
URL: https://github.com/apache/calcite/pull/1474
This change should support null direction emulation for MSSQL.
* MssqlSqlDialect: updated NullCollation to Low and override
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new 0efd728 Improve READMEs and release howto
zabetak merged pull request #1472: Improve READMEs and release howto
instructions
URL: https://github.com/apache/calcite/pull/1472
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from 3005ff9 [CALCITE-3365] Don't require use of JdbcSchema in
QuerySqlStatisticProvider (Lindsey Meyer)
add
zabetak commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327851499
##
File path:
julianhyde commented on issue #1453: [CALCITE-3346] Enable some ignored tests
in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#issuecomment-534763696
The `transitiveInference` method was always a bit weird, and different from
other tests. But at least it made things
hsyuan closed pull request #1473: Regexp replace
URL: https://github.com/apache/calcite/pull/1473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hsyuan commented on issue #1473: Regexp replace
URL: https://github.com/apache/calcite/pull/1473#issuecomment-534750924
Closing it, since it contains unnecessary commits. @Bindi1993 You can
reopen the pull request after you have clean it up. Also please attach JIRA
case and follow the
hsyuan commented on issue #1469: [CALCITE-3367] Add AntiJoinRule to convert
project-filter-join-aggreg…
URL: https://github.com/apache/calcite/pull/1469#issuecomment-534747445
I don't like the idea of `SemiJoinRule`, which is counter intuitive. A
boolean context IN or existential
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new 3005ff9 [CALCITE-3365] Don't require use of
jinxing64 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327605513
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6
jinxing64 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327603157
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6
danny0405 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327597626
##
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##
@@ -6349,6 +6349,47
wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327596123
##
File path:
danny0405 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327595087
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6
wenhuitang commented on issue #1462: [CALCITE-3353]ProjectJoinTransposeRule
caused AssertionError when creating a new Join
URL: https://github.com/apache/calcite/pull/1462#issuecomment-534542418
I made some changes to this PR. Hope to get more reviews.
danny0405 commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327592525
##
File path:
wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327591486
##
File path:
Bindi1993 opened a new pull request #1473: Regexp replace
URL: https://github.com/apache/calcite/pull/1473
regexp_replace changes
This is an automated message from the Apache Git Service.
To respond to the message, please
jinxing64 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327549581
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6
yanlin-Lynn commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r327514458
##
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##
@@
jinxing64 commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327510672
##
File path:
zabetak commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327502867
##
File path:
danny0405 commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r327486568
##
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##
@@
yanlin-Lynn commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r327479483
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
jinxing64 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327453817
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6
danny0405 commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r327459577
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
jinxing64 commented on issue #1370: [CALCITE-3239] Calc#accept(RexShuttle
shuttle) does not update rowType
URL: https://github.com/apache/calcite/pull/1370#issuecomment-534422053
Thanks for approve !
@hsyuan
This is an
jinxing64 commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327456315
##
File path:
This is an automated email from the ASF dual-hosted git repository.
hyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new be01394 [CALCITE-3239] Calc#accept(RexShuttle
hsyuan merged pull request #1370: [CALCITE-3239] Calc#accept(RexShuttle
shuttle) does not update rowType
URL: https://github.com/apache/calcite/pull/1370
This is an automated message from the Apache Git Service.
To respond
jinxing64 commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327453817
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6
hsyuan closed pull request #1393: [CALCITE-3265] Remove the unused variables
URL: https://github.com/apache/calcite/pull/1393
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hsyuan commented on issue #1393: [CALCITE-3265] Remove the unused variables
URL: https://github.com/apache/calcite/pull/1393#issuecomment-534418784
Closing for now because the code are intentional.
This is an automated
hsyuan commented on a change in pull request #1453: [CALCITE-3346] Enable some
ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r327451074
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
@@
wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327448281
##
File path:
hsyuan commented on a change in pull request #1468: [CALCITE-3366]
RelDecorrelator supports Union
URL: https://github.com/apache/calcite/pull/1468#discussion_r327447272
##
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##
@@ -1242,6 +1244,37
jinxing64 commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327443896
##
File path:
65 matches
Mail list logo