[GitHub] [calcite] danny0405 commented on a change in pull request #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan'

2019-10-27 Thread GitBox
danny0405 commented on a change in pull request #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan' URL: https://github.com/apache/calcite/pull/1531#discussion_r339408757 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java

[GitHub] [calcite] jinxing64 commented on issue #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching

2019-10-27 Thread GitBox
jinxing64 commented on issue #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching URL: https://github.com/apache/calcite/pull/1451#issuecomment-546796350 Wow, thanks a lot for your effort to review this @hsyuan @julianhyde @yanlin-Lynn I will definitely be active to

[calcite] branch master updated (76f9847 -> 93da00b)

2019-10-27 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 76f9847 [CALCITE-3439] Support Intersect and Minus in RelMdPredicates (Jin Xing) add 93da00b [CALCITE-3334]

[GitHub] [calcite] hsyuan closed pull request #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching

2019-10-27 Thread GitBox
hsyuan closed pull request #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching URL: https://github.com/apache/calcite/pull/1451 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"…

2019-10-27 Thread GitBox
amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"… URL: https://github.com/apache/calcite/pull/1510#discussion_r339401555 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java

[GitHub] [calcite] cndaimin commented on a change in pull request #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan'

2019-10-27 Thread GitBox
cndaimin commented on a change in pull request #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan' URL: https://github.com/apache/calcite/pull/1531#discussion_r339392436 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan'

2019-10-27 Thread GitBox
yanlin-Lynn commented on a change in pull request #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan' URL: https://github.com/apache/calcite/pull/1531#discussion_r339393557 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java

[GitHub] [calcite] jinxing64 commented on issue #1526: [CALCITE-3439] Support Intersect and Minus in RelMdPredicates

2019-10-27 Thread GitBox
jinxing64 commented on issue #1526: [CALCITE-3439] Support Intersect and Minus in RelMdPredicates URL: https://github.com/apache/calcite/pull/1526#issuecomment-546778222 Thanks for merging ~ @hsyuan This is an automated

[GitHub] [calcite] cndaimin commented on issue #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan'

2019-10-27 Thread GitBox
cndaimin commented on issue #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan' URL: https://github.com/apache/calcite/pull/1531#issuecomment-546778219 > Related with CALCITE-3167 (https://github.com/apache/calcite/pull/1294/files) > Check --

[GitHub] [calcite] wuyunfeng commented on issue #1529: [CALCITE-3442] `stored_fields = _none_` prohibit FetchPhase get be involved

2019-10-27 Thread GitBox
wuyunfeng commented on issue #1529: [CALCITE-3442] `stored_fields = _none_` prohibit FetchPhase get be involved URL: https://github.com/apache/calcite/pull/1529#issuecomment-546771418 @jinxing64 OK This is an automated

[GitHub] [calcite] jinxing64 commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"…

2019-10-27 Thread GitBox
jinxing64 commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"… URL: https://github.com/apache/calcite/pull/1510#discussion_r339383877 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java

[GitHub] [calcite] jinxing64 commented on issue #1532: [CALCITE-3448] AggregateOnProjectToAggregateUnifyRule ignores Project…

2019-10-27 Thread GitBox
jinxing64 commented on issue #1532: [CALCITE-3448] AggregateOnProjectToAggregateUnifyRule ignores Project… URL: https://github.com/apache/calcite/pull/1532#issuecomment-546765051 Thanks a lot @DonnyZone ~ This is an

[GitHub] [calcite] DonnyZone commented on issue #1532: [CALCITE-3448] AggregateOnProjectToAggregateUnifyRule ignores Project…

2019-10-27 Thread GitBox
DonnyZone commented on issue #1532: [CALCITE-3448] AggregateOnProjectToAggregateUnifyRule ignores Project… URL: https://github.com/apache/calcite/pull/1532#issuecomment-546764698 Hi @jinxing64, sorry for the late reply! I'm outing these days, and I will take a look tomorrow.

[GitHub] [calcite] zabetak closed pull request #1535: [CALCITE-3451] Support TableModify in RelMdNodeTypes.

2019-10-27 Thread GitBox
zabetak closed pull request #1535: [CALCITE-3451] Support TableModify in RelMdNodeTypes. URL: https://github.com/apache/calcite/pull/1535 This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch master updated: [CALCITE-3451] Support TableModify in RelMdNodeTypes (xy2953396113)

2019-10-27 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 8d65a24 [CALCITE-3451] Support TableModify

[GitHub] [calcite] amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"…

2019-10-27 Thread GitBox
amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"… URL: https://github.com/apache/calcite/pull/1510#discussion_r339356409 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"…

2019-10-27 Thread GitBox
amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"… URL: https://github.com/apache/calcite/pull/1510#discussion_r339356409 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java