[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365502033 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1746: [CALCITE-3697] Implement bit_count function

XuQianJin-Stars opened a new pull request #1746: [CALCITE-3697] Implement bit_count function URL: https://github.com/apache/calcite/pull/1746 As illustrated in [CALCITE-3697](https://issues.apache.org/jira/browse/CALCITE-3697) select bit_count(8); ++ | EXPR$0 |

[GitHub] [calcite] XuQianJin-Stars commented on issue #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

XuQianJin-Stars commented on issue #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#issuecomment-573275193 hi @danny0405 Thank you very much, I will start to modify as soon as possible.

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365494895 ## File path: site/_docs/reference.md ## @@ -2099,8 +2099,11 @@ semantics. | m |

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365494846 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365494826 ## File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365494694 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonInsertFunction.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365494728 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365494677 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonInsertFunction.java

[GitHub] [calcite] cshuo commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

cshuo commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r365494265 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1731: [CALCITE-3707] Implement COSH function

XuQianJin-Stars commented on a change in pull request #1731: [CALCITE-3707] Implement COSH function URL: https://github.com/apache/calcite/pull/1731#discussion_r365494143 ## File path: site/_docs/reference.md ## @@ -2296,6 +2296,7 @@ semantics. | p | expr :: type

[GitHub] [calcite] danny0405 commented on issue #1744: Move logging-related tests to src/loggingTest

danny0405 commented on issue #1744: Move logging-related tests to src/loggingTest URL: https://github.com/apache/calcite/pull/1744#issuecomment-573270085 Well, what i mostly want is a tool to test the logging behavior, i.e. a tool base method, or an annotation, because i have only one

[GitHub] [calcite] vlsi opened a new pull request #1745: WIP: prefer rules that reduce the number of relations

vlsi opened a new pull request #1745: WIP: prefer rules that reduce the number of relations URL: https://github.com/apache/calcite/pull/1745 The idea is to prefer coalescing the relations rather than adding new ones. This is

[GitHub] [calcite] vlsi commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

vlsi commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r365345915 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] vlsi commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

vlsi commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r365345915 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[calcite] branch master updated (ec9231a -> e96a9aa)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from ec9231a Use concurrent test execution by default add e96a9aa [CALCITE-3364] ClassCastException if group by

[GitHub] [calcite] zabetak closed pull request #1742: [CALCITE-3364] Can't group table function result due to a type cast error if table function returns a row with a single value

zabetak closed pull request #1742: [CALCITE-3364] Can't group table function result due to a type cast error if table function returns a row with a single value URL: https://github.com/apache/calcite/pull/1742 This is an

[GitHub] [calcite] vlsi commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#discussion_r365316717 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -127,11 +137,83 @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function

ritesh-kapoor commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function URL: https://github.com/apache/calcite/pull/1725#discussion_r365281586 ## File path: site/_docs/reference.md ## @@ -2325,6 +2325,7 @@ semantics. | o | RTRIM(string)

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1731: [CALCITE-3707] Implement COSH function

ritesh-kapoor commented on a change in pull request #1731: [CALCITE-3707] Implement COSH function URL: https://github.com/apache/calcite/pull/1731#discussion_r365280354 ## File path: site/_docs/reference.md ## @@ -2296,6 +2296,7 @@ semantics. | p | expr :: type

[GitHub] [calcite] ritesh-kapoor commented on issue #1736: [CALCITE-3695] Implement TANH function

ritesh-kapoor commented on issue #1736: [CALCITE-3695] Implement TANH function URL: https://github.com/apache/calcite/pull/1736#issuecomment-573072668 Looks great !! This is an automated message from the Apache Git Service.

[calcite] branch master updated (0af2a97 -> ec9231a)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 0af2a97 [CALCITE-3722] Add Hook#PLAN_BEFORE_IMPLEMENTATION to capture the plan after optimization

[GitHub] [calcite] vlsi merged pull request #1743: Use concurrent test execution by default

vlsi merged pull request #1743: Use concurrent test execution by default URL: https://github.com/apache/calcite/pull/1743 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] vlsi opened a new pull request #1744: Move logging-related tests to src/loggingTest

vlsi opened a new pull request #1744: Move logging-related tests to src/loggingTest URL: https://github.com/apache/calcite/pull/1744 @danny0405 , here's a draft of a new testing folder. It might be better to use `slf4j-test` or something like that for gathering log messages.

[GitHub] [calcite] vlsi opened a new pull request #1743: Use concurrent test execution by default

vlsi opened a new pull request #1743: Use concurrent test execution by default URL: https://github.com/apache/calcite/pull/1743 This switches test execution to the concurrent mode by default. In other words, both test classes and test methods could be executed concurrently. Note:

[GitHub] [calcite] DonnyZone opened a new pull request #1742: [CALCITE-3364] Can't group table function result due to a type cast error if table function returns a row with a single value

DonnyZone opened a new pull request #1742: [CALCITE-3364] Can't group table function result due to a type cast error if table function returns a row with a single value URL: https://github.com/apache/calcite/pull/1742 As described in

[calcite] branch master updated (3092159 -> 0af2a97)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3092159 Refine ColumnUniqueness for Subset(input=Sort) add 820f6ab Revert "[CALCITE-3285]

[GitHub] [calcite] vlsi commented on a change in pull request #1702: Patch queue: refine optimizer estimations, refine rules, normalize RexNodes, ...

vlsi commented on a change in pull request #1702: Patch queue: refine optimizer estimations, refine rules, normalize RexNodes, ... URL: https://github.com/apache/calcite/pull/1702#discussion_r365123653 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1702: Patch queue: refine optimizer estimations, refine rules, normalize RexNodes, ...

danny0405 commented on a change in pull request #1702: Patch queue: refine optimizer estimations, refine rules, normalize RexNodes, ... URL: https://github.com/apache/calcite/pull/1702#discussion_r365120817 ## File path:

[GitHub] [calcite] vlsi merged pull request #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi merged pull request #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740 This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch master updated (3acb308 -> 3092159)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3acb308 [CALCITE-2450] Reorder RexCall predicates to a canonical form add 1e9b4da [CALCITE-3713]

[GitHub] [calcite] vlsi commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#discussion_r365118346 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -127,11 +137,83 @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest

danny0405 commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#discussion_r365116823 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -127,11 +137,83

[calcite] branch master updated (5297b83 -> 3acb308)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 5297b83 [CALCITE-3719] Add hint option checker to customize the option validation add 3acb308

[GitHub] [calcite] vlsi merged pull request #1703: [CALCITE-2450] Normalize RexCall predicates when computing digest

vlsi merged pull request #1703: [CALCITE-2450] Normalize RexCall predicates when computing digest URL: https://github.com/apache/calcite/pull/1703 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] vlsi commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest

vlsi commented on a change in pull request #1740: [CALCITE-3713] Remove column names from Project#digest URL: https://github.com/apache/calcite/pull/1740#discussion_r365115741 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -127,11 +137,83 @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1738: [CALCITE-3719] Add hint option checker to customize the option

danny0405 commented on a change in pull request #1738: [CALCITE-3719] Add hint option checker to customize the option URL: https://github.com/apache/calcite/pull/1738#discussion_r365115875 ## File path: core/build.gradle.kts ## @@ -78,7 +78,7 @@ dependencies {

[GitHub] [calcite] vlsi commented on a change in pull request #1738: [CALCITE-3719] Add hint option checker to customize the option

vlsi commented on a change in pull request #1738: [CALCITE-3719] Add hint option checker to customize the option URL: https://github.com/apache/calcite/pull/1738#discussion_r365112920 ## File path: core/build.gradle.kts ## @@ -78,7 +78,7 @@ dependencies {