[GitHub] [calcite] chunweilei commented on a change in pull request #1920: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return…

2020-04-15 Thread GitBox
chunweilei commented on a change in pull request #1920: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return… URL: https://github.com/apache/calcite/pull/1920#discussion_r409319396 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @

[GitHub] [calcite] DonnyZone commented on issue #1920: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return…

2020-04-15 Thread GitBox
DonnyZone commented on issue #1920: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return… URL: https://github.com/apache/calcite/pull/1920#issuecomment-614442693 +1 This is an automated message from the Apach

[GitHub] [calcite] danny0405 opened a new pull request #1920: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return…

2020-04-15 Thread GitBox
danny0405 opened a new pull request #1920: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return… URL: https://github.com/apache/calcite/pull/1920 …s a wrong result The RelDataTypeFactory#leastRestrictive finds the common type for IN, CASE and SET operations. For c

[GitHub] [calcite] danny0405 closed pull request #1919: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return…

2020-04-15 Thread GitBox
danny0405 closed pull request #1919: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return… URL: https://github.com/apache/calcite/pull/1919 This is an automated message from the Apache Git Service. To respon

[GitHub] [calcite] DonnyZone closed pull request #1904: [CALCITE-3893] [CALCITE-3895] SQL with GROUP_ID may generate wrong plan

2020-04-15 Thread GitBox
DonnyZone closed pull request #1904: [CALCITE-3893] [CALCITE-3895] SQL with GROUP_ID may generate wrong plan URL: https://github.com/apache/calcite/pull/1904 This is an automated message from the Apache Git Service. To respo

[calcite] branch CALCITE-3894 updated (8654d4d -> d63438d)

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch CALCITE-3894 in repository https://gitbox.apache.org/repos/asf/calcite.git. discard 8654d4d [CALCITE-3894] The Union operation between DATE with TIMESTAMP returns a wrong result add d6

[GitHub] [calcite] chunweilei commented on a change in pull request #1917: [CALCITE-3910] Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

2020-04-15 Thread GitBox
chunweilei commented on a change in pull request #1917: [CALCITE-3910] Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin URL: https://github.com/apache/calcite/pull/1917#discussion_r409268046 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTe

[GitHub] [calcite] danny0405 opened a new pull request #1919: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return…

2020-04-15 Thread GitBox
danny0405 opened a new pull request #1919: [CALCITE-3894] The Union operation between DATE with TIMESTAMP return… URL: https://github.com/apache/calcite/pull/1919 …s a wrong result The RelDataTypeFactory#leastRestrictive finds the common type for IN, CASE and SET operations. For c

[calcite] 01/01: [CALCITE-3894] The Union operation between DATE with TIMESTAMP returns a wrong result

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch CALCITE-3894 in repository https://gitbox.apache.org/repos/asf/calcite.git commit 8654d4d8c9c20685c80ff633e505302be86c9697 Author: yuzhao.cyz AuthorDate: Thu Apr 16 11:48:40 2020 +0800 [C

[calcite] branch CALCITE-3894 updated (f343263 -> 8654d4d)

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch CALCITE-3894 in repository https://gitbox.apache.org/repos/asf/calcite.git. discard f343263 [CALCITE-3894] The Union operation between DATE with TIMESTAMP returns a wrong result new 86

[calcite] branch CALCITE-3894 created (now f343263)

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch CALCITE-3894 in repository https://gitbox.apache.org/repos/asf/calcite.git. at f343263 [CALCITE-3894] The Union operation between DATE with TIMESTAMP returns a wrong result This branc

[calcite] 01/01: [CALCITE-3894] The Union operation between DATE with TIMESTAMP returns a wrong result

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch CALCITE-3894 in repository https://gitbox.apache.org/repos/asf/calcite.git commit f34326382b28128dee9fb7fc4fd8f48ab111e271 Author: yuzhao.cyz AuthorDate: Thu Apr 16 11:48:40 2020 +0800 [C

[GitHub] [calcite] xndai commented on a change in pull request #1910: [CALCITE-3915] Add rule listener to report rule attempts and time at …

2020-04-15 Thread GitBox
xndai commented on a change in pull request #1910: [CALCITE-3915] Add rule listener to report rule attempts and time at … URL: https://github.com/apache/calcite/pull/1910#discussion_r409156274 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java ###

[GitHub] [calcite] xndai commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
xndai commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#discussion_r409070045 ## File path: core/src/main/java/org/apache/calcite/rel/rules/PruneEm

[GitHub] [calcite] hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#discussion_r409054562 ## File path: core/src/main/java/org/apache/calcite/adapter/enumera

[GitHub] [calcite] hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#discussion_r409044262 ## File path: core/src/main/java/org/apache/calcite/rel/rules/PruneE

[GitHub] [calcite] rubenada commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
rubenada commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#discussion_r409037055 ## File path: core/src/main/java/org/apache/calcite/rel/rules/Prun

[GitHub] [calcite] hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#discussion_r409027990 ## File path: core/src/main/java/org/apache/calcite/rel/rules/PruneE

[GitHub] [calcite] hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
hsyuan commented on a change in pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#discussion_r409028413 ## File path: core/src/test/java/org/apache/calcite/test/RelBuilderT

[GitHub] [calcite] rubenada commented on issue #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
rubenada commented on issue #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918#issuecomment-614178985 Maybe the same fix should be applied to `PruneEmptyRules.SORT_FETCH_ZERO_INSTANCE` ... ---

[GitHub] [calcite] rubenada opened a new pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread GitBox
rubenada opened a new pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation URL: https://github.com/apache/calcite/pull/1918 Jira: [CALCITE-3926](https://issues.apache.org/jira/browse/CALCITE-3926) --

[GitHub] [calcite] hsyuan commented on issue #1775: [CALCITE-3758] FilterTableScanRule generate wrong mapping for filter …

2020-04-15 Thread GitBox
hsyuan commented on issue #1775: [CALCITE-3758] FilterTableScanRule generate wrong mapping for filter … URL: https://github.com/apache/calcite/pull/1775#issuecomment-614131171 Will do. This is an automated message from the Ap

[GitHub] [calcite] jinxing64 commented on issue #1775: [CALCITE-3758] FilterTableScanRule generate wrong mapping for filter …

2020-04-15 Thread GitBox
jinxing64 commented on issue #1775: [CALCITE-3758] FilterTableScanRule generate wrong mapping for filter … URL: https://github.com/apache/calcite/pull/1775#issuecomment-614130152 @julianhyde @hsyuan Could you please take a look at this ? :D

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1915: [CALCITE-3921] Support serialize TableModify to json string and deserialize from it

2020-04-15 Thread GitBox
yanlin-Lynn commented on a change in pull request #1915: [CALCITE-3921] Support serialize TableModify to json string and deserialize from it URL: https://github.com/apache/calcite/pull/1915#discussion_r408808777 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/Re

[calcite] branch master updated: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly (neoReMinD)

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new dfb842e [CALCITE-3924] Fix flakey test to h

[GitHub] [calcite] danny0405 closed pull request #1916: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly

2020-04-15 Thread GitBox
danny0405 closed pull request #1916: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly URL: https://github.com/apache/calcite/pull/1916 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] jinxing64 commented on issue #1775: [CALCITE-3758] FilterTableScanRule generate wrong mapping for filter …

2020-04-15 Thread GitBox
jinxing64 commented on issue #1775: [CALCITE-3758] FilterTableScanRule generate wrong mapping for filter … URL: https://github.com/apache/calcite/pull/1775#issuecomment-613939989 hmm,, test failed, it seems to be flaky and working by https://github.com/apache/calcite/pull/1916 ---

[calcite] branch master updated: [CALCITE-3881] SqlFunctions#addMonths yields incorrect results in some corner case (Zhenghua Gao)

2020-04-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 43261e4 [CALCITE-3881] SqlFunctions#addMont

[GitHub] [calcite] danny0405 closed pull request #1890: [CALCITE-3881] SqlFunctions#addMonths yields incorrect results in som…

2020-04-15 Thread GitBox
danny0405 closed pull request #1890: [CALCITE-3881] SqlFunctions#addMonths yields incorrect results in som… URL: https://github.com/apache/calcite/pull/1890 This is an automated message from the Apache Git Service. To respon

[GitHub] [calcite] neoremind commented on a change in pull request #1916: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly

2020-04-15 Thread GitBox
neoremind commented on a change in pull request #1916: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly URL: https://github.com/apache/calcite/pull/1916#discussion_r408653713 ## File path: core/src/main/java/org/apache/calcite/sql/type/BasicSqlType.java

[GitHub] [calcite] liyafan82 opened a new pull request #1917: [CALCITE-3910] Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

2020-04-15 Thread GitBox
liyafan82 opened a new pull request #1917: [CALCITE-3910] Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin URL: https://github.com/apache/calcite/pull/1917 Currently, ProjectJoinTransposeRule does not support push project pass SemiJoin and AntiJoin. ``` public vo

[GitHub] [calcite] neoremind commented on a change in pull request #1916: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly

2020-04-15 Thread GitBox
neoremind commented on a change in pull request #1916: [CALCITE-3924] Fix flakey test to handle TIMESTAMP and TIMESTAMP(0) correctly URL: https://github.com/apache/calcite/pull/1916#discussion_r408625051 ## File path: core/src/main/java/org/apache/calcite/sql/type/BasicSqlType.java

[GitHub] [calcite] chris-baynes commented on issue #618: [CALCITE-2157] ClickHouse dialect implementation.

2020-04-15 Thread GitBox
chris-baynes commented on issue #618: [CALCITE-2157] ClickHouse dialect implementation. URL: https://github.com/apache/calcite/pull/618#issuecomment-613856490 @danny0405 check style is fixed This is an automated message from