[GitHub] [calcite] NobiGo commented on pull request #2678: Updated to clarify DB value in system property setting

NobiGo commented on pull request #2678: URL: https://github.com/apache/calcite/pull/2678#issuecomment-1007180111 Please change the Commit info as "Site: Fix typo in howto.md" Then we can merge it. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [calcite] NobiGo commented on pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

NobiGo commented on pull request #2665: URL: https://github.com/apache/calcite/pull/2665#issuecomment-1007168740 > The Druid tests failed because of timeout, I don't know how to trigger it rerun, could any one gives advice to resolve it? According to https://calcite.apache.org/develo

[GitHub] [calcite] hannerwang commented on pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

hannerwang commented on pull request #2665: URL: https://github.com/apache/calcite/pull/2665#issuecomment-1007097386 The Druid tests failed because of timeout, I don't know how to trigger it rerun, could any one gives advice to resolve it? -- This is an automated message from the Apache

[GitHub] [calcite] NobiGo commented on a change in pull request #2657: [CALCITE-4860] In Elasticsearch adapter, support NULLS FIRST and NULLS LAST query

NobiGo commented on a change in pull request #2657: URL: https://github.com/apache/calcite/pull/2657#discussion_r779972017 ## File path: elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java ## @@ -400,6 +400,21 @@ public static void setupIn

[GitHub] [calcite] guiyanakuang commented on pull request #2632: [MINOR] Optimization of official website documentation

guiyanakuang commented on pull request #2632: URL: https://github.com/apache/calcite/pull/2632#issuecomment-100304 Thanks for the reminder, I get it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] guiyanakuang commented on a change in pull request #2632: [MINOR] Optimization of official website documentation

guiyanakuang commented on a change in pull request #2632: URL: https://github.com/apache/calcite/pull/2632#discussion_r779611953 ## File path: site/_plugins/wrap_table.rb ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

[GitHub] [calcite] ILuffZhe commented on a change in pull request #2657: [CALCITE-4860] In Elasticsearch adapter, support NULLS FIRST and NULLS LAST query

ILuffZhe commented on a change in pull request #2657: URL: https://github.com/apache/calcite/pull/2657#discussion_r779589176 ## File path: elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java ## @@ -400,6 +400,21 @@ public static void setup

[GitHub] [calcite] ILuffZhe commented on pull request #2678: Updated to clarify DB value in system property setting

ILuffZhe commented on pull request #2678: URL: https://github.com/apache/calcite/pull/2678#issuecomment-1006632162 @mans2singh That's a sharp catch. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] zabetak commented on a change in pull request #2657: [CALCITE-4860] In Elasticsearch adapter, support NULLS FIRST and NULLS LAST query

zabetak commented on a change in pull request #2657: URL: https://github.com/apache/calcite/pull/2657#discussion_r779581295 ## File path: elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java ## @@ -400,6 +400,21 @@ public static void setupI

[GitHub] [calcite] zabetak commented on pull request #2632: [MINOR] Optimization of official website documentation

zabetak commented on pull request #2632: URL: https://github.com/apache/calcite/pull/2632#issuecomment-1006612543 General reminder: Please avoid rebasing when a review is in progress unless you are requested to do so. Rebasing makes new changes harder to see. In addition, when the reviewer

[GitHub] [calcite] zabetak commented on a change in pull request #2632: [MINOR] Optimization of official website documentation

zabetak commented on a change in pull request #2632: URL: https://github.com/apache/calcite/pull/2632#discussion_r779561508 ## File path: site/_plugins/wrap_table.rb ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [calcite] zabetak commented on a change in pull request #2632: [MINOR] Optimization of official website documentation

zabetak commented on a change in pull request #2632: URL: https://github.com/apache/calcite/pull/2632#discussion_r779547953 ## File path: site/_plugins/wrap_table.rb ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [calcite] xiayutianwei1994 commented on a change in pull request #2673: [CALCITE-4910] Enhance simplify to reduce ((A OR D) and (A OR C) AND A AND B) to (A AND B) (Ziwei Liu)

xiayutianwei1994 commented on a change in pull request #2673: URL: https://github.com/apache/calcite/pull/2673#discussion_r779548486 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1506,8 +1506,46 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs un

[GitHub] [calcite] xiayutianwei1994 commented on a change in pull request #2673: [CALCITE-4910] Enhance simplify to reduce ((A OR D) and (A OR C) AND A AND B) to (A AND B) (Ziwei Liu)

xiayutianwei1994 commented on a change in pull request #2673: URL: https://github.com/apache/calcite/pull/2673#discussion_r779548486 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1506,8 +1506,46 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs un

[GitHub] [calcite] xiayutianwei1994 commented on a change in pull request #2673: [CALCITE-4910] Enhance simplify to reduce ((A OR D) and (A OR C) AND A AND B) to (A AND B) (Ziwei Liu)

xiayutianwei1994 commented on a change in pull request #2673: URL: https://github.com/apache/calcite/pull/2673#discussion_r779548486 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1506,8 +1506,46 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs un

[GitHub] [calcite] xiayutianwei1994 commented on a change in pull request #2673: [CALCITE-4910] Enhance simplify to reduce ((A OR D) and (A OR C) AND A AND B) to (A AND B) (Ziwei Liu)

xiayutianwei1994 commented on a change in pull request #2673: URL: https://github.com/apache/calcite/pull/2673#discussion_r779548486 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1506,8 +1506,46 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs un