[GitHub] [calcite] NobiGo commented on pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
NobiGo commented on pull request #2692: URL: https://github.com/apache/calcite/pull/2692#issuecomment-1020920947 @wojustme Because refactoring tests in CALCITE-4885, So please fix the conflicts and the typo above. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] NobiGo commented on a change in pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
NobiGo commented on a change in pull request #2692: URL: https://github.com/apache/calcite/pull/2692#discussion_r791339162 ## File path: site/_docs/reference.md ## @@ -1203,13 +1203,13 @@ The operator precedence and associativity, highest to lowest. | * / % ||

[GitHub] [calcite] jaystarshot opened a new pull request #2701: [CALCITE-4994] Memoizing FieldMap information in BlackBoard

2022-01-25 Thread GitBox
jaystarshot opened a new pull request #2701: URL: https://github.com/apache/calcite/pull/2701 PS-I am new in calcite so wanted your suggestions if any benchmarking, testing is required . This was a bottleneck in In my database, I had observed that for a large table involving 120

[GitHub] [calcite] wojustme commented on a change in pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
wojustme commented on a change in pull request #2692: URL: https://github.com/apache/calcite/pull/2692#discussion_r791632321 ## File path: site/_docs/reference.md ## @@ -1203,13 +1203,13 @@ The operator precedence and associativity, highest to lowest. | * / % ||

[GitHub] [calcite] NobiGo merged pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
NobiGo merged pull request #2692: URL: https://github.com/apache/calcite/pull/2692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[calcite] branch master updated: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread xiong
This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 10e8534 [CALCITE-4980] Babel parser support MyS

[GitHub] [calcite] wojustme commented on a change in pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
wojustme commented on a change in pull request #2692: URL: https://github.com/apache/calcite/pull/2692#discussion_r791632321 ## File path: site/_docs/reference.md ## @@ -1203,13 +1203,13 @@ The operator precedence and associativity, highest to lowest. | * / % ||

[GitHub] [calcite] NobiGo commented on a change in pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
NobiGo commented on a change in pull request #2692: URL: https://github.com/apache/calcite/pull/2692#discussion_r791339162 ## File path: site/_docs/reference.md ## @@ -1203,13 +1203,13 @@ The operator precedence and associativity, highest to lowest. | * / % ||

[GitHub] [calcite] NobiGo merged pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
NobiGo merged pull request #2692: URL: https://github.com/apache/calcite/pull/2692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [calcite] NobiGo commented on pull request #2692: [CALCITE-4980] Babel parser support MySQL NULL-safe equal operator '<

2022-01-25 Thread GitBox
NobiGo commented on pull request #2692: URL: https://github.com/apache/calcite/pull/2692#issuecomment-1020920947 @wojustme Because refactoring tests in CALCITE-4885, So please fix the conflicts and the typo above. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] julianhyde closed pull request #2685: [CALCITE-4885] Fluent test fixtures so that dependent projects can write parser, validator and rules tests

2022-01-25 Thread GitBox
julianhyde closed pull request #2685: URL: https://github.com/apache/calcite/pull/2685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [calcite] julianhyde commented on a change in pull request #2701: [CALCITE-4994] Memoizing FieldMap information in SqlToRelConvertor's BlackBoard

2022-01-25 Thread GitBox
julianhyde commented on a change in pull request #2701: URL: https://github.com/apache/calcite/pull/2701#discussion_r792075264 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -4817,13 +4819,17 @@ void setRoot(List inputs) { if (