[GitHub] [calcite] JiajunBernoulli commented on a change in pull request #2679: [CALCITE-4323] View query should be top node avoid losing sorting

JiajunBernoulli commented on a change in pull request #2679: URL: https://github.com/apache/calcite/pull/2679#discussion_r806395563 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -5898,17 +5965,32 @@ private void

[GitHub] [calcite] JiajunBernoulli commented on a change in pull request #2679: [CALCITE-4323] View query should be top node avoid losing sorting

JiajunBernoulli commented on a change in pull request #2679: URL: https://github.com/apache/calcite/pull/2679#discussion_r806395492 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -683,6 +683,13 @@ protected void convertSelectImpl(

[GitHub] [calcite] JiajunBernoulli commented on a change in pull request #2679: [CALCITE-4323] View query should be top node avoid losing sorting

JiajunBernoulli commented on a change in pull request #2679: URL: https://github.com/apache/calcite/pull/2679#discussion_r806393673 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -5898,17 +5965,32 @@ private void

[GitHub] [calcite] JiajunBernoulli commented on a change in pull request #2679: [CALCITE-4323] View query should be top node avoid losing sorting

JiajunBernoulli commented on a change in pull request #2679: URL: https://github.com/apache/calcite/pull/2679#discussion_r806392978 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -5898,17 +5965,32 @@ private void

[calcite] branch master updated: [CALCITE-4988] ((A IS NOT NULL OR B) AND A IS NOT NULL) can't be simplify to (A IS NOT NULL) When A is deterministic

This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 4a6e222 [CALCITE-4988] ((A IS NOT NULL OR B)

[GitHub] [calcite] NobiGo merged pull request #2699: [CALCITE-4988] ((A IS NOT NULL OR B) AND A IS NOT NULL) can't be simp…

NobiGo merged pull request #2699: URL: https://github.com/apache/calcite/pull/2699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] zabetak commented on pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated

zabetak commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-1039569036 Thanks for the reminder @korlov42 , will try to get back to this in the following days. Apologies for the delay! -- This is an automated message from the Apache Git Service.

[GitHub] [calcite] rubenada commented on a change in pull request #2690: RepeatUnion improvements: CALCITE-3673 + CALCITE-4054

rubenada commented on a change in pull request #2690: URL: https://github.com/apache/calcite/pull/2690#discussion_r805938047 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionTest.java ## @@ -233,4 +245,83 @@

[GitHub] [calcite] rubenada commented on a change in pull request #2690: RepeatUnion improvements: CALCITE-3673 + CALCITE-4054

rubenada commented on a change in pull request #2690: URL: https://github.com/apache/calcite/pull/2690#discussion_r805941605 ## File path: core/src/main/java/org/apache/calcite/rel/core/RepeatUnion.java ## @@ -61,12 +64,20 @@ */ public final int iterationLimit; + /**

[GitHub] [calcite] rubenada commented on a change in pull request #2690: RepeatUnion improvements: CALCITE-3673 + CALCITE-4054

rubenada commented on a change in pull request #2690: URL: https://github.com/apache/calcite/pull/2690#discussion_r805938047 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableRepeatUnionTest.java ## @@ -233,4 +245,83 @@

[GitHub] [calcite] korlov42 commented on pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated

korlov42 commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-1039169099 Hi, @zabetak! Sorry for pushing, but is there any chance you'll find the time to help me get this PR done? -- This is an automated message from the Apache Git Service. To

[GitHub] [calcite] thomasrebele commented on pull request #2690: RepeatUnion improvements: CALCITE-3673 + CALCITE-4054

thomasrebele commented on pull request #2690: URL: https://github.com/apache/calcite/pull/2690#issuecomment-1039086379 It would be nice if the SchemaPlus.removeTable(String) could be avoided. As there is no easy way around this: LGTM. -- This is an automated message from the Apache Git

[GitHub] [calcite] thomasrebele commented on pull request #2706: [CALCITE-4995] AssertionError caused by RelFieldTrimmer on SEMI/ANTI join

thomasrebele commented on pull request #2706: URL: https://github.com/apache/calcite/pull/2706#issuecomment-1039064528 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] asolimando commented on a change in pull request #2699: [CALCITE-4988] ((A IS NOT NULL OR B) AND A IS NOT NULL) can't be simp…

asolimando commented on a change in pull request #2699: URL: https://github.com/apache/calcite/pull/2699#discussion_r805758441 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -2157,6 +2157,82 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] asolimando commented on a change in pull request #2699: [CALCITE-4988] ((A IS NOT NULL OR B) AND A IS NOT NULL) can't be simp…

asolimando commented on a change in pull request #2699: URL: https://github.com/apache/calcite/pull/2699#discussion_r805757859 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -2157,6 +2157,82 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] zabetak closed pull request #2717: [CALCITE-5007] Upgrade H2 database version to 2.1.210

zabetak closed pull request #2717: URL: https://github.com/apache/calcite/pull/2717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] zabetak closed pull request #2716: [CALCITE-5006] Gradle tasks for launching JDBC integration tests are not working

zabetak closed pull request #2716: URL: https://github.com/apache/calcite/pull/2716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated (5b2de4e -> 5111f0f)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 5b2de4e [CALCITE-4997] Keep APPROX_COUNT_DISTINCT in some SqlDialects add 89b7091 [CALCITE-5006] Gradle

[GitHub] [calcite] zabetak commented on a change in pull request #2690: RepeatUnion improvements: CALCITE-3673 + CALCITE-4054

zabetak commented on a change in pull request #2690: URL: https://github.com/apache/calcite/pull/2690#discussion_r805648149 ## File path: core/src/main/java/org/apache/calcite/rel/core/RepeatUnion.java ## @@ -61,12 +64,20 @@ */ public final int iterationLimit; + /**

[GitHub] [calcite] rubenada commented on pull request #2690: RepeatUnion improvements: CALCITE-3673 + CALCITE-4054

rubenada commented on pull request #2690: URL: https://github.com/apache/calcite/pull/2690#issuecomment-1038833126 @zabetak @thomasrebele I would like to get these issues fixed in the next release 1.30. The proposed PR might not be perfect, but I'm not sure we will have much time for a

[GitHub] [calcite] wojustme commented on a change in pull request #2714: [CALCITE-5000] Expand `AGGREGATE_REDUCE_FUNCTIONS`, when arg of agg-call is in the aggregate's group

wojustme commented on a change in pull request #2714: URL: https://github.com/apache/calcite/pull/2714#discussion_r805601689 ## File path: core/src/test/java/org/apache/calcite/tools/PlannerTest.java ## @@ -136,6 +136,20 @@ private void checkParseAndConvert(String query,