[GitHub] [calcite] NobiGo commented on pull request #2736: Fix the Druid adapter test

2022-03-02 Thread GitBox
NobiGo commented on pull request #2736: URL: https://github.com/apache/calcite/pull/2736#issuecomment-1057738510 @zabetak Hi. Sorry to bother you. I omit the Druid Adapter test when merging CALCITE-1794. I am not familiar with this module, So if you have free time, Please review it. Thanks

[calcite] branch master updated: [CALCITE-1794] Expressions with numeric comparisons are not simplified when CAST is present

2022-03-02 Thread xiong
This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 5a6d287 [CALCITE-1794] Expressions with numeric

[GitHub] [calcite] NobiGo merged pull request #2727: [CALCITE-1794] Expressions with numeric comparisons are not simplified when CAST is present

2022-03-02 Thread GitBox
NobiGo merged pull request #2727: URL: https://github.com/apache/calcite/pull/2727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [calcite] julianhyde commented on pull request #2727: [CALCITE-1794] Simplify AND numeric comparisons when overlapping

2022-03-02 Thread GitBox
julianhyde commented on pull request #2727: URL: https://github.com/apache/calcite/pull/2727#issuecomment-1057329792 This PR looks good. @NobiGo, Can you add one or two more comments that the problem is the CAST. The .iq tests should point out the the simplified plan has only 'deptno = 25'