[GitHub] [calcite] wojustme commented on a diff in pull request #2783: [CALCITE-5109] RelMdAllPredicates and RelMdExpressionLineage support to analyze left/right join

2022-05-09 Thread GitBox
wojustme commented on code in PR #2783: URL: https://github.com/apache/calcite/pull/2783#discussion_r868762347 ## core/src/main/java/org/apache/calcite/rex/RexTableInputRef.java: ## @@ -46,10 +47,23 @@ public class RexTableInputRef extends RexInputRef { private final RelTab

[GitHub] [calcite] wojustme commented on a diff in pull request #2783: [CALCITE-5109] RelMdAllPredicates and RelMdExpressionLineage support to analyze left/right join

2022-05-09 Thread GitBox
wojustme commented on code in PR #2783: URL: https://github.com/apache/calcite/pull/2783#discussion_r868762491 ## core/src/main/java/org/apache/calcite/rex/RexTableInputRef.java: ## @@ -46,10 +47,23 @@ public class RexTableInputRef extends RexInputRef { private final RelTab

[GitHub] [calcite] wojustme commented on pull request #2783: [CALCITE-5109] RelMdAllPredicates and RelMdExpressionLineage support to analyze left/right join

2022-05-09 Thread GitBox
wojustme commented on PR #2783: URL: https://github.com/apache/calcite/pull/2783#issuecomment-1121830022 @chunweilei I'm sorry to reply you so late, because I've been a little busy lately. Code is updated, please take a time to review it. Thanks. -- This is an automated message from

[GitHub] [calcite] NobiGo opened a new pull request, #2801: [CALCITE-5138] Join on condition generates wrong plan when the condit…

2022-05-09 Thread GitBox
NobiGo opened a new pull request, #2801: URL: https://github.com/apache/calcite/pull/2801 …ion is sub-query -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] NobiGo commented on pull request #2801: [CALCITE-5138] Join on condition generates wrong plan when the condit…

2022-05-09 Thread GitBox
NobiGo commented on PR #2801: URL: https://github.com/apache/calcite/pull/2801#issuecomment-1121981341 This issue will address the normal sub-query, not the Correlate sub-query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub