[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r918551024 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -2936,7 +2936,7 @@ values (10, 'Fred')]]>

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r918550342 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -2885,7 +2885,7 @@ LogicalTableModify(table=[[CATALOG, SALES, EMPDEFAULTS]],

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r918549135 ## core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml: ## @@ -2897,7 +2897,7 @@ LogicalTableModify(table=[[SALES, EMPDEFAULTS]], operatio

[GitHub] [calcite] JiajunBernoulli commented on pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

2022-07-11 Thread GitBox
JiajunBernoulli commented on PR #2847: URL: https://github.com/apache/calcite/pull/2847#issuecomment-1181315028 @danny0405 , Would you please review the pull request that is from [CALCITE-4897](https://github.com/apache/calcite/pull/2615)? Thanks you very much~ -- This is an a

[calcite] branch main updated (724eb032d0 -> d40b55cb7a)

2022-07-11 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from 724eb032d0 Site: Add Benchao Li as committer add 85a6ecdd1d [CALCITE-5206] Parser allows MERGE with mismatched par

[calcite] 01/01: [CALCITE-5194] Cannot parse parenthesized UNION in FROM

2022-07-11 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git commit d40b55cb7af21d170ff10eff026351d8b034b917 Author: Julian Hyde AuthorDate: Wed Jun 22 17:26:56 2022 -0700 [CALCITE-5194