[GitHub] [calcite] libenchao commented on a diff in pull request #2848: [CALCITE-5201] Improve SemiJoinRule to match Join's right input which is unique for Join keys

2022-08-06 Thread GitBox
libenchao commented on code in PR #2848: URL: https://github.com/apache/calcite/pull/2848#discussion_r939600845 ## core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java: ## @@ -42,14 +43,18 @@ /** * Planner rule that creates a {@code SemiJoin} from a * {@link

[GitHub] [calcite] libenchao commented on a diff in pull request #2848: [CALCITE-5201] Improve SemiJoinRule to match Join's right input which is unique for Join keys

2022-08-06 Thread GitBox
libenchao commented on code in PR #2848: URL: https://github.com/apache/calcite/pull/2848#discussion_r939600749 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java: ## @@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,

[GitHub] [calcite] libenchao commented on pull request #2835: [CALCITE-4802] Babel parser doesn't parse IF(condition, then, else) s…

2022-08-06 Thread GitBox
libenchao commented on PR #2835: URL: https://github.com/apache/calcite/pull/2835#issuecomment-1207316952 LGTM, will merge after 48 hours if no more objections arise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] jacques-n closed pull request #2625: [wip] Introduce a new generic visitor stateless visitor pattern that RelShuttle can extend.

2022-08-06 Thread GitBox
jacques-n closed pull request #2625: [wip] Introduce a new generic visitor stateless visitor pattern that RelShuttle can extend. URL: https://github.com/apache/calcite/pull/2625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] jacques-n commented on pull request #2625: [wip] Introduce a new generic visitor stateless visitor pattern that RelShuttle can extend.

2022-08-06 Thread GitBox
jacques-n commented on PR #2625: URL: https://github.com/apache/calcite/pull/2625#issuecomment-1207293001 Abandoning as no clear solution was found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] jacques-n closed pull request #2603: [CALCITE-4882] Introduce new Lambda-based Metadata framework

2022-08-06 Thread GitBox
jacques-n closed pull request #2603: [CALCITE-4882] Introduce new Lambda-based Metadata framework URL: https://github.com/apache/calcite/pull/2603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] jacques-n commented on pull request #2603: [CALCITE-4882] Introduce new Lambda-based Metadata framework

2022-08-06 Thread GitBox
jacques-n commented on PR #2603: URL: https://github.com/apache/calcite/pull/2603#issuecomment-1207292762 Abandoning this work as there was too much contention around it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] jacques-n closed pull request #2641: [CALCITE-4934] Deploy snapshots releases on master merge

2022-08-06 Thread GitBox
jacques-n closed pull request #2641: [CALCITE-4934] Deploy snapshots releases on master merge URL: https://github.com/apache/calcite/pull/2641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] jacques-n commented on pull request #2641: [CALCITE-4934] Deploy snapshots releases on master merge

2022-08-06 Thread GitBox
jacques-n commented on PR #2641: URL: https://github.com/apache/calcite/pull/2641#issuecomment-1207292068 Abandoning due to another version being done by another committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and