[GitHub] [calcite] tjbanghart commented on a diff in pull request #2913: [CALCITE-5180] Implement BigQuery TIME_TRUNC and TIMESTAMP_TRUNC functions

tjbanghart commented on code in PR #2913: URL: https://github.com/apache/calcite/pull/2913#discussion_r975975647 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -4083,6 +4083,55 @@ void subTestIntervalSecondNegative() { .fails("(?s).*Was expec

[GitHub] [calcite] julianhyde commented on a diff in pull request #2913: [CALCITE-5180] Implement BigQuery TIME_TRUNC and TIMESTAMP_TRUNC functions

julianhyde commented on code in PR #2913: URL: https://github.com/apache/calcite/pull/2913#discussion_r975915626 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -520,7 +520,9 @@ public class SqlParserTest { "TEMPORARY",

[GitHub] [calcite] libenchao commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r975277091 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount = rowType.getFie

[GitHub] [calcite] zabetak commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r975066157 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount = rowType.getField

[GitHub] [calcite] zabetak commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r975061171 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount = rowType.getField