DeaconDesperado commented on PR #2683:
URL: https://github.com/apache/calcite/pull/2683#issuecomment-1255293057
Thank you @zabetak for the review! Checked in with changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977595733
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,15 +554,13 @@ public interface JoinRightEmptyRuleConfig extends
asolimando commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977552984
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,15 +554,13 @@ public interface JoinRightEmptyRuleConfig extends
zabetak commented on code in PR #2683:
URL: https://github.com/apache/calcite/pull/2683#discussion_r977435956
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -9210,6 +9210,23 @@ public void _testGroupExpressionEquivalenceParams() {
+
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977434703
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
zabetak commented on code in PR #2813:
URL: https://github.com/apache/calcite/pull/2813#discussion_r977414870
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableProjectRule.java:
##
@@ -42,6 +43,14 @@ protected EnumerableProjectRule(Config config) {
julianhyde commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977348821
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977335384
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
julianhyde commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977326394
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
bchapuis opened a new pull request, #2917:
URL: https://github.com/apache/calcite/pull/2917
This PR addresses
[CALCITE-5280](https://issues.apache.org/jira/browse/CALCITE-5280).
Notice that I had to remove one of the existing ST_UNION function (due to a
name clash?). Also, this
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977311883
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977311883
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977304390
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977303067
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -480,9 +486,25 @@ public interface JoinLeftEmptyRuleConfig extends
julianhyde commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977290395
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977285954
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends
kasakrisz commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r977285031
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new baf160d7fa [CALCITE-5293] Support general set
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new f8dd80fcd2 [CALCITE-5293] Support general set
zabetak closed pull request #2915: [CALCITE-5293] Support general set
operators in PruneEmptyRules
URL: https://github.com/apache/calcite/pull/2915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
20 matches
Mail list logo