[GitHub] [calcite] DeaconDesperado commented on pull request #2683: [CALCITE-4972] Qualify names for repeated structs in getFieldOrigins

2022-09-22 Thread GitBox
DeaconDesperado commented on PR #2683: URL: https://github.com/apache/calcite/pull/2683#issuecomment-1255293057 Thank you @zabetak for the review! Checked in with changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977595733 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,15 +554,13 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] asolimando commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
asolimando commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977552984 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,15 +554,13 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] zabetak commented on a diff in pull request #2683: [CALCITE-4972] Qualify names for repeated structs in getFieldOrigins

2022-09-22 Thread GitBox
zabetak commented on code in PR #2683: URL: https://github.com/apache/calcite/pull/2683#discussion_r977435956 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -9210,6 +9210,23 @@ public void _testGroupExpressionEquivalenceParams() { +

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977434703 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] zabetak commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

2022-09-22 Thread GitBox
zabetak commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r977414870 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableProjectRule.java: ## @@ -42,6 +43,14 @@ protected EnumerableProjectRule(Config config) {

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977348821 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977335384 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977326394 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] bchapuis opened a new pull request, #2917: [CALCITE-5280] Add geometry aggregate functions

2022-09-22 Thread GitBox
bchapuis opened a new pull request, #2917: URL: https://github.com/apache/calcite/pull/2917 This PR addresses [CALCITE-5280](https://issues.apache.org/jira/browse/CALCITE-5280). Notice that I had to remove one of the existing ST_UNION function (due to a name clash?). Also, this

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977311883 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977311883 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977304390 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977303067 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -480,9 +486,25 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977290395 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977285954 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

2022-09-22 Thread GitBox
kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977285031 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends

[calcite] branch site updated: [CALCITE-5293] Support general set operators in PruneEmptyRules

2022-09-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new baf160d7fa [CALCITE-5293] Support general set

[calcite] branch main updated: [CALCITE-5293] Support general set operators in PruneEmptyRules

2022-09-22 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new f8dd80fcd2 [CALCITE-5293] Support general set

[GitHub] [calcite] zabetak closed pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

2022-09-22 Thread GitBox
zabetak closed pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules URL: https://github.com/apache/calcite/pull/2915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to