[GitHub] [calcite] rubenada commented on a diff in pull request #2928: [CALCITE-5306] Support LTS JDKs and latest in testing

rubenada commented on code in PR #2928: URL: https://github.com/apache/calcite/pull/2928#discussion_r991336171 ## .github/workflows/main.yml: ## @@ -123,7 +123,7 @@ jobs: linux-openj9: Review Comment: @asolimando IIRC the problem appeared on an Ubutu + WebSphere enviro

[GitHub] [calcite] asolimando commented on a diff in pull request #2928: [CALCITE-5306] Support LTS JDKs and latest in testing

asolimando commented on code in PR #2928: URL: https://github.com/apache/calcite/pull/2928#discussion_r991252878 ## .github/workflows/main.yml: ## @@ -123,7 +123,7 @@ jobs: linux-openj9: Review Comment: Thanks @rubenada for pointing to the original discussion. Did you e

[GitHub] [calcite] wojustme commented on pull request #2686: [CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

wojustme commented on PR #2686: URL: https://github.com/apache/calcite/pull/2686#issuecomment-1273044390 @libenchao This issue/pr was so long that it took me a little time to review it. Two solutions: 1. Avoid pushing down with the operand of coalesce's operator 2. Keep pushing d