This is an automated email from the ASF dual-hosted git repository.
francischuang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git
The following commit(s) were added to refs/heads/main by this push:
new d39ca14 Update docker release sc
rubenada commented on PR #2937:
URL: https://github.com/apache/calcite/pull/2937#issuecomment-1277715384
@zabetak IMO the change makes sense, lgtm.
Have you checked if there are other rules that could benefit from the same
refactoring?
--
This is an automated message from the Apache Gi
jaystarshot commented on code in PR #2931:
URL: https://github.com/apache/calcite/pull/2931#discussion_r994622813
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -2815,6 +2815,45 @@ private SqlDialect nonOrdinalDialect() {
sql(query).o
jaystarshot commented on code in PR #2931:
URL: https://github.com/apache/calcite/pull/2931#discussion_r994622813
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -2815,6 +2815,45 @@ private SqlDialect nonOrdinalDialect() {
sql(query).o