[GitHub] [calcite] HanumathRao commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1279557853 Thanks @zabetak for the review. I have addressed all the comments except the following. _It is better to put the row count check in the matches method. When the condition is

[GitHub] [calcite] julianhyde commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

julianhyde commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r996032708 ## core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java: ## @@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {

[GitHub] [calcite] julianhyde commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

julianhyde commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r996031793 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -1258,6 +1259,26 @@ private static String toSql(RelNode root, SqlDialect

[GitHub] [calcite] l4wei opened a new pull request, #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei opened a new pull request, #2938: URL: https://github.com/apache/calcite/pull/2938 Remove unnecessary parentheses around SELECT in WITH body -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] l4wei closed pull request #2923: [CALCITE-5252] Unparsing "WITH ... AS (SELECT ... UNION SELECT ...)" missing parentheses

l4wei closed pull request #2923: [CALCITE-5252] Unparsing "WITH ... AS (SELECT ... UNION SELECT ...)" missing parentheses URL: https://github.com/apache/calcite/pull/2923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] zabetak commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

zabetak commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1278688528 @rubenada I guess there are other rules which miss a `DEFAULT` config instance. The problem though may not be so serious in every case if rules are not declared as 'RelOptRule` but as a