[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1004026696 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -3749,26 +3774,26 @@ void checkPeriodPredicate(Checker checker) { + "select * fr

[GitHub] [calcite] Rajeshwari4 closed pull request #2946: Ordinal fix

Rajeshwari4 closed pull request #2946: Ordinal fix URL: https://github.com/apache/calcite/pull/2946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[calcite-avatica] branch main updated: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/main by this push: new 644d8218e [CALCITE-5295] Read the values

[GitHub] [calcite-avatica] libenchao closed pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

libenchao closed pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields URL: https://github.com/apache/calcite-avatica/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003932604 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline

[GitHub] [calcite-avatica] F21 opened a new pull request, #187: [CALCITE-5344] Remove Travis CI configuration

F21 opened a new pull request, #187: URL: https://github.com/apache/calcite-avatica/pull/187 The ASF is discontinuing Travis CI for testing, and it will no longer be available after 31 December 2022. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [calcite] F21 opened a new pull request, #2950: [CALCITE-5344] Remove Travis CI configuration

F21 opened a new pull request, #2950: URL: https://github.com/apache/calcite/pull/2950 The ASF is discontinuing Travis CI for testing, and it will no longer be available after 31 December 2022. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003928315 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -3749,26 +3774,26 @@ void checkPeriodPredicate(Checker checker) { + "select

[GitHub] [calcite] libenchao commented on pull request #2948: [CALCITE-5340] Tests should fail when actual and expected XML reference files are not identical

libenchao commented on PR #2948: URL: https://github.com/apache/calcite/pull/2948#issuecomment-1289869013 @asolimando The PR looks great. The only question I got is why `TopDownOptTest` and `RuleMatchVisualizerTest` are not touched in this PR? -- This is an automated message from the Apac

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1003909401 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule( @Value.Immutable(singlet

[GitHub] [calcite-avatica] wnob opened a new pull request, #186: Add proper support for timestamps with timezones

wnob opened a new pull request, #186: URL: https://github.com/apache/calcite-avatica/pull/186 According to the [JDBC 4.2 spec][1], the `TIME_WITH_TIMEZONE` and `TIMESTAMP_WITH_TIMEZONE` types are meant to be accessed as `java.time.OffsetTime` and `java.time.OffsetDateTime` objects respectiv

[GitHub] [calcite] HanumathRao commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1289138925 Thank you @zabetak for the review and improvements. Please go ahead and merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] asolimando merged pull request #2947: [MINOR] Add default catalog link to test fixtures

asolimando merged PR #2947: URL: https://github.com/apache/calcite/pull/2947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

[calcite] branch main updated: [MINOR][JAVADOC] Add default catalog link to test fixtures

This is an automated email from the ASF dual-hosted git repository. asolimando pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 5d771d8c6d [MINOR][JAVADOC] Add default catalog

[GitHub] [calcite] wojustme commented on pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

wojustme commented on PR #2686: URL: https://github.com/apache/calcite/pull/2686#issuecomment-1288937219 In my opinion, this case only works on in CALCITE's optimizer or validator, which some expresion only change nullable attribute. we couldn't write an sql `cast(c1 as not integer)`, and

[GitHub] [calcite] zabetak commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1288891782 I pushed a few small changes to the PR. @HanumathRao let me know if you are OK with those so that I can rebase and merge the PR. -- This is an automated message from the Apache Git Serv

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1003201432 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) + +

[GitHub] [calcite] asolimando commented on pull request #2947: [MINOR] Add default catalog link to test fixtures

asolimando commented on PR #2947: URL: https://github.com/apache/calcite/pull/2947#issuecomment-1288630911 Thanks @JiajunBernoulli, I agree on your reasoning. Can I ask you to squash the commits? Once done, I will merge it in the next 24 hours. -- This is an automated message from the Apa

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003027206 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect(); if