[GitHub] [calcite] tanclary opened a new pull request, #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

2022-12-09 Thread GitBox
tanclary opened a new pull request, #3000: URL: https://github.com/apache/calcite/pull/3000 Implement BigQuery's TIMESTAMP_DIFF function whose parameter order differs from the standard TIMESTAMPDIFF. Add function call to parser to avoid generic function call throwing error when trying to

[GitHub] [calcite] gianm commented on pull request #2999: [CALCITE-5428] Drop minimum Guava version to 16.0.1.

2022-12-09 Thread GitBox
gianm commented on PR #2999: URL: https://github.com/apache/calcite/pull/2999#issuecomment-1344803417 Hmm. The "Checks" tab says "This job was skipped" for "Linux (JDK 8), Oldest Guava, America/New_York Timezone". I think we need that to run to verify that this change works properly. Does

[GitHub] [calcite] gianm opened a new pull request, #2999: [CALCITE-5428] Drop minimum Guava version to 16.0.1.

2022-12-09 Thread GitBox
gianm opened a new pull request, #2999: URL: https://github.com/apache/calcite/pull/2999 See https://issues.apache.org/jira/browse/CALCITE-5428. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

2022-12-09 Thread GitBox
dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1044438897 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

2022-12-09 Thread GitBox
dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1044438897 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }