[GitHub] [calcite] hannerwang commented on a diff in pull request #2745: [CALCITE-4512] GROUP BY expression with argument name same with SELEC…

2022-12-18 Thread GitBox
hannerwang commented on code in PR #2745: URL: https://github.com/apache/calcite/pull/2745#discussion_r1051847750 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6590,20 +6593,25 @@ static class ExtendedExpander extends Expander { final S

[GitHub] [calcite] julianhyde commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

2022-12-18 Thread GitBox
julianhyde commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1051695803 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -868,19 +867,35 @@ public Result visit(Sort e) { if (hasTrickyRollup(e, agg

[GitHub] [calcite] snuyanzin commented on pull request #3007: [CALCITE-5440] Bump gradle from 7.4.2 to 7.6

2022-12-18 Thread GitBox
snuyanzin commented on PR #3007: URL: https://github.com/apache/calcite/pull/3007#issuecomment-1356726972 looks like there are still issues with `./gradlew javadocAggregate` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and