[GitHub] [calcite-avatica] freastro opened a new pull request, #201: [CALCITE-5443] Reset update count when checking for more results

freastro opened a new pull request, #201: URL: https://github.com/apache/calcite-avatica/pull/201 Modifies `AvaticaStatement#getMoreResults()` to match the requirement from the JavaDoc indicating that subsequent calls to `getUpdateCount()` should return `-1`. -- This is an automated

[GitHub] [calcite] libenchao commented on a diff in pull request #2968: [CALCITE-5354] JDBC with UNNEST not working

libenchao commented on code in PR #2968: URL: https://github.com/apache/calcite/pull/2968#discussion_r1052155773 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,

[GitHub] [calcite] libenchao commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

libenchao commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1052145202 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String

[GitHub] [calcite] JiajunBernoulli commented on pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on PR #2997: URL: https://github.com/apache/calcite/pull/2997#issuecomment-1357496002 > LGTM, with the suggestions I made. > > Also, improve the commit message and bug summary. Mention MySQL, JDBC adapter, GROUP BY WITH ROLLUP, ORDER BY. Thanks for

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1052095333 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -868,19 +867,35 @@ public Result visit(Sort e) { if

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1052093557 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -868,19 +867,35 @@ public Result visit(Sort e) { if