zoudan commented on PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#issuecomment-1376623893
It seems the CI failed because of something has nothing to do with my
changes, should we rerun the CI?
--
This is an automated message from the Apache Git Service.
To respond to t
olivrlee commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065256516
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : {
}
}
+ SqlIntervalQualifier TimeUnitOrNameFor
olivrlee commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065115931
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : {
}
}
+ SqlIntervalQualifier TimeUnitOrNameFor
julianhyde commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065243893
##
babel/src/test/java/org/apache/calcite/test/BabelTest.java:
##
@@ -189,6 +189,23 @@ private void checkInfixCast(Statement statement, String
typeName, int sqlType
julianhyde commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065237286
##
babel/src/test/resources/sql/big-query.iq:
##
@@ -1691,16 +1691,38 @@ SELECT TIMESTAMP_DIFF("2001-02-01 01:00:00",
"2001-02-01 00:00:01", HOUR) AS neg
# cor
julianhyde commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065235831
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : {
}
}
+ SqlIntervalQualifier TimeUnitOrNameF
julianhyde commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065235428
##
babel/src/test/resources/sql/redshift.iq:
##
@@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01');
select date_part(minute, date '2009-01-01');
!ok
sonarcloud[bot] commented on PR #2942:
URL: https://github.com/apache/calcite/pull/2942#issuecomment-1376524034
SonarCloud Quality Gate failed. [ : {
}
}
+ SqlIntervalQualifier TimeUnitOrNameFor
olivrlee commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065115931
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : {
}
}
+ SqlIntervalQualifier TimeUnitOrNameFor
tjbanghart commented on code in PR #3009:
URL: https://github.com/apache/calcite/pull/3009#discussion_r1065108800
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5050,6 +5050,86 @@ SqlIntervalQualifier TimeUnitOrName() : {
}
}
+ SqlIntervalQualifier TimeUnitOrNameF
risdenk commented on PR #2919:
URL: https://github.com/apache/calcite/pull/2919#issuecomment-1376177689
> SonarCloud Quality Gate failed. [ {
julianhyde commented on code in PR #3022:
URL: https://github.com/apache/calcite/pull/3022#discussion_r1065030991
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4769,4 +4769,18 @@ void checkUserDefinedOrderByOver(NullCollation
nullCollation) {
sonarcloud[bot] commented on PR #2919:
URL: https://github.com/apache/calcite/pull/2919#issuecomment-1376049397
SonarCloud Quality Gate failed. [ {
return sw.toString();
}
+
risdenk commented on code in PR #2919:
URL: https://github.com/apache/calcite/pull/2919#discussion_r1064920908
##
core/src/main/java/org/apache/calcite/util/Util.java:
##
@@ -1048,6 +1048,19 @@ public static String getStackTrace(Throwable t) {
return sw.toString();
}
+
zabetak closed pull request #3021: Add dead methods to test code coverage
output (Only for testing purposes, please ignore)
URL: https://github.com/apache/calcite/pull/3021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
zabetak closed pull request #3019: [CALCITE-5427] Provide code quality/coverage
metrics with Jacoco and Sonarcloud
URL: https://github.com/apache/calcite/pull/3019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new be7135cf1f [CALCITE-5427] Provide code quality/cov
zabetak commented on code in PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#discussion_r1064578615
##
core/src/test/java/org/apache/calcite/avatica/UnregisteredDriverTest.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
zabetak commented on code in PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#discussion_r1064576196
##
core/src/test/java/org/apache/calcite/avatica/UnregisteredDriverTest.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
zoudan commented on code in PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#discussion_r1064550200
##
core/src/test/java/org/apache/calcite/avatica/UnregisteredDriverTest.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
zabetak commented on code in PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#discussion_r1064540782
##
core/src/test/java/org/apache/calcite/avatica/UnregisteredDriverTest.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
zoudan commented on code in PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#discussion_r1064519603
##
core/src/main/java/org/apache/calcite/avatica/UnregisteredDriver.java:
##
@@ -127,6 +127,9 @@ private static RuntimeException handle(String msg,
Throwable e) {
zabetak commented on code in PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#discussion_r1064475716
##
core/src/main/java/org/apache/calcite/avatica/UnregisteredDriver.java:
##
@@ -127,6 +127,9 @@ private static RuntimeException handle(String msg,
Throwable e)
zabetak commented on PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#issuecomment-1375378111
@zoudan For some reason [Automatic
analysis|https://docs.sonarcloud.io/advanced-setup/automatic-analysis/] was
enabled for Avatica but it was not my doing. Feel free to ignore the e
zoudan commented on PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#issuecomment-1375310584
Hi @zabetak, sorry to bother you, but this PR get failed with sonarcloud. I
have checked the error message, the error code is not from my change in this
PR. Did I do something wrong?
sonarcloud[bot] commented on PR #204:
URL: https://github.com/apache/calcite-avatica/pull/204#issuecomment-1375263566
SonarCloud Quality Gate failed. [