[GitHub] [calcite] chunweilei commented on a diff in pull request #2932: [CALCITE-5304] RelJson should support RexSubQuery

2023-01-12 Thread GitBox
chunweilei commented on code in PR #2932: URL: https://github.com/apache/calcite/pull/2932#discussion_r1069024265 ## core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java: ## @@ -122,10 +127,32 @@ public RelJson withInputTranslator(InputTranslator inputTranslator)

[GitHub] [calcite] chunweilei commented on a diff in pull request #2981: [CALCITE-5283] Add ARG_MIN, ARG_MAX aggregate functions

2023-01-12 Thread GitBox
chunweilei commented on code in PR #2981: URL: https://github.com/apache/calcite/pull/2981#discussion_r1069003834 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -1849,6 +1849,17 @@ public static > T greatest(T b0, T b1) { return b0 == null || b1

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2942: (do not merge)

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2942: URL: https://github.com/apache/calcite/pull/2942#issuecomment-1381202178 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [calcite] tanclary opened a new pull request, #3025: [CALCITE-5464] Implement BigQuery DATE_ADD/DATE_DIFF

2023-01-12 Thread GitBox
tanclary opened a new pull request, #3025: URL: https://github.com/apache/calcite/pull/3025 This is a draft PR for beginning work on BigQuery DATE_ADD() and DATE_DIFF() functions. DATE_ADD() is currently functioning as expected. DATE_DIFF() is facing a small issue where 'week' is not

[GitHub] [calcite] tanclary opened a new pull request, #3024: [CALCITE-5469] Implement BigQuery DATETIME_ADD/DATETIME_DIFF

2023-01-12 Thread GitBox
tanclary opened a new pull request, #3024: URL: https://github.com/apache/calcite/pull/3024 This is a beginning draft for the work to implement BigQuery DATETIME_ADD/DATETIME_DIFF. Currently, DATETIME_ADD is functioning as expected and is passing all operator and quidem tests.

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2991: [CALCITE-5407] Fix ARRAY conversion in MongoDB adapter

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2991: URL: https://github.com/apache/calcite/pull/2991#issuecomment-1381192981 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated: [CALCITE-5407] MongoDB adapter throws NullPointerException when converting an array

2023-01-12 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new c330aa30fd [CALCITE-5407] MongoDB adapter throws

[calcite] branch main updated: [CALCITE-5405] MongoDB adapter does not parse dates correctly

2023-01-12 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ad145397d9 [CALCITE-5405] MongoDB adapter does not

[GitHub] [calcite] julianhyde merged pull request #2990: [CALCITE-5405] Fix TIMESTAMP conversion in MongoDB adapter

2023-01-12 Thread GitBox
julianhyde merged PR #2990: URL: https://github.com/apache/calcite/pull/2990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] julianhyde commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-12 Thread GitBox
julianhyde commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1068629832 ## babel/src/test/resources/sql/redshift.iq: ## @@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01'); select date_part(minute, date '2009-01-01'); !ok

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

2023-01-12 Thread GitBox
olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1068601759 ## babel/src/test/resources/sql/redshift.iq: ## @@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01'); select date_part(minute, date '2009-01-01'); !ok

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2991: [CALCITE-5407] Fix ARRAY conversion in MongoDB adapter

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2991: URL: https://github.com/apache/calcite/pull/2991#issuecomment-1380387865 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2990: [CALCITE-5405] Fix TIMESTAMP conversion in MongoDB adapter

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #2990: URL: https://github.com/apache/calcite/pull/2990#issuecomment-1380374498 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #3022: [CALCITE-5468] SqlToRelConverter throws if ORDER BY contains IN

2023-01-12 Thread GitBox
dssysolyatin commented on code in PR #3022: URL: https://github.com/apache/calcite/pull/3022#discussion_r1068114659 ## core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java: ## @@ -4769,4 +4769,18 @@ void checkUserDefinedOrderByOver(NullCollation nullCollation)