[GitHub] [calcite] libenchao commented on a diff in pull request #2974: [CALCITE-5209] ArrayIndexOutOfBoundsException during SqlToRelConverter for group-by on `case` having `in` expression predicates

2023-01-14 Thread GitBox
libenchao commented on code in PR #2974: URL: https://github.com/apache/calcite/pull/2974#discussion_r1070491944 ## core/src/test/resources/sql/agg.iq: ## @@ -3467,4 +3467,38 @@ order by ename, deptno; !ok +# Test cases for [CALCITE-5209] ArrayIndexOutOfBoundsException

[GitHub] [calcite] libenchao commented on a diff in pull request #2932: [CALCITE-5304] RelJson should support RexSubQuery

2023-01-14 Thread GitBox
libenchao commented on code in PR #2932: URL: https://github.com/apache/calcite/pull/2932#discussion_r1070270379 ## core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java: ## @@ -122,10 +127,32 @@ public RelJson withInputTranslator(InputTranslator inputTranslator)

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3030: [CALCITE-5479] Adjust handling of iFormalOperand in sequence and interval checkers.

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #3030: URL: https://github.com/apache/calcite/pull/3030#issuecomment-1382697697 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3029: [CALCITE-5478] Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive.

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #3029: URL: https://github.com/apache/calcite/pull/3029#issuecomment-1382695349 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] gianm opened a new pull request, #3030: [CALCITE-5479] Adjust handling of iFormalOperand in sequence and interval checkers.

2023-01-14 Thread GitBox
gianm opened a new pull request, #3030: URL: https://github.com/apache/calcite/pull/3030 1) Revert change from 33f4ab40bbee26e06209061c35a422f2f1e05371 that sent nonzero formal operands to any checkers in a sequence that are not FamilyOperandTypeChecker. 2) Adjust

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3028: [CALCITE-5477] Prefer Util.checkArgument over Preconditions.checkArgument

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #3028: URL: https://github.com/apache/calcite/pull/3028#issuecomment-1382693927 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] gianm opened a new pull request, #3029: [CALCITE-5478] Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive.

2023-01-14 Thread GitBox
gianm opened a new pull request, #3029: URL: https://github.com/apache/calcite/pull/3029 Some code exists to do this for other types, but not datetimes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to