[GitHub] [calcite] sonarcloud[bot] commented on pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3031: URL: https://github.com/apache/calcite/pull/3031#issuecomment-1386252119 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] olivrlee commented on a diff in pull request #3023: [CALCITE-5180] Implement BigQuery Date/Time Type Aliases and Constructors

2023-01-17 Thread GitBox
olivrlee commented on code in PR #3023: URL: https://github.com/apache/calcite/pull/3023#discussion_r1072911432 ## babel/src/test/resources/sql/big-query.iq: ## @@ -1097,12 +1097,74 @@ select unix_date(datetime '2008-12-25') as d; # # Return Data Type: DATE -select

[GitHub] [calcite] birschick-bq commented on a diff in pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-17 Thread GitBox
birschick-bq commented on code in PR #3031: URL: https://github.com/apache/calcite/pull/3031#discussion_r1072879759 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectAggregateMergeRule.java: ## @@ -99,7 +100,8 @@ && kindCount(project.getProjects(), SqlKind.CASE) == 0) {

[GitHub] [calcite] clesaec commented on a diff in pull request #3031: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-17 Thread GitBox
clesaec commented on code in PR #3031: URL: https://github.com/apache/calcite/pull/3031#discussion_r1072284872 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectAggregateMergeRule.java: ## @@ -99,7 +100,8 @@ && kindCount(project.getProjects(), SqlKind.CASE) == 0) {

[calcite] branch main updated: [CALCITE-5475] Improve test coverage accuracy by aggregating modules

2023-01-17 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new fe821caaa5 [CALCITE-5475] Improve test coverage

[GitHub] [calcite] zabetak closed pull request #3027: [CALCITE-5475] Improve test coverage accuracy by aggregating modules

2023-01-17 Thread GitBox
zabetak closed pull request #3027: [CALCITE-5475] Improve test coverage accuracy by aggregating modules URL: https://github.com/apache/calcite/pull/3027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go