[GitHub] [calcite] sonarcloud[bot] commented on pull request #3038: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3038: URL: https://github.com/apache/calcite/pull/3038#issuecomment-1398008354 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] libenchao opened a new pull request, #3038: [CALCITE-5483] ProjectAggregateMergeRule throws exception if literal is non-numeric

2023-01-19 Thread GitBox
libenchao opened a new pull request, #3038: URL: https://github.com/apache/calcite/pull/3038 This PR is based on https://github.com/apache/calcite/pull/3031 from @birschick-bq -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[calcite] branch main updated: [CALCITE-5466] The constant condition can't be inferred from correlate node

2023-01-19 Thread libenchao
This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new fb340ece8c [CALCITE-5466] The constant

[GitHub] [calcite] libenchao closed pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
libenchao closed pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr… URL: https://github.com/apache/calcite/pull/3035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] sonarcloud[bot] commented on pull request #2981: [CALCITE-5283] Add ARG_MIN, ARG_MAX aggregate functions

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #2981: URL: https://github.com/apache/calcite/pull/2981#issuecomment-1397858121 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3036: [CALCITE-5424] Custom literals

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3036: URL: https://github.com/apache/calcite/pull/3036#issuecomment-1397828527 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] olivrlee commented on a diff in pull request #3036: [CALCITE-5424] Custom literals

2023-01-19 Thread GitBox
olivrlee commented on code in PR #3036: URL: https://github.com/apache/calcite/pull/3036#discussion_r1082033615 ## core/src/main/java/org/apache/calcite/sql/SqlUnknownLiteral.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3036: [CALCITE-5424] Custom literals

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3036: URL: https://github.com/apache/calcite/pull/3036#issuecomment-1397815215 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
julianhyde commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081992148 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
julianhyde commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081983370 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[calcite-site] branch main updated: Website deployed from calcite-avatica@aace9126b954c4adc36e9b1eb0d4ab8b8951c576

2023-01-19 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new caca68a9 Website deployed from

[GitHub] [calcite-avatica] julianhyde merged pull request #202: (do not merge) avatica staging

2023-01-19 Thread GitBox
julianhyde merged PR #202: URL: https://github.com/apache/calcite-avatica/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite-avatica] branch main updated (02c5fa153 -> aace9126b)

2023-01-19 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git from 02c5fa153 [CALCITE-5443] After Statement.getMoreResults() has returned false, Statement.getUpdateCount()

[calcite-avatica] 01/01: Prepare for next development iteration

2023-01-19 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git commit aace9126b954c4adc36e9b1eb0d4ab8b8951c576 Author: Julian Hyde AuthorDate: Thu Jan 19 13:45:22 2023 -0800

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081880447 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081880447 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081880447 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite-avatica] wnob commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081852921 ## core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java: ## @@ -238,12 +244,18 @@ protected Accessor createAccessor(ColumnMetaData

[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-19 Thread GitBox
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1081846240 ## core/src/main/java/org/apache/calcite/sql/fun/SqlBigQueryFormatDatetimeFunction.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-19 Thread GitBox
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1081843370 ## core/src/main/java/org/apache/calcite/sql/fun/SqlBigQueryFormatDatetimeFunction.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-19 Thread GitBox
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1081837725 ## core/src/main/java/org/apache/calcite/sql/SqlDialect.java: ## @@ -1002,6 +1004,18 @@ protected static void unparseOffset(SqlWriter writer, @Nullable SqlNode

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
julianhyde commented on code in PR #205: URL: https://github.com/apache/calcite-avatica/pull/205#discussion_r1081816343 ## core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java: ## @@ -77,7 +78,9 @@ public AvaticaResultSet(AvaticaStatement statement,

[GitHub] [calcite-avatica] wnob closed pull request #186: [CALCITE-5308] Add support for TIMESTAMP WITH LOCAL TIME ZONE and microsecond-precision

2023-01-19 Thread GitBox
wnob closed pull request #186: [CALCITE-5308] Add support for TIMESTAMP WITH LOCAL TIME ZONE and microsecond-precision URL: https://github.com/apache/calcite-avatica/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite-avatica] wnob commented on pull request #186: [CALCITE-5308] Add support for TIMESTAMP WITH LOCAL TIME ZONE and microsecond-precision

2023-01-19 Thread GitBox
wnob commented on PR #186: URL: https://github.com/apache/calcite-avatica/pull/186#issuecomment-1397531597 Superceded by https://github.com/apache/calcite-avatica/pull/205 which focuses just on the type support and punts on precision for now. -- This is an automated message from the

[GitHub] [calcite-avatica] wnob opened a new pull request, #205: [CALCITE-5487] Proper semantics for TIMESTAMP WITH LOCAL TIME ZONE

2023-01-19 Thread GitBox
wnob opened a new pull request, #205: URL: https://github.com/apache/calcite-avatica/pull/205 This is a work-in-progress as there are still some tests failing, but I believe the proper semantics are now codified in `AvaticaResultSetConversionsTest`. Was hoping to get some early feedback to

[calcite-avatica] annotated tag rel/avatica-1.23.0 updated (fab03540d -> 9b9f8f9cb)

2023-01-19 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to annotated tag rel/avatica-1.23.0 in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git *** WARNING: tag rel/avatica-1.23.0 was modified! *** from fab03540d (commit) to

svn commit: r59447 - /dev/calcite/apache-calcite-avatica-1.23.0-rc0/ /release/calcite/apache-calcite-avatica-1.23.0/

2023-01-19 Thread jhyde
Author: jhyde Date: Thu Jan 19 18:42:31 2023 New Revision: 59447 Log: Promoting Apache Calcite Avatica avatica-1.23.0-rc0 -> rel/avatica-1.23.0 to release area Added: release/calcite/apache-calcite-avatica-1.23.0/

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3035: URL: https://github.com/apache/calcite/pull/3035#issuecomment-1397056502 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] Aitozi commented on a diff in pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
Aitozi commented on code in PR #3035: URL: https://github.com/apache/calcite/pull/3035#discussion_r1081278261 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -3002,6 +3002,32 @@ private void

[GitHub] [calcite] libenchao commented on a diff in pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
libenchao commented on code in PR #3035: URL: https://github.com/apache/calcite/pull/3035#discussion_r1081180900 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -3002,6 +3002,32 @@ private void

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3035: [CALCITE-5466] Fix the constant condition can't be reduced after corr…

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #3035: URL: https://github.com/apache/calcite/pull/3035#issuecomment-1396589034 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png