[GitHub] [calcite] julianhyde commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-23 Thread via GitHub
julianhyde commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1084692468 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3037: [CALCITE-5446] TIMESTAMP_WITH_LOCAL_TIMEZONE in JDBC

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3037: URL: https://github.com/apache/calcite/pull/3037#issuecomment-1401214871 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3039: [CALCITE-5180] DATE/TIME type alias + constructors

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3039: URL: https://github.com/apache/calcite/pull/3039#issuecomment-1401213771 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3036: [CALCITE-5424] Custom literals

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3036: URL: https://github.com/apache/calcite/pull/3036#issuecomment-1401202207 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3037: [CALCITE-5446] TIMESTAMP_WITH_LOCAL_TIMEZONE in JDBC

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3037: URL: https://github.com/apache/calcite/pull/3037#issuecomment-1401200144 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3039: [CALCITE-5180] DATE/TIME type alias + constructors

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3039: URL: https://github.com/apache/calcite/pull/3039#issuecomment-1401186643 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] mkou commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-23 Thread via GitHub
mkou commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1084676486 ## core/src/main/java/org/apache/calcite/util/format/FormatModelUtil.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [calcite] mkou commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-23 Thread via GitHub
mkou commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1084652713 ## core/src/main/java/org/apache/calcite/util/format/FormatModelUtil.java: ## @@ -30,44 +32,34 @@ private FormatModelUtil() {} /** * Parses the {@code fmtString}

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3041: [CALCITE-5491] Allow TIME and DATE to be args for TIMESTAMPDIFF

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3041: URL: https://github.com/apache/calcite/pull/3041#issuecomment-1401117763 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] mkou commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-23 Thread via GitHub
mkou commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1084652713 ## core/src/main/java/org/apache/calcite/util/format/FormatModelUtil.java: ## @@ -30,44 +32,34 @@ private FormatModelUtil() {} /** * Parses the {@code fmtString}

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3039: [CALCITE-5180] DATE/TIME type alias + constructors

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3039: URL: https://github.com/apache/calcite/pull/3039#issuecomment-1401105112 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] snuyanzin opened a new pull request, #3041: [CALCITE-5491] Allow TIME and DATE to be args for TIMESTAMPDIFF

2023-01-23 Thread via GitHub
snuyanzin opened a new pull request, #3041: URL: https://github.com/apache/calcite/pull/3041 The PR allows to have `TIME` and `DATE` types args for `TIMESTAMPDIFF` as it was for 1.32.0 and earlier -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3040: [CALCITE-5489] Cannot convert TIMESTAMP literal to class org.apache.calcite.avatica.util.TimeUnit

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3040: URL: https://github.com/apache/calcite/pull/3040#issuecomment-1400262801 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3040: [CALCITE-5489] Cannot convert TIMESTAMP literal to class org.apache.calcite.avatica.util.TimeUnit

2023-01-23 Thread sonarcloud
sonarcloud[bot] commented on PR #3040: URL: https://github.com/apache/calcite/pull/3040#issuecomment-1400225398 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qual

[GitHub] [calcite] snuyanzin opened a new pull request, #3040: [CALCITE-5489] Cannot convert TIMESTAMP literal to class org.apache.calcite.avatica.util.TimeUnit

2023-01-23 Thread via GitHub
snuyanzin opened a new pull request, #3040: URL: https://github.com/apache/calcite/pull/3040 It seems a regression after https://github.com/apache/calcite/pull/2998 The failing test (which is passing on 1.32) is at `org.apache.calcite.rex.RexBuilderTest#testTimestampDiffCall` -- Th