sonarcloud[bot] commented on PR #3113:
URL: https://github.com/apache/calcite/pull/3113#issuecomment-1573248543
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new 295df907d1 [CALCITE-5730] Initial null values can
rubenada merged PR #3228:
URL: https://github.com/apache/calcite/pull/3228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.a
snuyanzin commented on code in PR #3113:
URL: https://github.com/apache/calcite/pull/3113#discussion_r1213976159
##
site/_docs/history.md:
##
@@ -43,6 +43,10 @@ z.
Breaking Changes
{: #breaking-1-35-0}
+The way of Locale parsing changed within [https://issues.apache.org
sonarcloud[bot] commented on PR #3212:
URL: https://github.com/apache/calcite/pull/3212#issuecomment-1573215321
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
sonarcloud[bot] commented on PR #3212:
URL: https://github.com/apache/calcite/pull/3212#issuecomment-1573168602
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
sonarcloud[bot] commented on PR #3212:
URL: https://github.com/apache/calcite/pull/3212#issuecomment-1573112867
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
sonarcloud[bot] commented on PR #3212:
URL: https://github.com/apache/calcite/pull/3212#issuecomment-157329
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213866726
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -629,6 +629,8 @@ public enum BuiltInMethod {
SUBMULTISET_OF(SqlFunctions.class, "submultise
liuyongvs commented on PR #3212:
URL: https://github.com/apache/calcite/pull/3212#issuecomment-1573106351
@JiajunBernoulli fix all your reviews and squash the commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213866726
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -629,6 +629,8 @@ public enum BuiltInMethod {
SUBMULTISET_OF(SqlFunctions.class, "submultise
liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213864303
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -500,7 +515,7 @@ public static SqlCall stripSeparator(SqlCall call) {
* Returns the elem
JiajunBernoulli commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213835525
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -629,6 +629,8 @@ public enum BuiltInMethod {
SUBMULTISET_OF(SqlFunctions.class, "subm
JiajunBernoulli commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213832112
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -500,7 +515,7 @@ public static SqlCall stripSeparator(SqlCall call) {
* Returns th
This is an automated email from the ASF dual-hosted git repository.
jiajunxie pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new d98f96d830 [CALCITE-5723] Oracle dialect generat
JiajunBernoulli merged PR #3225:
URL: https://github.com/apache/calcite/pull/3225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ca
sonarcloud[bot] commented on PR #3054:
URL: https://github.com/apache/calcite/pull/3054#issuecomment-1572950445
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
sonarcloud[bot] commented on PR #3236:
URL: https://github.com/apache/calcite/pull/3236#issuecomment-1572938505
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
liuyongvs commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213775021
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -496,6 +496,71 @@ public static SqlOperandTypeChecker variadic(
public static final SqlS
liuyongvs commented on PR #3236:
URL: https://github.com/apache/calcite/pull/3236#issuecomment-1572926486
hi @tanclary thanks for your review, i have fixed all your reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
liuyongvs commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213775021
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -496,6 +496,71 @@ public static SqlOperandTypeChecker variadic(
public static final SqlS
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1572795640
It took about 6 minutes to run 10K tests using CalciteExecutor, so by
extrapolation it would take about 2 days to run all tests.
Memory consumption increases slightly with time. The
tanclary commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213435538
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -3061,6 +3063,28 @@ private static class ReinterpretImplementor extends
AbstractRe
tanclary commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213433111
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -3061,6 +3063,28 @@ private static class ReinterpretImplementor extends
AbstractRe
MasseGuillaume commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213430245
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -3061,6 +3063,28 @@ private static class ReinterpretImplementor extends
Abst
tanclary commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213408832
##
site/_docs/reference.md:
##
@@ -2658,6 +2658,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| s | ARRAY_REPEAT(element, cou
tanclary commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213406654
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -308,6 +308,7 @@ public enum BuiltInMethod {
COLLECTIONS_REVERSE_ORDER(Collections.class, "r
snuyanzin commented on code in PR #3113:
URL: https://github.com/apache/calcite/pull/3113#discussion_r1213265269
##
core/src/main/java/org/apache/calcite/util/Util.java:
##
@@ -1717,16 +1719,14 @@ private static void appendPosixTime(StringBuilder buf,
int millis) {
* @retur
snuyanzin commented on code in PR #3113:
URL: https://github.com/apache/calcite/pull/3113#discussion_r1213265269
##
core/src/main/java/org/apache/calcite/util/Util.java:
##
@@ -1717,16 +1719,14 @@ private static void appendPosixTime(StringBuilder buf,
int millis) {
* @retur
rubenada commented on code in PR #3113:
URL: https://github.com/apache/calcite/pull/3113#discussion_r1213257423
##
core/src/main/java/org/apache/calcite/util/Util.java:
##
@@ -1717,16 +1719,14 @@ private static void appendPosixTime(StringBuilder buf,
int millis) {
* @return
rubenada commented on code in PR #3113:
URL: https://github.com/apache/calcite/pull/3113#discussion_r1213256693
##
site/_docs/history.md:
##
@@ -43,6 +43,10 @@ z.
Breaking Changes
{: #breaking-1-35-0}
+The way of Locale parsing changed within [https://issues.apache.org/
sonarcloud[bot] commented on PR #3113:
URL: https://github.com/apache/calcite/pull/3113#issuecomment-1572028969
Kudos, SonarCloud Quality Gate passed! [ {
}
sonarcloud[bot] commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571675075
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qual
gf2121 commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571654729
@rubenada No problem! I've squashed the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rubenada commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571617897
Thanks @gf2121 ! Sorry, it was actually my fault, I had included that
comment as part of a review... and I did not publish it :sweat: , so it
appeared as "pending" on my side (and it wa
sonarcloud[bot] commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571612926
Kudos, SonarCloud Quality Gate passed! [, use asc/desc on order by, use
different columns (not always commi
rubenada commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571490053
Thanks for your review, @thomasrebele ! And no problem at all, I also missed
this during the review of EnumerableLimitSort. .
@gf2121 what's the status here? Do you have time for t
40 matches
Mail list logo
