Re: [PR] [CALCITE-6422] RexLiteral.isNullLiteral should be applied before RexLiteral.booleanValue in SubstitutionVisitor.mayBeSatisfiable [calcite]

2024-05-29 Thread via GitHub
l4wei commented on PR #3800: URL: https://github.com/apache/calcite/pull/3800#issuecomment-2138555765 @YiwenWu Can you merge this PR into main branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CALCITE-6422] RexLiteral.isNullLiteral should be applied before RexLiteral.booleanValue in SubstitutionVisitor.mayBeSatisfiable [calcite]

2024-05-29 Thread via GitHub
l4wei commented on PR #3800: URL: https://github.com/apache/calcite/pull/3800#issuecomment-2138555267 @YiwenWu Can you merge this PR into main branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CALCITE-6370] AS operator problems with USING clause [calcite]

2024-05-29 Thread via GitHub
NobiGo commented on code in PR #3797: URL: https://github.com/apache/calcite/pull/3797#discussion_r1619528034 ## core/src/main/java/org/apache/calcite/sql/util/SqlShuttle.java: ## @@ -135,6 +135,7 @@ public CallCopyingArgHandler(SqlCall call, boolean alwaysCopy) { if (ne

(calcite) branch main updated: [CALCITE-6419] Invalid unparse for VARCHAR without precision in HiveSqlDialect And SparkSqlDialect

2024-05-29 Thread xiong
This is an automated email from the ASF dual-hosted git repository. xiong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new b9455ef08d [CALCITE-6419] Invalid unparse for VARCHA

Re: [PR] [CALCITE-6419] Invalid unparse for VARCHAR without precision in HiveS… [calcite]

2024-05-29 Thread via GitHub
NobiGo merged PR #3799: URL: https://github.com/apache/calcite/pull/3799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apa

Re: [PR] [CALCITE-6411] Support Collect in ToLogicalConverter [calcite]

2024-05-29 Thread via GitHub
sonarcloud[bot] commented on PR #3803: URL: https://github.com/apache/calcite/pull/3803#issuecomment-2137965311 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-29 Thread via GitHub
caicancai commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1619142488 ## core/src/main/java/org/apache/calcite/sql/SqlKind.java: ## @@ -421,9 +421,12 @@ public enum SqlKind { /** {@code DECODE} function (Oracle). */ DECODE, - /

[PR] [CALCITE-6411] Support Collect in ToLogicalConverter [calcite]

2024-05-29 Thread via GitHub
caicancai opened a new pull request, #3803: URL: https://github.com/apache/calcite/pull/3803 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] [Calcite 6244] Allow `Expressions#constant` to construct Immutable class models [calcite]

2024-05-29 Thread via GitHub
mihaibudiu commented on PR #3681: URL: https://github.com/apache/calcite/pull/3681#issuecomment-2137688230 In order to merge this you need to squash the commits into a single commit whose message is identical to the JIRA issue. At the same time you can rebase on main. -- This is an autom

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-29 Thread via GitHub
sonarcloud[bot] commented on PR #3785: URL: https://github.com/apache/calcite/pull/3785#issuecomment-2137464549 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-29 Thread via GitHub
YiwenWu commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1618723448 ## core/src/main/java/org/apache/calcite/sql/SqlKind.java: ## @@ -421,9 +421,12 @@ public enum SqlKind { /** {@code DECODE} function (Oracle). */ DECODE, - /**

Re: [PR] [CALCITE-6193] SubstitutionVisitor stop trying incorrect subtree beca… [calcite]

2024-05-29 Thread via GitHub
sonarcloud[bot] commented on PR #3616: URL: https://github.com/apache/calcite/pull/3616#issuecomment-2137072730 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo